From: Artem Bityutskiy <dedekind1@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Roland Stigge <stigge@antcom.de>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com,
linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com,
lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com
Subject: Re: [PATCH v6] MTD: LPC32xx SLC NAND driver
Date: Thu, 07 Jun 2012 12:11:05 +0300 [thread overview]
Message-ID: <1339060265.6875.91.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120607081108.GO8262@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Thu, 2012-06-07 at 09:11 +0100, Russell King - ARM Linux wrote:
> On Wed, Jun 06, 2012 at 04:38:41PM +0300, Artem Bityutskiy wrote:
> > On Wed, 2012-06-06 at 11:20 +0200, Roland Stigge wrote:
> > > +#else
> > > +#define lpc32xx_nand_resume NULL
> > > +#define lpc32xx_nand_suspend NULL
> > > +#endif
> >
> > 0, not NULL.
>
> Err, what planet are you on there. These are _pointers_ to functions,
> so using a _pointer_ is more correct than using an _integer_.
Yes, thanks, I was wrong.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-07 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 9:20 [PATCH v6] MTD: LPC32xx SLC NAND driver Roland Stigge
2012-06-06 9:20 ` [PATCH v5] MTD: LPC32xx MLC " Roland Stigge
2012-06-06 13:38 ` [PATCH v6] MTD: LPC32xx SLC " Artem Bityutskiy
2012-06-06 14:27 ` Roland Stigge
2012-06-06 14:36 ` Artem Bityutskiy
2012-06-07 8:11 ` Russell King - ARM Linux
2012-06-07 9:11 ` Artem Bityutskiy [this message]
2012-06-06 13:41 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339060265.6875.91.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=hechtb@googlemail.com \
--cc=kevin.wells@nxp.com \
--cc=lars@metafoo.de \
--cc=leiwen@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).