devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Zhao <richard.zhao@freescale.com>
To: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org
Cc: marex@denx.de, B20596@freescale.com, dong.aisheng@linaro.org,
	fabio.estevam@freescale.com, alexander.shishkin@linux.intel.com,
	B29397@freescale.com, balbi@ti.com, stern@rowland.harvard.edu,
	kernel@pengutronix.de, gregkh@linuxfoundation.org,
	richard.zhao@freescale.com, shawn.guo@linaro.org,
	linuxzsc@gmail.com
Subject: [Patch v5 04/13] usb: chipidea: permit driver bindings pass phy pointer
Date: Wed, 13 Jun 2012 20:34:14 +0800	[thread overview]
Message-ID: <1339590863-10564-5-git-send-email-richard.zhao@freescale.com> (raw)
In-Reply-To: <1339590863-10564-1-git-send-email-richard.zhao@freescale.com>

Sometimes, the driver bindings may know what phy they use.
For example, when using device tree, the usb controller may have a
phandler pointing to usb phy.

Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Acked-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/chipidea/ci.h    |    2 ++
 drivers/usb/chipidea/core.c  |    4 ++++
 drivers/usb/chipidea/host.c  |    1 +
 drivers/usb/chipidea/udc.c   |   11 +++++++----
 include/linux/usb/chipidea.h |    3 +++
 5 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h
index 9655e35..d738603 100644
--- a/drivers/usb/chipidea/ci.h
+++ b/drivers/usb/chipidea/ci.h
@@ -160,6 +160,8 @@ struct ci13xxx {
 
 	struct ci13xxx_platform_data	*platdata;
 	int				vbus_active;
+	/* FIXME: some day, we'll not use global phy */
+	bool				global_phy;
 	struct usb_phy			*transceiver;
 	struct usb_hcd			*hcd;
 };
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index c14ce2b..21407e7 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -419,6 +419,10 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev)
 
 	ci->dev = dev;
 	ci->platdata = dev->platform_data;
+	if (ci->platdata->phy)
+		ci->transceiver = ci->platdata->phy;
+	else
+		ci->global_phy = true;
 
 	ret = hw_device_init(ci, base);
 	if (ret < 0) {
diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
index 4a4fdb8..ebff9f4 100644
--- a/drivers/usb/chipidea/host.c
+++ b/drivers/usb/chipidea/host.c
@@ -117,6 +117,7 @@ static int host_start(struct ci13xxx *ci)
 	hcd->has_tt = 1;
 
 	hcd->power_budget = ci->platdata->power_budget;
+	hcd->phy = ci->transceiver;
 
 	ehci = hcd_to_ehci(hcd);
 	ehci->caps = ci->hw_bank.cap;
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index ca9b387..b43b29c 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1684,7 +1684,8 @@ static int udc_start(struct ci13xxx *ci)
 
 	ci->gadget.ep0 = &ci->ep0in->ep;
 
-	ci->transceiver = usb_get_transceiver();
+	if (ci->global_phy) {
+		ci->transceiver = usb_get_transceiver();
 
 	if (ci->platdata->flags & CI13XXX_REQUIRE_TRANSCEIVER) {
 		if (ci->transceiver == NULL) {
@@ -1728,7 +1729,8 @@ static int udc_start(struct ci13xxx *ci)
 remove_trans:
 	if (ci->transceiver) {
 		otg_set_peripheral(ci->transceiver->otg, &ci->gadget);
-		usb_put_transceiver(ci->transceiver);
+		if (ci->global_phy)
+			usb_put_transceiver(ci->transceiver);
 	}
 
 	dev_err(dev, "error = %i\n", retval);
@@ -1737,7 +1739,7 @@ remove_dbg:
 unreg_device:
 	device_unregister(&ci->gadget.dev);
 put_transceiver:
-	if (ci->transceiver)
+	if (ci->transceiver && ci->global_phy)
 		usb_put_transceiver(ci->transceiver);
 free_pools:
 	dma_pool_destroy(ci->td_pool);
@@ -1771,7 +1773,8 @@ static void udc_stop(struct ci13xxx *ci)
 
 	if (ci->transceiver) {
 		otg_set_peripheral(ci->transceiver->otg, NULL);
-		usb_put_transceiver(ci->transceiver);
+		if (ci->global_phy)
+			usb_put_transceiver(ci->transceiver);
 	}
 	dbg_remove_files(&ci->gadget.dev);
 	device_unregister(&ci->gadget.dev);
diff --git a/include/linux/usb/chipidea.h b/include/linux/usb/chipidea.h
index be078f0..544825d 100644
--- a/include/linux/usb/chipidea.h
+++ b/include/linux/usb/chipidea.h
@@ -5,12 +5,15 @@
 #ifndef __LINUX_USB_CHIPIDEA_H
 #define __LINUX_USB_CHIPIDEA_H
 
+#include <linux/usb/otg.h>
+
 struct ci13xxx;
 struct ci13xxx_platform_data {
 	const char	*name;
 	/* offset of the capability registers */
 	uintptr_t	 capoffset;
 	unsigned	 power_budget;
+	struct usb_phy	*phy;
 	unsigned long	 flags;
 #define CI13XXX_REGS_SHARED		BIT(0)
 #define CI13XXX_REQUIRE_TRANSCEIVER	BIT(1)
-- 
1.7.9.5

      parent reply	other threads:[~2012-06-13 12:34 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13 12:34 [Patch v5 00/13] add imx usb driver for mx28/6x Richard Zhao
2012-06-13 12:34 ` [Patch v5 02/13] USB: move transceiver from ehci_hcd and ohci_hcd to hcd and rename it as phy Richard Zhao
     [not found]   ` <1339590863-10564-3-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-13 18:17     ` Alan Stern
     [not found] ` <1339590863-10564-1-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-13 12:34   ` [Patch v5 01/13] usb: otg: add notify_connect/notify_disconnect callback Richard Zhao
2012-06-13 12:34   ` [Patch v5 03/13] USB: notify phy when root hub port connect change Richard Zhao
     [not found]     ` <1339590863-10564-4-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-13 18:25       ` Alan Stern
     [not found]         ` <Pine.LNX.4.44L0.1206131418290.1401-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-06-14  0:36           ` Richard Zhao
     [not found]             ` <20120614003653.GA29684-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2012-06-14 14:11               ` Alan Stern
2012-06-13 12:34   ` [Patch v5 05/13] usb: otg: add basic mxs phy driver support Richard Zhao
     [not found]     ` <1339590863-10564-6-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-13 21:33       ` Sascha Hauer
     [not found]         ` <20120613213312.GD30400-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-13 21:56           ` Marek Vasut
     [not found]             ` <201206132356.16093.marex-ynQEQJNshbs@public.gmane.org>
2012-06-13 22:03               ` Sascha Hauer
2012-06-14  1:12               ` Richard Zhao
2012-06-13 12:34   ` [Patch v5 06/13] usb: chipidea: add imx platform driver Richard Zhao
     [not found]     ` <1339590863-10564-7-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-13 21:46       ` Sascha Hauer
     [not found]         ` <20120613214622.GE30400-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-13 21:57           ` Marek Vasut
     [not found]             ` <201206132357.35099.marex-ynQEQJNshbs@public.gmane.org>
2012-06-13 22:07               ` Sascha Hauer
     [not found]                 ` <20120613220700.GI30400-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-14  1:21                   ` Richard Zhao
2012-06-14  1:56           ` Richard Zhao
2012-06-13 12:34   ` [Patch v5 07/13] ARM: imx6q: correct device name of usbphy and usb controller clock export Richard Zhao
2012-06-13 12:34   ` [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios Richard Zhao
     [not found]     ` <1339590863-10564-9-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-13 15:09       ` Rob Herring
     [not found]         ` <4FD8AD42.6010702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-13 15:19           ` Marek Vasut
     [not found]             ` <201206131719.29671.marex-ynQEQJNshbs@public.gmane.org>
2012-06-13 16:45               ` Rob Herring
     [not found]                 ` <4FD8C3BC.4080102-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-13 17:15                   ` Marek Vasut
2012-06-13 15:28           ` Richard Zhao
2012-06-13 16:00             ` Marek Vasut
     [not found]               ` <201206131800.38622.marex-ynQEQJNshbs@public.gmane.org>
2012-06-15 15:34                 ` Shawn Guo
2012-06-13 16:50             ` Rob Herring
     [not found]               ` <4FD8C4DB.4020908-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-14  1:33                 ` Richard Zhao
     [not found]                   ` <20120614013343.GD29684-iWYTGMXpHj9ITqJhDdzsOjpauB2SiJktrE5yTffgRl4@public.gmane.org>
2012-06-20 14:29                     ` Rob Herring
     [not found]                       ` <4FE1DE53.4070202-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-06-20 15:05                         ` Shawn Guo
     [not found]                           ` <20120620150502.GG2253-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-06-21 21:32                             ` Rob Herring
2012-06-20 15:41                         ` Stephen Warren
     [not found]                           ` <4FE1EF26.9080401-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-21  1:32                             ` Chen Peter-B29397
     [not found]                               ` <F281D0F91ED19E4D8E63A7504E8A649803BE3E73-RL0Hj/+nBVDtkydW1Tv2Dq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-06-21 22:22                                 ` Stephen Warren
     [not found]                                   ` <4FE39EA2.8050809-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-22  0:03                                     ` Chen Peter-B29397
     [not found]                                       ` <F281D0F91ED19E4D8E63A7504E8A649803BE45CD-RL0Hj/+nBVDtkydW1Tv2Dq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-06-25 15:43                                         ` Stephen Warren
     [not found]                                           ` <4FE8871B.7060408-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-06-26  2:05                                             ` Chen Peter-B29397
2012-06-19 23:36       ` Fabio Estevam
     [not found]         ` <CAOMZO5AxnOCqajCS39bpjo-86FXSV9C8fMPrhmRXH=OndfXuVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-19 23:41           ` Richard Zhao
2012-07-17 12:30     ` Dirk Behme
     [not found]       ` <50055AD9.6030807-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
2012-07-19  2:15         ` Richard Zhao
2012-06-13 12:34   ` [Patch v5 09/13] ARM: imx6q: add usbphy clocks Richard Zhao
     [not found]     ` <1339590863-10564-10-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-13 21:54       ` Sascha Hauer
     [not found]         ` <20120613215406.GF30400-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-06-14  0:15           ` Chen Peter-B29397
2012-06-13 12:34   ` [Patch v5 10/13] ARM: imx6q: disable usb charger detector Richard Zhao
2012-06-13 12:34   ` [Patch v5 11/13] ARM: dts: imx6q-sabrelite: add usb devices Richard Zhao
     [not found]     ` <1339590863-10564-12-git-send-email-richard.zhao-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2012-06-19 23:39       ` Fabio Estevam
2012-06-13 12:34   ` [Patch v5 12/13] ARM: mxs: clk_register_clkdev mx28 usb clocks Richard Zhao
2012-06-13 12:34   ` [Patch v5 13/13] ARM: dts: imx28-evk: add usb devices Richard Zhao
2012-06-18 17:10   ` [Patch v5 00/13] add imx usb driver for mx28/6x Fabio Estevam
     [not found]     ` <CAOMZO5BXsPtwC2CTt6Z-DjZUYhrWMKDkr2QnFoAKb-aLc1XsNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-18 17:13       ` Marek Vasut
     [not found]         ` <201206181913.06886.marex-ynQEQJNshbs@public.gmane.org>
2012-06-18 17:25           ` Fabio Estevam
     [not found]             ` <CAOMZO5DF+CH+qe+VKc4vefkj05aXOtn0nVZK9vx+0kakP_em1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-19  1:14               ` Chen Peter-B29397
     [not found]                 ` <F281D0F91ED19E4D8E63A7504E8A649803BE2DE2-RL0Hj/+nBVDtkydW1Tv2Dq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2012-06-19  1:33                   ` Fabio Estevam
     [not found]                     ` <CAOMZO5C7KaxO_X23Ur9YwHEoAvCPf4emxMzH4mmrFX6=de5GZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-19  2:07                       ` Marek Vasut
     [not found]                         ` <201206190407.31524.marex-ynQEQJNshbs@public.gmane.org>
2012-06-19  2:17                           ` Fabio Estevam
2012-06-19  6:14               ` Shawn Guo
     [not found]                 ` <20120619061414.GD21951-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-06-19 12:24                   ` Fabio Estevam
     [not found]                     ` <CAOMZO5A+eWXsz5_HGzUMJBDKnADrMeWPec7XvX+EMPJMtqWcng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-19 12:38                       ` Shawn Guo
     [not found]                         ` <20120619123813.GG21951-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2012-06-19 13:54                           ` Fabio Estevam
     [not found]                             ` <CAOMZO5CcC7G8RfG9N60OfU-Ca0EcL+qoQi00KSgxFyJ7Ry1oOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-19 18:34                               ` Fabio Estevam
2012-06-19 12:59                       ` Marek Vasut
2012-06-13 12:34 ` Richard Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339590863-10564-5-git-send-email-richard.zhao@freescale.com \
    --to=richard.zhao@freescale.com \
    --cc=B20596@freescale.com \
    --cc=B29397@freescale.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dong.aisheng@linaro.org \
    --cc=fabio.estevam@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxzsc@gmail.com \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).