* [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings
@ 2023-11-25 14:29 Jagan Teki
2023-11-25 14:29 ` [PATCH 2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b Jagan Teki
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jagan Teki @ 2023-11-25 14:29 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, Jagan Teki
Current binding has following compatible combination for SoM, IO board
- NCM6A: edgeble,neural-compute-module-6a,
edgeble,neural-compute-module-6a-io
- NCM6B: edgeble,neural-compute-module-6b,
edgeble,neural-compute-module-6b-io
This board topology now changes in final revisions, so a common
compatible IO board, NCM6A-IO, is made available for both variants
of SoM: NCM6A and NCM6B, produced by Edgeble AI.
With this change, 6b-io is not as available and 6a; 6b SoM's have the
same compatible IO board as 6a-io. This change is due to the common
optimised design of the IO board made available now in final revisions,
which was not the case in initial revisions.
Update the dt-bindings with this new change.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
.../devicetree/bindings/arm/rockchip.yaml | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 9f6155e4deed..75f23d1d42ae 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -101,16 +101,12 @@ properties:
- const: edgeble,neural-compute-module-2 # Edgeble Neural Compute Module 2 SoM
- const: rockchip,rv1126
- - description: Edgeble Neural Compute Module 6(Neu6) Model A SoM based boards
+ - description: Edgeble Neural Compute Module 6(Neu6) SoM based boards
items:
- - const: edgeble,neural-compute-module-6a-io # Edgeble Neural Compute Module 6A IO Board
- - const: edgeble,neural-compute-module-6a # Edgeble Neural Compute Module 6A SoM
- - const: rockchip,rk3588
-
- - description: Edgeble Neural Compute Module 6(Neu6) Model B SoM based boards
- items:
- - const: edgeble,neural-compute-module-6b-io # Edgeble Neural Compute Module 6B IO Board
- - const: edgeble,neural-compute-module-6b # Edgeble Neural Compute Module 6B SoM
+ - const: edgeble,neural-compute-module-6a-io # Edgeble NCM6A-IO Board
+ - enum:
+ - edgeble,neural-compute-module-6a # Edgeble Neural Compute Module 6A SoM
+ - edgeble,neural-compute-module-6b # Edgeble Neural Compute Module 6B SoM
- const: rockchip,rk3588
- description: Elgin RV1108 R1
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b
2023-11-25 14:29 [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings Jagan Teki
@ 2023-11-25 14:29 ` Jagan Teki
2023-11-25 18:10 ` Krzysztof Kozlowski
2023-11-25 18:10 ` [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings Krzysztof Kozlowski
2023-11-27 23:26 ` Heiko Stuebner
2 siblings, 1 reply; 5+ messages in thread
From: Jagan Teki @ 2023-11-25 14:29 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, Jagan Teki
Edgeble AI 6TOPS board topology is now changed in final revisions
as a compatible IO board, NCM6A-IO, is made available for both
variants of SoM: NCM6A and NCM6B.
With this change, 6b-io is not as available and 6a; 6b SoM's have
the same compatible IO board as 6a-io. This change is due to the
common optimised design of the IO board made available now in
final revisions, which was not the case in initial revisions.
So, use the NCM6A-IO compatible for NCM6B SoM based IO dts.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dts b/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dts
index 9933765e4097..861067b5d707 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-edgeble-neu6b-io.dts
@@ -9,7 +9,7 @@
/ {
model = "Edgeble Neu6B IO Board";
- compatible = "edgeble,neural-compute-module-6b-io",
+ compatible = "edgeble,neural-compute-module-6a-io",
"edgeble,neural-compute-module-6b", "rockchip,rk3588";
aliases {
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings
2023-11-25 14:29 [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings Jagan Teki
2023-11-25 14:29 ` [PATCH 2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b Jagan Teki
@ 2023-11-25 18:10 ` Krzysztof Kozlowski
2023-11-27 23:26 ` Heiko Stuebner
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-25 18:10 UTC (permalink / raw)
To: Jagan Teki, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip
On 25/11/2023 15:29, Jagan Teki wrote:
> Current binding has following compatible combination for SoM, IO board
> - NCM6A: edgeble,neural-compute-module-6a,
> edgeble,neural-compute-module-6a-io
> - NCM6B: edgeble,neural-compute-module-6b,
> edgeble,neural-compute-module-6b-io
>
> This board topology now changes in final revisions, so a common
> compatible IO board, NCM6A-IO, is made available for both variants
> of SoM: NCM6A and NCM6B, produced by Edgeble AI.
>
> With this change, 6b-io is not as available and 6a; 6b SoM's have the
> same compatible IO board as 6a-io. This change is due to the common
> optimised design of the IO board made available now in final revisions,
> which was not the case in initial revisions.
>
> Update the dt-bindings with this new change.
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b
2023-11-25 14:29 ` [PATCH 2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b Jagan Teki
@ 2023-11-25 18:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-25 18:10 UTC (permalink / raw)
To: Jagan Teki, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip
On 25/11/2023 15:29, Jagan Teki wrote:
> Edgeble AI 6TOPS board topology is now changed in final revisions
> as a compatible IO board, NCM6A-IO, is made available for both
> variants of SoM: NCM6A and NCM6B.
>
> With this change, 6b-io is not as available and 6a; 6b SoM's have
> the same compatible IO board as 6a-io. This change is due to the
> common optimised design of the IO board made available now in
> final revisions, which was not the case in initial revisions.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings
2023-11-25 14:29 [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings Jagan Teki
2023-11-25 14:29 ` [PATCH 2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b Jagan Teki
2023-11-25 18:10 ` [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings Krzysztof Kozlowski
@ 2023-11-27 23:26 ` Heiko Stuebner
2 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2023-11-27 23:26 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring, Jagan Teki
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip, devicetree
On Sat, 25 Nov 2023 19:59:13 +0530, Jagan Teki wrote:
> Current binding has following compatible combination for SoM, IO board
> - NCM6A: edgeble,neural-compute-module-6a,
> edgeble,neural-compute-module-6a-io
> - NCM6B: edgeble,neural-compute-module-6b,
> edgeble,neural-compute-module-6b-io
>
> This board topology now changes in final revisions, so a common
> compatible IO board, NCM6A-IO, is made available for both variants
> of SoM: NCM6A and NCM6B, produced by Edgeble AI.
>
> [...]
Applied, thanks!
[1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings
commit: 02dbe73da5c4f6a8dc7c381b21c181006a06fb90
[2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b
commit: ec31f0f98433f0edf456e2074301b76bdace5f3d
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-27 23:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-25 14:29 [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings Jagan Teki
2023-11-25 14:29 ` [PATCH 2/2] arm64: dts: rockchip: Use NCM6A-IO board for edgeble-neu6b Jagan Teki
2023-11-25 18:10 ` Krzysztof Kozlowski
2023-11-25 18:10 ` [PATCH 1/2] dt-bindings: arm: rockchip: Update edgeble-neu6 bindings Krzysztof Kozlowski
2023-11-27 23:26 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).