Re: [PATCH v1 03/10] media: platform: mediatek: add isp_7x seninf unit

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces the driver of the MediaTek Sensor Interface,
> focusing on integration with the MediaTek ISP CAMSYS. The
> seninf device bridges camera sensors and the ISP system,
> providing management for sensor data routing and processing.
> Key features include V4L2 framework control, and dynamic
> handling of stream configurations and virtual channels.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@mediatek.com>
> ---

[snip]

> +enum VC_FEATURE {
> +	VC_NONE = 0,
> +	VC_MIN_NUM,
> +	VC_RAW_DATA = VC_MIN_NUM,
> +	VC_RAW_DATA_MAX,
> +
> +	VC_PDAF_MIN_NUM = VC_RAW_DATA_MAX,
> +	VC_PDAF_STATS = VC_PDAF_MIN_NUM,
> +	VC_PDAF_STATS_NE,
> +	VC_PDAF_STATS_ME,
> +	VC_PDAF_STATS_SE,
> +	VC_PDAF_STATS_PIX_1,
> +	VC_PDAF_STATS_PIX_2,
> +	VC_PDAF_STATS_NE_PIX_1 = VC_PDAF_STATS_PIX_1,
> +	VC_PDAF_STATS_NE_PIX_2 = VC_PDAF_STATS_PIX_2,
> +	VC_PDAF_STATS_ME_PIX_1,
> +	VC_PDAF_STATS_ME_PIX_2,
> +	VC_PDAF_STATS_SE_PIX_1,

VC_PDAF_STATS_SE_PIX_1 is useless, so drop it.

Regards,
CK

> +	VC_PDAF_STATS_SE_PIX_2,
> +	VC_PDAF_MAX_NUM,
> +
> +	VC_HDR_MIN_NUM = VC_PDAF_MAX_NUM,
> +	VC_HDR_MVHDR = VC_HDR_MIN_NUM,
> +	VC_HDR_MAX_NUM,
> +
> +	VC_3HDR_MIN_NUM = VC_HDR_MAX_NUM,
> +	VC_3HDR_EMBEDDED = VC_3HDR_MIN_NUM,
> +	VC_3HDR_FLICKER,
> +	VC_3HDR_Y,
> +	VC_3HDR_AE,
> +	VC_3HDR_MAX_NUM,
> +
> +	VC_STAGGER_MIN_NUM = VC_3HDR_MAX_NUM,
> +	VC_STAGGER_EMBEDDED = VC_STAGGER_MIN_NUM,
> +	VC_STAGGER_NE,
> +	VC_STAGGER_ME,
> +	VC_STAGGER_SE,
> +	VC_STAGGER_MAX_NUM,
> +
> +	VC_YUV_MIN_NUM = VC_STAGGER_MAX_NUM,
> +	VC_YUV_Y = VC_YUV_MIN_NUM,
> +	VC_YUV_UV,
> +	VC_YUV_MAX_NUM,
> +
> +	VC_RAW_EXT_MIN_NUM = VC_YUV_MAX_NUM,
> +	VC_RAW_W_DATA = VC_RAW_EXT_MIN_NUM,
> +	VC_RAW_PROCESSED_DATA,
> +	VC_RAW_EXT_MAX_NUM,
> +
> +	VC_GENERAL_DATA_MIN_NUM = VC_RAW_EXT_MAX_NUM,
> +	VC_GENERAL_EMBEDDED = VC_GENERAL_DATA_MIN_NUM,
> +	VC_GENERAL_DATA_MAX_NUM,
> +
> +	VC_MAX_NUM = VC_GENERAL_DATA_MAX_NUM,
> +};
> +