Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

Arnd Bergmann
2015-10-16T13:36:38Z

On Friday 16 October 2015 14:29:55 John Garry wrote:
>
> It could be considered.
>
> A potential issue I see is with hisi_sas_control_phy() for
> PHY_FUNC_HARD_RESET: this allocates a hisi_sas_wq struct and processes
> the reset in the queue work. When we re-enable the phy for the reset,
> the phyup irq will want to use the same hisi_sas_wq struct which may be
> in use.
>
> hisi_sas_control_phy() is added in 23/35.

I'd have to review more closely, but I think that's fine, as this
is how most work queues are used: you can queue the same function
multiple times, and it's guaranteed to run at least once after
the last queue, so if you queue it while it's already running,
it will be called again, otherwise it won't.

Arnd