From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roland Stigge <stigge@antcom.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com,
linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com,
lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com,
linux@arm.linux.org.uk,
Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Subject: Re: [PATCH v10] MTD: LPC32xx MLC NAND driver
Date: Fri, 29 Jun 2012 15:37:14 +0300 [thread overview]
Message-ID: <1340973434.3070.168.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1340834129-15545-1-git-send-email-stigge@antcom.de>
[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]
On Wed, 2012-06-27 at 23:55 +0200, Roland Stigge wrote:
> This patch adds a driver for the MLC NAND controller of the LPC32xx SoC.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
> ---
Aiaiai complains like this about your patch, please, take a look:
--------------------------------------------------------------------------------
Successfully built configuration "arm-lpc32xx_defconfig,arm,arm-unknown-linux-gnueabi-", results:
--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/nand/lpc32xx_mlc.c: In function 'lpc32xx_nand_probe':
+drivers/mtd/nand/lpc32xx_mlc.c:679:10: warning: variable 'sr' set but not used [-Wunused-but-set-variable]
+drivers/mtd/nand/lpc32xx_mlc.c:561:24: error: bad constant expression [sparse]
--------------------------------------------------------------------------------
checkpatch.pl has some complaints:
--------------------------------------------------------------------------------
checkpatch.pl results for patch "[PATCH] MTD: LPC32xx MLC NAND driver"
ERROR:INITIALISED_STATIC: do not initialise statics to 0 or NULL
#339: FILE: drivers/mtd/nand/lpc32xx_mlc.c:224:
+static int use_dma = 0;
total: 1 errors, 0 warnings, 1004 lines checked
--------------------------------------------------------------------------------
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-29 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 21:55 [PATCH v10] MTD: LPC32xx MLC NAND driver Roland Stigge
2012-06-29 12:37 ` Artem Bityutskiy [this message]
2012-06-29 12:56 ` Alexandre Pereira da Silva
2012-06-29 13:04 ` Artem Bityutskiy
2012-06-29 13:13 ` Alexandre Pereira da Silva
2012-06-30 12:32 ` Roland Stigge
2012-06-30 14:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340973434.3070.168.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=aletes.xgr@gmail.com \
--cc=b32955@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=hechtb@googlemail.com \
--cc=kevin.wells@nxp.com \
--cc=lars@metafoo.de \
--cc=leiwen@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).