Re: [PATCH 3/9] ARM: versatile: add DT based PCI detection

Arnd Bergmann
2014-12-30T21:37:01Z

On Tuesday 30 December 2014 13:28:32 Rob Herring wrote:
> From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> Disable the Versatile PCI DT node when no PCI backplane is detected. This
> will prevent the Versatile PCI driver from probing when PCI is not
> populated.

Can you explain why the check is done in platform code instead of the PCI
driver probe function itself?

> + /* Check if PCI backplane is detected */
> + val = __raw_readl(base + VERSATILE_SYS_PCICTL_OFFSET);
> + if (val & 1)
> + goto err;

Using __raw_readl prevents this from working with big-endian kernels, so just
use readl here.

Arnd