* [PATCH v2 0/2] Add pinctrl support to AM33XX family of devices @ 2012-07-20 7:31 AnilKumar Ch 2012-07-20 7:31 ` [PATCH v2 1/2] arm/dts: Add AM33XX basic pinctrl support AnilKumar Ch 2012-07-20 7:31 ` [PATCH v2 2/2] arm/dts: Configure pinmuxs for user leds control on Bone AnilKumar Ch 0 siblings, 2 replies; 7+ messages in thread From: AnilKumar Ch @ 2012-07-20 7:31 UTC (permalink / raw) To: linux-omap Cc: tony, b-cousson, linux-arm-kernel, devicetree-discuss, grant.likely, AnilKumar Ch Adds pinctrl support to AM33XX family of devices. These patches were tested on AM335x-Bone and AM335x-EVM Changes from v1: - Rebased the patches based on latest pinctrl-single driver AnilKumar Ch (2): arm/dts: Add AM33XX basic pinctrl support arm/dts: Configure pinmuxs for user leds control on Bone arch/arm/boot/dts/am335x-bone.dts | 15 +++++++++++++++ arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ 2 files changed, 24 insertions(+), 0 deletions(-) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] arm/dts: Add AM33XX basic pinctrl support 2012-07-20 7:31 [PATCH v2 0/2] Add pinctrl support to AM33XX family of devices AnilKumar Ch @ 2012-07-20 7:31 ` AnilKumar Ch 2012-07-24 8:32 ` Tony Lindgren 2012-07-20 7:31 ` [PATCH v2 2/2] arm/dts: Configure pinmuxs for user leds control on Bone AnilKumar Ch 1 sibling, 1 reply; 7+ messages in thread From: AnilKumar Ch @ 2012-07-20 7:31 UTC (permalink / raw) To: linux-omap Cc: tony, b-cousson, linux-arm-kernel, devicetree-discuss, grant.likely, AnilKumar Ch Add basic pinctrl support for AM33XX family of devices by adding DT data to am33xx dtsi file. These patches are based on pinctrl-single driver and tested on am335x-evm & am335x-bone devices. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 59509c4..9b974dc 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -40,6 +40,15 @@ }; }; + am3358_pinmux: pinmux@44E10800 { + compatible = "pinctrl-single"; + reg = <0x44E10800 0x0338>; + #address-cells = <1>; + #size-cells = <0>; + pinctrl-single,register-width = <32>; + pinctrl-single,function-mask = <0x7F>; + }; + /* * XXX: Use a flat representation of the AM33XX interconnect. * The real AM33XX interconnect network is quite complex.Since -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] arm/dts: Add AM33XX basic pinctrl support 2012-07-20 7:31 ` [PATCH v2 1/2] arm/dts: Add AM33XX basic pinctrl support AnilKumar Ch @ 2012-07-24 8:32 ` Tony Lindgren 2012-07-24 9:10 ` AnilKumar, Chimata 0 siblings, 1 reply; 7+ messages in thread From: Tony Lindgren @ 2012-07-24 8:32 UTC (permalink / raw) To: AnilKumar Ch Cc: linux-omap, b-cousson, linux-arm-kernel, devicetree-discuss, grant.likely * AnilKumar Ch <anilkumar@ti.com> [120720 00:36]: > Add basic pinctrl support for AM33XX family of devices by adding DT > data to am33xx dtsi file. These patches are based on pinctrl-single > driver and tested on am335x-evm & am335x-bone devices. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 59509c4..9b974dc 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -40,6 +40,15 @@ > }; > }; > > + am3358_pinmux: pinmux@44E10800 { > + compatible = "pinctrl-single"; > + reg = <0x44E10800 0x0338>; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-single,register-width = <32>; > + pinctrl-single,function-mask = <0x7F>; > + }; > + > /* > * XXX: Use a flat representation of the AM33XX interconnect. > * The real AM33XX interconnect network is quite complex.Since Is there only one padconf domain on 33xx instead of separate core and wkup domains like omap3 and omap4 have? Regards, Tony ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2 1/2] arm/dts: Add AM33XX basic pinctrl support 2012-07-24 8:32 ` Tony Lindgren @ 2012-07-24 9:10 ` AnilKumar, Chimata 0 siblings, 0 replies; 7+ messages in thread From: AnilKumar, Chimata @ 2012-07-24 9:10 UTC (permalink / raw) To: Tony Lindgren Cc: linux-omap@vger.kernel.org, Cousson, Benoit, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca On Tue, Jul 24, 2012 at 14:02:04, Tony Lindgren wrote: > * AnilKumar Ch <anilkumar@ti.com> [120720 00:36]: > > Add basic pinctrl support for AM33XX family of devices by adding DT > > data to am33xx dtsi file. These patches are based on pinctrl-single > > driver and tested on am335x-evm & am335x-bone devices. > > > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > > --- > > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ > > 1 files changed, 9 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > index 59509c4..9b974dc 100644 > > --- a/arch/arm/boot/dts/am33xx.dtsi > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > @@ -40,6 +40,15 @@ > > }; > > }; > > > > + am3358_pinmux: pinmux@44E10800 { > > + compatible = "pinctrl-single"; > > + reg = <0x44E10800 0x0338>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + pinctrl-single,register-width = <32>; > > + pinctrl-single,function-mask = <0x7F>; > > + }; > > + > > /* > > * XXX: Use a flat representation of the AM33XX interconnect. > > * The real AM33XX interconnect network is quite complex.Since > > Is there only one padconf domain on 33xx instead of separate core > and wkup domains like omap3 and omap4 have? > Yes, in case of AM33XX we have only on padconf domain. Regards AnilKumar ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] arm/dts: Configure pinmuxs for user leds control on Bone 2012-07-20 7:31 [PATCH v2 0/2] Add pinctrl support to AM33XX family of devices AnilKumar Ch 2012-07-20 7:31 ` [PATCH v2 1/2] arm/dts: Add AM33XX basic pinctrl support AnilKumar Ch @ 2012-07-20 7:31 ` AnilKumar Ch 2012-07-24 8:30 ` Tony Lindgren 1 sibling, 1 reply; 7+ messages in thread From: AnilKumar Ch @ 2012-07-20 7:31 UTC (permalink / raw) To: linux-omap Cc: tony, b-cousson, linux-arm-kernel, devicetree-discuss, grant.likely, AnilKumar Ch Adds GPIO pinctrl nodes to am3358_pinmux master node to control user leds (USR0, USR1, USR2 and USR3) present on BeagleBone. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am335x-bone.dts | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts index a4d4415..452ce3f 100644 --- a/arch/arm/boot/dts/am335x-bone.dts +++ b/arch/arm/boot/dts/am335x-bone.dts @@ -28,3 +28,18 @@ }; /include/ "tps65217.dtsi" + +&am3358_pinmux { + + pinctrl-names = "default"; + pinctrl-0 = <&userled_pins>; + + userled_pins: pinmux_userled_pins { + pinctrl-single,pins = < + 0x54 0x7 /* gpmc_a5.gpio1_21, OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */ + 0x58 0x17 /* gpmc_a6.gpio1_22, OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */ + 0x5C 0x7 /* gpmc_a7.gpio1_23, OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */ + 0x60 0x17 /* gpmc_a8.gpio1_24, OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */ + >; + }; +}; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] arm/dts: Configure pinmuxs for user leds control on Bone 2012-07-20 7:31 ` [PATCH v2 2/2] arm/dts: Configure pinmuxs for user leds control on Bone AnilKumar Ch @ 2012-07-24 8:30 ` Tony Lindgren [not found] ` <20120724083007.GU6522-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Tony Lindgren @ 2012-07-24 8:30 UTC (permalink / raw) To: AnilKumar Ch Cc: linux-omap, b-cousson, linux-arm-kernel, devicetree-discuss, grant.likely * AnilKumar Ch <anilkumar@ti.com> [120720 00:36]: > Adds GPIO pinctrl nodes to am3358_pinmux master node to control > user leds (USR0, USR1, USR2 and USR3) present on BeagleBone. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > --- > arch/arm/boot/dts/am335x-bone.dts | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts > index a4d4415..452ce3f 100644 > --- a/arch/arm/boot/dts/am335x-bone.dts > +++ b/arch/arm/boot/dts/am335x-bone.dts > @@ -28,3 +28,18 @@ > }; > > /include/ "tps65217.dtsi" > + > +&am3358_pinmux { > + > + pinctrl-names = "default"; > + pinctrl-0 = <&userled_pins>; > + > + userled_pins: pinmux_userled_pins { > + pinctrl-single,pins = < > + 0x54 0x7 /* gpmc_a5.gpio1_21, OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */ > + 0x58 0x17 /* gpmc_a6.gpio1_22, OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */ > + 0x5C 0x7 /* gpmc_a7.gpio1_23, OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */ > + 0x60 0x17 /* gpmc_a8.gpio1_24, OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */ > + >; > + }; > +}; Let's standardize on the following minimal commenting as those can be search and replaced the same way when we have preprocessing available: pinctrl-single,pins = < 0x54 0x7 /* gpmc_a5.gpio1_21 OUTPUT | MODE7 */ 0x58 0x17 /* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */ 0x5C 0x7 /* gpmc_a7.gpio1_23, OUTPUT | MODE7 */ 0x60 0x17 /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */ >; Regards, Tony ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20120724083007.GU6522-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]
* RE: [PATCH v2 2/2] arm/dts: Configure pinmuxs for user leds control on Bone [not found] ` <20120724083007.GU6522-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> @ 2012-07-24 9:11 ` AnilKumar, Chimata 0 siblings, 0 replies; 7+ messages in thread From: AnilKumar, Chimata @ 2012-07-24 9:11 UTC (permalink / raw) To: Tony Lindgren Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Hi Tony, Thanks for the review. On Tue, Jul 24, 2012 at 14:00:08, Tony Lindgren wrote: > * AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org> [120720 00:36]: > > Adds GPIO pinctrl nodes to am3358_pinmux master node to control > > user leds (USR0, USR1, USR2 and USR3) present on BeagleBone. > > > > Signed-off-by: AnilKumar Ch <anilkumar-l0cyMroinI0@public.gmane.org> > > --- > > arch/arm/boot/dts/am335x-bone.dts | 15 +++++++++++++++ > > 1 files changed, 15 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts > > index a4d4415..452ce3f 100644 > > --- a/arch/arm/boot/dts/am335x-bone.dts > > +++ b/arch/arm/boot/dts/am335x-bone.dts > > @@ -28,3 +28,18 @@ > > }; > > > > /include/ "tps65217.dtsi" > > + > > +&am3358_pinmux { > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&userled_pins>; > > + > > + userled_pins: pinmux_userled_pins { > > + pinctrl-single,pins = < > > + 0x54 0x7 /* gpmc_a5.gpio1_21, OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */ > > + 0x58 0x17 /* gpmc_a6.gpio1_22, OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */ > > + 0x5C 0x7 /* gpmc_a7.gpio1_23, OMAP_PIN_OUTPUT | OMAP_MUX_MODE7 */ > > + 0x60 0x17 /* gpmc_a8.gpio1_24, OMAP_PIN_OUTPUT_PULLUP | OMAP_MUX_MODE7 */ > > + >; > > + }; > > +}; > > Let's standardize on the following minimal commenting as those can be > search and replaced the same way when we have preprocessing available: > > pinctrl-single,pins = < > 0x54 0x7 /* gpmc_a5.gpio1_21 OUTPUT | MODE7 */ > 0x58 0x17 /* gpmc_a6.gpio1_22, OUTPUT_PULLUP | MODE7 */ > 0x5C 0x7 /* gpmc_a7.gpio1_23, OUTPUT | MODE7 */ > 0x60 0x17 /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */ > >; > Point taken, I thought the same after v2 submission. I will send the updated version with this fix. Thanks AnilKumar ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-07-24 9:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20 7:31 [PATCH v2 0/2] Add pinctrl support to AM33XX family of devices AnilKumar Ch
2012-07-20 7:31 ` [PATCH v2 1/2] arm/dts: Add AM33XX basic pinctrl support AnilKumar Ch
2012-07-24 8:32 ` Tony Lindgren
2012-07-24 9:10 ` AnilKumar, Chimata
2012-07-20 7:31 ` [PATCH v2 2/2] arm/dts: Configure pinmuxs for user leds control on Bone AnilKumar Ch
2012-07-24 8:30 ` Tony Lindgren
[not found] ` <20120724083007.GU6522-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-07-24 9:11 ` AnilKumar, Chimata
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).