* [PATCH 1/1] ARM: dove: DT support for sdhci-dove
@ 2012-07-30 16:35 Sebastian Hesselbarth
2012-07-31 8:12 ` [PATCH v2 " Sebastian Hesselbarth
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Hesselbarth @ 2012-07-30 16:35 UTC (permalink / raw)
To: Sebastian Hesselbarth
Cc: Grant Likely, Rob Herring, Rob Landley, Chris Ball,
Anton Vorontsov, Manuel Lauss, David Brown, devicetree-discuss,
linux-doc, linux-kernel, linux-mmc
This patch adds device tree support and binding documentiation for
sdhci-dove.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Rob Landley <rob@landley.net>
Cc: Chris Ball <cjb@laptop.org>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: David Brown <davidb@codeaurora.org>
Cc: devicetree-discuss@lists.ozlabs.org
Cc: linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
---
Documentation/devicetree/bindings/mmc/sdhci-dove.txt | 12 ++++++++++++
drivers/mmc/host/sdhci-dove.c | 8 ++++++++
2 files changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-dove.txt
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-dove.txt b/Documentation/devicetree/bindings/mmc/sdhci-dove.txt
new file mode 100644
index 0000000..3dd42552
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/sdhci-dove.txt
@@ -0,0 +1,12 @@
+* Marvell sdhci-dove controller
+
+Required properties:
+- compatible: Should be "marvell,dove-sdhci".
+
+Example:
+
+sdio0: sdio@92000 {
+ compatible = "marvell,dove-sdhci";
+ reg = <0x92000 0x100>;
+ interrupts = <35>, <37>;
+};
diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
index a6e53a1..90140eb 100644
--- a/drivers/mmc/host/sdhci-dove.c
+++ b/drivers/mmc/host/sdhci-dove.c
@@ -24,6 +24,7 @@
#include <linux/err.h>
#include <linux/module.h>
#include <linux/mmc/host.h>
+#include <linux/of.h>
#include "sdhci-pltfm.h"
@@ -126,11 +127,18 @@ static int __devexit sdhci_dove_remove(struct platform_device *pdev)
return sdhci_pltfm_unregister(pdev);
}
+static const struct of_device_id sdhci_dove_of_match_table[] __devinitdata = {
+ { .compatible = "marvell,dove-sdhci", },
+ {}
+};
+MODULE_DEVICE_TABLE(of, sdhci_dove_of_match_table);
+
static struct platform_driver sdhci_dove_driver = {
.driver = {
.name = "sdhci-dove",
.owner = THIS_MODULE,
.pm = SDHCI_PLTFM_PMOPS,
+ .of_match_table = of_match_ptr(sdhci_dove_of_match_table),
},
.probe = sdhci_dove_probe,
.remove = __devexit_p(sdhci_dove_remove),
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] ARM: dove: DT support for sdhci-dove
2012-07-30 16:35 [PATCH 1/1] ARM: dove: DT support for sdhci-dove Sebastian Hesselbarth
@ 2012-07-31 8:12 ` Sebastian Hesselbarth
2012-08-08 3:53 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Hesselbarth @ 2012-07-31 8:12 UTC (permalink / raw)
To: Sebastian Hesselbarth
Cc: Grant Likely, Rob Herring, Rob Landley, Chris Ball,
Anton Vorontsov, Manuel Lauss, David Brown, Andrew Lunn,
devicetree-discuss, linux-doc, linux-kernel, linux-mmc
This patch adds device tree support and binding documentiation for
sdhci-dove.
v2: extended documentation and removed second interrupt as it is marked
'reserved' in dove datasheet.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Rob Landley <rob@landley.net>
Cc: Chris Ball <cjb@laptop.org>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: David Brown <davidb@codeaurora.org>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree-discuss@lists.ozlabs.org
Cc: linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
---
Documentation/devicetree/bindings/mmc/sdhci-dove.txt | 14 ++++++++++++++
drivers/mmc/host/sdhci-dove.c | 8 ++++++++
2 files changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-dove.txt
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-dove.txt b/Documentation/devicetree/bindings/mmc/sdhci-dove.txt
new file mode 100644
index 0000000..f08bb30
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/sdhci-dove.txt
@@ -0,0 +1,14 @@
+* Marvell sdhci-dove controller
+
+Required properties:
+- compatible: Should be "marvell,dove-sdhci".
+- reg: Physical base address of the sdhci controller.
+- interrupts: interrupt nr of the sdhci controller.
+
+Example:
+
+sdio0: sdio@92000 {
+ compatible = "marvell,dove-sdhci";
+ reg = <0x92000 0x100>;
+ interrupts = <35>;
+};
diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
index a6e53a1..90140eb 100644
--- a/drivers/mmc/host/sdhci-dove.c
+++ b/drivers/mmc/host/sdhci-dove.c
@@ -24,6 +24,7 @@
#include <linux/err.h>
#include <linux/module.h>
#include <linux/mmc/host.h>
+#include <linux/of.h>
#include "sdhci-pltfm.h"
@@ -126,11 +127,18 @@ static int __devexit sdhci_dove_remove(struct platform_device *pdev)
return sdhci_pltfm_unregister(pdev);
}
+static const struct of_device_id sdhci_dove_of_match_table[] __devinitdata = {
+ { .compatible = "marvell,dove-sdhci", },
+ {}
+};
+MODULE_DEVICE_TABLE(of, sdhci_dove_of_match_table);
+
static struct platform_driver sdhci_dove_driver = {
.driver = {
.name = "sdhci-dove",
.owner = THIS_MODULE,
.pm = SDHCI_PLTFM_PMOPS,
+ .of_match_table = of_match_ptr(sdhci_dove_of_match_table),
},
.probe = sdhci_dove_probe,
.remove = __devexit_p(sdhci_dove_remove),
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] ARM: dove: DT support for sdhci-dove
2012-07-31 8:12 ` [PATCH v2 " Sebastian Hesselbarth
@ 2012-08-08 3:53 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2012-08-08 3:53 UTC (permalink / raw)
To: Sebastian Hesselbarth
Cc: Grant Likely, Rob Herring, Rob Landley, Anton Vorontsov,
Manuel Lauss, David Brown, Andrew Lunn, devicetree-discuss,
linux-doc, linux-kernel, linux-mmc
Hi Sebastian,
On Tue, Jul 31 2012, Sebastian Hesselbarth wrote:
> This patch adds device tree support and binding documentiation for
> sdhci-dove.
>
> v2: extended documentation and removed second interrupt as it is marked
> 'reserved' in dove datasheet.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Rob Landley <rob@landley.net>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Anton Vorontsov <cbouatmailru@gmail.com>
> Cc: Manuel Lauss <manuel.lauss@googlemail.com>
> Cc: David Brown <davidb@codeaurora.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
>
> ---
Looks good, pushed to mmc-next for 3.7. In future, please use the area
just below the "---" to describe your patch changelog v1->v2; that way
it won't go into the commit message in git.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-08 3:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-30 16:35 [PATCH 1/1] ARM: dove: DT support for sdhci-dove Sebastian Hesselbarth
2012-07-31 8:12 ` [PATCH v2 " Sebastian Hesselbarth
2012-08-08 3:53 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).