From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Prisk Subject: Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for Date: Wed, 22 Aug 2012 18:34:38 +1200 Message-ID: <1345617278.7491.4.camel@gitbox> References: <1345582058-2291-1-git-send-email-linux@prisktech.co.nz> <1345582058-2291-4-git-send-email-linux@prisktech.co.nz> <20120821231255.71a7515a@pyramind.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120821231255.71a7515a-38n7/U1jhRXW96NNrWNlrekiAK3p4hvP@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Cox Cc: Alessandro Zummo , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Linus Walleij , Arnd Bergmann , Florian Tobias Schandinat , Greg Kroah-Hartman , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vt8500-wm8505-linux-kernel-/JYPxA39Uh6Zox4op4iWzw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Grant Likely , Rob Landley , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Stephen Warren , Mike Turquette , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Alan Cox List-Id: devicetree@vger.kernel.org On Tue, 2012-08-21 at 23:12 +0100, Alan Cox wrote: > On Wed, 22 Aug 2012 08:47:32 +1200 > Tony Prisk wrote: > > > Signed-off-by: Tony Prisk > > --- > > drivers/tty/serial/vt8500_serial.c | 37 ++++++++++++++++++++++++++++++++---- > > 1 file changed, 33 insertions(+), 4 deletions(-) > > Can we have a comment attached to a change this size. In particular one > describing why it gone from 4 to 6 ports, and why the port id twiddling. > > Is there a reason you can't use the device tree port id ? > > What are the regression risks for existing users expecting the pdev->id > binding ? > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Sorry Alan, The original patch was very simple, but I revisited it to fix other issues and forgot to add the relevant comments. Port size is changed to fix a problem - WM8505 actually had 6 uart's defined in platform data but the vt8500_ports variable was only 4. I have added devicetree port id support as well. No regression risks as the entire platform is being converted to devicetree and existing code dropped in this patchset. Patchv4 3/9 to follow. Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html