* [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen
@ 2012-09-07 9:06 Sachin Kamat
2012-09-07 9:06 ` [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen Sachin Kamat
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sachin Kamat @ 2012-09-07 9:06 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, sachin.kamat, kgene.kim
Commit: f447ed8b31d (gpio: samsung: add flags specifier to
device-tree binding) adds a flag to represent active low state
for gpio line. Since gpio-keys on Origen board are active low,
using this flag to represent the same.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
---
arch/arm/boot/dts/exynos4210-origen.dts | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 0c49caa..c37edf0 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -62,31 +62,31 @@
up {
label = "Up";
- gpios = <&gpx2 0 0 0 2>;
+ gpios = <&gpx2 0 0 0x10000 2>;
linux,code = <103>;
};
down {
label = "Down";
- gpios = <&gpx2 1 0 0 2>;
+ gpios = <&gpx2 1 0 0x10000 2>;
linux,code = <108>;
};
back {
label = "Back";
- gpios = <&gpx1 7 0 0 2>;
+ gpios = <&gpx1 7 0 0x10000 2>;
linux,code = <158>;
};
home {
label = "Home";
- gpios = <&gpx1 6 0 0 2>;
+ gpios = <&gpx1 6 0 0x10000 2>;
linux,code = <102>;
};
menu {
label = "Menu";
- gpios = <&gpx1 5 0 0 2>;
+ gpios = <&gpx1 5 0 0x10000 2>;
linux,code = <139>;
};
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen
2012-09-07 9:06 [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Sachin Kamat
@ 2012-09-07 9:06 ` Sachin Kamat
2012-09-08 2:31 ` Kukjin Kim
2012-09-08 2:30 ` [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Kukjin Kim
2012-09-08 2:32 ` Kukjin Kim
2 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2012-09-07 9:06 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, sachin.kamat, kgene.kim
Adds heartbeat gpio-leds support to Origen board.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4210-origen.dts | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index c37edf0..d69a799 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -91,6 +91,14 @@
};
};
+ leds {
+ compatible = "gpio-leds";
+ status {
+ gpios = <&gpx1 3 0 0x10000 2>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+
keypad@100A0000 {
status = "disabled";
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen
2012-09-07 9:06 [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Sachin Kamat
2012-09-07 9:06 ` [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen Sachin Kamat
@ 2012-09-08 2:30 ` Kukjin Kim
2012-09-08 2:32 ` Kukjin Kim
2 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2012-09-08 2:30 UTC (permalink / raw)
To: 'Sachin Kamat', linux-samsung-soc; +Cc: devicetree-discuss
Sachin Kamat wrote:
>
> Commit: f447ed8b31d (gpio: samsung: add flags specifier to
> device-tree binding) adds a flag to represent active low state
> for gpio line. Since gpio-keys on Origen board are active low,
> using this flag to represent the same.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
> ---
> arch/arm/boot/dts/exynos4210-origen.dts | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts
> index 0c49caa..c37edf0 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -62,31 +62,31 @@
>
> up {
> label = "Up";
> - gpios = <&gpx2 0 0 0 2>;
> + gpios = <&gpx2 0 0 0x10000 2>;
> linux,code = <103>;
> };
>
> down {
> label = "Down";
> - gpios = <&gpx2 1 0 0 2>;
> + gpios = <&gpx2 1 0 0x10000 2>;
> linux,code = <108>;
> };
>
> back {
> label = "Back";
> - gpios = <&gpx1 7 0 0 2>;
> + gpios = <&gpx1 7 0 0x10000 2>;
> linux,code = <158>;
> };
>
> home {
> label = "Home";
> - gpios = <&gpx1 6 0 0 2>;
> + gpios = <&gpx1 6 0 0x10000 2>;
> linux,code = <102>;
> };
>
> menu {
> label = "Menu";
> - gpios = <&gpx1 5 0 0 2>;
> + gpios = <&gpx1 5 0 0x10000 2>;
> linux,code = <139>;
> };
> };
> --
> 1.7.4.1
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen
2012-09-07 9:06 ` [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen Sachin Kamat
@ 2012-09-08 2:31 ` Kukjin Kim
0 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2012-09-08 2:31 UTC (permalink / raw)
To: 'Sachin Kamat', linux-samsung-soc; +Cc: devicetree-discuss
Sachin Kamat wrote:
>
> Adds heartbeat gpio-leds support to Origen board.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/boot/dts/exynos4210-origen.dts | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> b/arch/arm/boot/dts/exynos4210-origen.dts
> index c37edf0..d69a799 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -91,6 +91,14 @@
> };
> };
>
> + leds {
> + compatible = "gpio-leds";
> + status {
> + gpios = <&gpx1 3 0 0x10000 2>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> keypad@100A0000 {
> status = "disabled";
> };
> --
> 1.7.4.1
Applied, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen
2012-09-07 9:06 [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Sachin Kamat
2012-09-07 9:06 ` [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen Sachin Kamat
2012-09-08 2:30 ` [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Kukjin Kim
@ 2012-09-08 2:32 ` Kukjin Kim
2 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2012-09-08 2:32 UTC (permalink / raw)
To: 'Kukjin Kim', 'Sachin Kamat', linux-samsung-soc
Cc: devicetree-discuss
Kukjin Kim wrote:
>
> Sachin Kamat wrote:
> >
> > Commit: f447ed8b31d (gpio: samsung: add flags specifier to
> > device-tree binding) adds a flag to represent active low state
> > for gpio line. Since gpio-keys on Origen board are active low,
> > using this flag to represent the same.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Reviewed-by: Thomas Abraham <thomas.abraham@linaro.org>
> > ---
> > arch/arm/boot/dts/exynos4210-origen.dts | 10 +++++-----
> > 1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts
> > b/arch/arm/boot/dts/exynos4210-origen.dts
> > index 0c49caa..c37edf0 100644
> > --- a/arch/arm/boot/dts/exynos4210-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> > @@ -62,31 +62,31 @@
> >
> > up {
> > label = "Up";
> > - gpios = <&gpx2 0 0 0 2>;
> > + gpios = <&gpx2 0 0 0x10000 2>;
> > linux,code = <103>;
> > };
> >
> > down {
> > label = "Down";
> > - gpios = <&gpx2 1 0 0 2>;
> > + gpios = <&gpx2 1 0 0x10000 2>;
> > linux,code = <108>;
> > };
> >
> > back {
> > label = "Back";
> > - gpios = <&gpx1 7 0 0 2>;
> > + gpios = <&gpx1 7 0 0x10000 2>;
> > linux,code = <158>;
> > };
> >
> > home {
> > label = "Home";
> > - gpios = <&gpx1 6 0 0 2>;
> > + gpios = <&gpx1 6 0 0x10000 2>;
> > linux,code = <102>;
> > };
> >
> > menu {
> > label = "Menu";
> > - gpios = <&gpx1 5 0 0 2>;
> > + gpios = <&gpx1 5 0 0x10000 2>;
> > linux,code = <139>;
> > };
> > };
> > --
> > 1.7.4.1
>
> Applied, thanks.
>
Note, since this is not a bug fix, queued this for v3.7.
If any problem, let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-08 2:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-07 9:06 [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Sachin Kamat
2012-09-07 9:06 ` [PATCH Resend 2/2] ARM: dts: Add heartbeat gpio-leds support to Origen Sachin Kamat
2012-09-08 2:31 ` Kukjin Kim
2012-09-08 2:30 ` [PATCH Resend 1/2] ARM: dts: Use active low flag for gpio-keys on Origen Kukjin Kim
2012-09-08 2:32 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).