devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4] Add MFC device tree support
@ 2012-09-22 18:07 Arun Kumar K
  2012-09-22 18:07 ` [PATCH v4] ARM: EXYNOS: " Arun Kumar K
  0 siblings, 1 reply; 7+ messages in thread
From: Arun Kumar K @ 2012-09-22 18:07 UTC (permalink / raw)
  To: linux-samsung-soc, devicetree-discuss
  Cc: kgene.kim, k.debski, jtp.park, thomas.abraham, k.lewandowsk,
	s.nawrocki, ch.naveen, arun.kk, joshi

This patch adds the device tree entries for MFC on Exynos5.
This is rebased to the linux-samsung for-next branch.

Changelog v4
- Addressed review comments from Karol Lewandowski
http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/12703

Changelog v3
- Addressed review comments given by Sylwester Nawrocki
http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg12340.html

Changelog v2
- Use fdt functions to parse dtsi file for mfc memory info

Changelog v1
- Moved board specific DT information to different dtsi file
- Changed compatible name for the device
- Addressed other review comments

Arun Kumar K (1):
  ARM: EXYNOS: Add MFC device tree support

 .../devicetree/bindings/media/s5p-mfc.txt          |   27 ++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |    7 ++++
 arch/arm/boot/dts/exynos5250.dtsi                  |    6 +++
 arch/arm/mach-exynos/Kconfig                       |    1 +
 arch/arm/mach-exynos/clock-exynos5.c               |    2 +-
 arch/arm/mach-exynos/common.c                      |   37 ++++++++++++++++++++
 arch/arm/mach-exynos/common.h                      |   10 +++++
 arch/arm/mach-exynos/mach-exynos5-dt.c             |   16 ++++++++
 8 files changed, 105 insertions(+), 1 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/s5p-mfc.txt

^ permalink raw reply	[flat|nested] 7+ messages in thread
* RE: [PATCH v4] ARM: EXYNOS: Add MFC device tree support
@ 2012-09-26 11:00 Arun Kumar K
  0 siblings, 0 replies; 7+ messages in thread
From: Arun Kumar K @ 2012-09-26 11:00 UTC (permalink / raw)
  To: Kukjin Kim, Karol Lewandowski
  Cc: linux-samsung-soc@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, Kamil Debski, Jeongtae Park,
	thomas.abraham@linaro.org, Sylwester Nawrocki,
	NAVEEN KRISHNA CHATRADHI, SUNIL JOSHI, Thomas P Abraham

Hi Kukjin,

As suggested by you, the function exynos_fdt_find_mfc_mem() can be moved to plat-samsung.
I feel plat-samsung/s5p-dev-mfc.c would be a good place. Hope it is ok?
Also I will wrap it with #ifdef CONFIG_OF for non-dt mode.
I will post the updated patch with the suggested changes.

Regards
Arun

On Wed, Sep 26, 2012 at 7:42 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Karol Lewandowski wrote:
>>
>> On 09/22/2012 08:07 PM, Arun Kumar K wrote:
>>
>> > This patch adds device tree entry for MFC v6 in the Exynos5
>> > SoC. Makes the required changes in the clock files and adds
>> > MFC to the DT device list.
>> >
>> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> > Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>>
>>
>> Looks good for me. FWIW, I could probably add
>>
>> Acked-by: Karol Lewandowski <k.lewandowsk@samsung.com>
>>
> Happens following build error with exynos4_defconfig because of non-DT ?
>
> arch/arm/mach-exynos/common.c: In function 'exynos_fdt_find_mfc_mem':
> arch/arm/mach-exynos/common.c:1058: error: implicit declaration of function 'of_flat_dt_is_compatible'
> arch/arm/mach-exynos/common.c:1061: error: implicit declaration of function 'of_get_flat_dt_prop'
> arch/arm/mach-exynos/common.c:1061: warning: assignment makes pointer from integer without a cast
> arch/arm/mach-exynos/common.c:1064: error: implicit declaration of function 'of_read_ulong'
> arch/arm/mach-exynos/common.c:1066: warning: assignment makes pointer from integer without a cast
> arch/arm/mach-exynos/common.c:1071: warning: assignment makes pointer from integer without a cast
> arch/arm/mach-exynos/common.c:1076: warning: assignment makes pointer from integer without a cast
> make[1]: *** [arch/arm/mach-exynos/common.o] Error 1
>
> And I think, firstly we could move the function exynos_fdt_find_mfc_mem() into plat-samsung/ for using on other Samsung stuff such as s5pv210 and need to enclose '#ifdef CONFIG_OF" for non-DT?
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v4] ARM: EXYNOS: Add MFC device tree support
@ 2012-09-26 12:57 Arun Kumar K
  0 siblings, 0 replies; 7+ messages in thread
From: Arun Kumar K @ 2012-09-26 12:57 UTC (permalink / raw)
  To: Tomasz Figa
  Cc: linux-samsung-soc@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, Kukjin Kim, Kamil Debski,
	Jeongtae Park, thomas.abraham@linaro.org, Karol Lewandowski,
	Sylwester Nawrocki, NAVEEN KRISHNA CHATRADHI, SUNIL JOSHI

Hi Tomasz,

> Maybe the base address and size could be merged into one property with two
> values, as it is done with the reg property? What do you think?
>
>> +     codec@11000000 {
>> +             samsung,mfc-r = <0x43000000>;
>> +             samsung,mfc-r-size = <8388608>;
>> +             samsung,mfc-l = <0x51000000>;
>> +             samsung,mfc-l-size = <8388608>;
>
> It would look like this:
>
>                 samsung-mfc-r = <0x43000000 0x800000>;
>                 samsung-mfc-l = <0x51000000 0x800000>;
>

Thanks for the suggestion. It sure looks better this way.
I will include this change and post updated patch.

Regards
Arun

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-09-26 12:57 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-22 18:07 [PATCH v4] Add MFC device tree support Arun Kumar K
2012-09-22 18:07 ` [PATCH v4] ARM: EXYNOS: " Arun Kumar K
2012-09-24  8:22   ` Karol Lewandowski
2012-09-26  2:12     ` Kukjin Kim
2012-09-26  6:54   ` Tomasz Figa
  -- strict thread matches above, loose matches on Subject: below --
2012-09-26 11:00 Arun Kumar K
2012-09-26 12:57 Arun Kumar K

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).