From: "Philip, Avinash" <avinashphilip@ti.com>
To: grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, rpurdie@rpsys.net,
thierry.reding@avionic-design.de
Cc: broonie@opensource.wolfsonmicro.com, shawn.guo@linaro.org,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, nsekhar@ti.com,
gururaja.hebbar@ti.com, "Philip, Avinash" <avinashphilip@ti.com>
Subject: [PATCH v3] pwm_backlight: Add device tree support for Low Threshold Brightness
Date: Wed, 26 Sep 2012 20:17:07 +0530 [thread overview]
Message-ID: <1348670827-5720-1-git-send-email-avinashphilip@ti.com> (raw)
Some back lights perform poorly when driven by a PWM with a short
duty-cycle. For such devices, the low threshold can be used to specify a
lower bound for the duty-cycle and should be chosen to exclude the
problematic range.
Add device tree probing support for lth_brightness putting
low-threshold-brightness as optional property.
Signed-off-by: Philip, Avinash <avinashphilip@ti.com>
---
Changes since v2:
- Added documentation part for configuring low-threshold-brightness
Changes since v1:
- Updated commit message.
- Changes to low-threshold-brightness.
- Merged example section to original.
:100644 100644 1e4fc72... 4e29912... M Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
:100644 100644 995f016... 29e6fe1... M drivers/video/backlight/pwm_bl.c
.../bindings/video/backlight/pwm-backlight.txt | 10 ++++++++++
drivers/video/backlight/pwm_bl.c | 5 +++++
2 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
index 1e4fc72..4e29912 100644
--- a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
+++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
@@ -14,6 +14,15 @@ Required properties:
Optional properties:
- pwm-names: a list of names for the PWM devices specified in the
"pwms" property (see PWM binding[0])
+ - low-threshold-brightness: brightness threshold low level. Low threshold
+ brightness set to value so that backlight present on low end of
+ brightness.
+ Some panels, backlight would absent if duty percentage of PWM wave is less
+ than certain level (say 20%). By setting low-threshold-brightness to a
+ value above (percentage of brightness-levels max) 50 (20% of 255, if 255
+ is max). On setting low-threshold-brightness, range of brightness-levels
+ is calculated in a region of low-threshold-brightness to brightness-levels
+ max.
[0]: Documentation/devicetree/bindings/pwm/pwm.txt
@@ -25,4 +34,5 @@ Example:
brightness-levels = <0 4 8 16 32 64 128 255>;
default-brightness-level = <6>;
+ low-threshold-brightness = <50>;
};
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 995f016..29e6fe1 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -143,6 +143,11 @@ static int pwm_backlight_parse_dt(struct device *dev,
data->dft_brightness = value;
data->max_brightness--;
+
+ ret = of_property_read_u32(node, "low-threshold-brightness",
+ &value);
+ if (!ret)
+ data->lth_brightness = value;
}
/*
--
1.7.0.4
next reply other threads:[~2012-09-26 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 14:47 Philip, Avinash [this message]
2012-09-27 21:33 ` [PATCH v3] pwm_backlight: Add device tree support for Low Threshold Brightness Andrew Morton
2012-09-28 5:45 ` Thierry Reding
2012-10-11 8:32 ` Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348670827-5720-1-git-send-email-avinashphilip@ti.com \
--to=avinashphilip@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gururaja.hebbar@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rpurdie@rpsys.net \
--cc=shawn.guo@linaro.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).