devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: grant.likely@secretlab.ca, rob.herring@calxeda.com,
	rob@landley.net, kishon@ti.com, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
	balbi@ti.com
Subject: [PATCH 3/6] usb: dwc3-omap: Remove explicit writes to SYSCONFIG register
Date: Fri, 28 Sep 2012 18:23:12 +0530	[thread overview]
Message-ID: <1348836795-4783-4-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1348836795-4783-1-git-send-email-kishon@ti.com>

The runtime API's takes care of setting the SYSCONFIG register with
appropriate values. Hence explicit writes to SYSCONFIG register is
removed.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/usb/dwc3/dwc3-omap.c |   26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 6a0e17f..a1704c6 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -77,23 +77,6 @@
 
 /* SYSCONFIG REGISTER */
 #define USBOTGSS_SYSCONFIG_DMADISABLE		(1 << 16)
-#define USBOTGSS_SYSCONFIG_STANDBYMODE(x)	((x) << 4)
-
-#define USBOTGSS_STANDBYMODE_FORCE_STANDBY	0
-#define USBOTGSS_STANDBYMODE_NO_STANDBY		1
-#define USBOTGSS_STANDBYMODE_SMART_STANDBY	2
-#define USBOTGSS_STANDBYMODE_SMART_WAKEUP	3
-
-#define USBOTGSS_STANDBYMODE_MASK		(0x03 << 4)
-
-#define USBOTGSS_SYSCONFIG_IDLEMODE(x)		((x) << 2)
-
-#define USBOTGSS_IDLEMODE_FORCE_IDLE		0
-#define USBOTGSS_IDLEMODE_NO_IDLE		1
-#define USBOTGSS_IDLEMODE_SMART_IDLE		2
-#define USBOTGSS_IDLEMODE_SMART_WAKEUP		3
-
-#define USBOTGSS_IDLEMODE_MASK			(0x03 << 2)
 
 /* IRQ_EOI REGISTER */
 #define USBOTGSS_IRQ_EOI_LINE_NUMBER		(1 << 0)
@@ -318,15 +301,6 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
 	reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
 	omap->dma_status = !!(reg & USBOTGSS_SYSCONFIG_DMADISABLE);
 
-	/* Set No-Idle and No-Standby */
-	reg &= ~(USBOTGSS_STANDBYMODE_MASK
-			| USBOTGSS_IDLEMODE_MASK);
-
-	reg |= (USBOTGSS_SYSCONFIG_STANDBYMODE(USBOTGSS_STANDBYMODE_NO_STANDBY)
-		| USBOTGSS_SYSCONFIG_IDLEMODE(USBOTGSS_IDLEMODE_NO_IDLE));
-
-	dwc3_omap_writel(omap->base, USBOTGSS_SYSCONFIG, reg);
-
 	ret = devm_request_irq(dev, omap->irq, dwc3_omap_interrupt, 0,
 			"dwc3-omap", omap);
 	if (ret) {
-- 
1.7.10.4


  reply	other threads:[~2012-09-28 12:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-28 12:53 [PATCH 0/6] usb: dwc3-omap: add dt support Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I [this message]
2012-09-28 12:53 ` [PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working Kishon Vijay Abraham I
     [not found] ` <1348836795-4783-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2012-09-28 12:53   ` [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev Kishon Vijay Abraham I
     [not found]     ` <1348836795-4783-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2012-09-28 12:57       ` Felipe Balbi
2012-09-28 13:31         ` ABRAHAM, KISHON VIJAY
2012-10-01  8:50           ` Felipe Balbi
2012-09-28 12:53   ` [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks Kishon Vijay Abraham I
     [not found]     ` <1348836795-4783-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2012-09-28 12:58       ` Felipe Balbi
     [not found]         ` <20120928125840.GL31006-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-09-28 13:31           ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53   ` [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox Kishon Vijay Abraham I
2012-09-28 12:59     ` Felipe Balbi
     [not found]       ` <20120928125929.GM31006-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-09-28 13:31         ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53   ` [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core Kishon Vijay Abraham I
2012-09-28 13:02     ` Felipe Balbi
2012-09-28 13:32       ` ABRAHAM, KISHON VIJAY
2012-09-30 16:47     ` Sergei Shtylyov
     [not found]       ` <5068779A.20402-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-10-01  5:10         ` ABRAHAM, KISHON VIJAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348836795-4783-4-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).