From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F7D3C28B2B for ; Tue, 16 Aug 2022 12:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233050AbiHPM5k (ORCPT ); Tue, 16 Aug 2022 08:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233461AbiHPM5M (ORCPT ); Tue, 16 Aug 2022 08:57:12 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA53189CFF for ; Tue, 16 Aug 2022 05:57:06 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id u1so14808548lfq.4 for ; Tue, 16 Aug 2022 05:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=u6vsO210HbSOzl+ApBtKdfKeKIVufqnfwmwO0kmWyvI=; b=ryshPL7gSJngeT8mVWdgphUp3NPNc5/8T07ioXmLOYFE+RM9kMFox6j/QSmMx+MRjW IF5Tvsu+eUNa/PURaluKXcxsPoKwTU0v6obcpVNF6S4E2WUJQwfcMoAedizNNTEJVzIN qApkaeQsH9W4FBpYE2y4cHYlnaFnoj9yBLWWtHAiDyYD2WSMopnYkuWFR3AZvGXe9orE W7mL52SexG3h2NyytiRZEwQPnlFxYDDwyJbFKcIuCS7pw5DDoUXAJcdrv+Qc4tTN48CC ofihlq8KHD75r9tNZ+KV2KtQWXkZp55mGCW7DPJAuyRkCANnLDWg9JgV8nXF25DqpsEo /E1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=u6vsO210HbSOzl+ApBtKdfKeKIVufqnfwmwO0kmWyvI=; b=pyaXXvJGwNMIrWeDwfL3mwHBiQDSZl3fMiaNUD5jnMFo1GmZEp+LNtTXayo1ExlIm8 zxAr0tSb8o9IEdKIglHolIzxPktcX1c7bCc4qCYw49E4i1A8YqMM/51lEKKa2k6QjX87 z/tnfjMDm3tOpSvg5mO3CJdinOSYCLPeqqvVy+ZY6TTFEoEAb3l/N3/r357JeLWKhh1M h/6GfxxhYqFrRljtxHDOCn7To9DBLFfTByJr8GA7JMUfamBd+6hP4/7Ux2vfB2JPaJkr +VRwIle3EkN4aTyJwIcccM1/Wxb3IbJUWX/SornPIFRMve1ZybkU6flm1MlVF9YJydrm ZoPw== X-Gm-Message-State: ACgBeo27moxF9/fvkftaX5dxjNU7Zaj/mAr7a+M8hNcPnNp+9BEmb1ed iR1zE29ZmkzLYGFPo5z9fzphkA== X-Google-Smtp-Source: AA6agR60sMxOHtIXk2hcNdYq73fYG6QiAiIF8W4tR5L6Ra08qXNqi9BEiQFyK2ct4uvflrrmAZRnVQ== X-Received: by 2002:a05:6512:b03:b0:492:88d3:8369 with SMTP id w3-20020a0565120b0300b0049288d38369mr3820559lfu.552.1660654625046; Tue, 16 Aug 2022 05:57:05 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id b26-20020ac2411a000000b0048af9d2d119sm1379707lfi.130.2022.08.16.05.57.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 05:57:04 -0700 (PDT) Message-ID: <1349b271-796b-c9d2-a568-f9be84926ed4@linaro.org> Date: Tue, 16 Aug 2022 15:57:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366 Content-Language: en-US To: "zhiyong.tao" Cc: lee.jones@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, eddie.huang@mediatek.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, fshao@chromium.org, sen.chu@mediatek.com, hui.liu@mediatek.com, allen-kh.cheng@mediatek.com, hsin-hsiung.wang@mediatek.com, sean.wang@mediatek.com, macpaul.lin@mediatek.com, wen.su@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220812092901.6429-1-zhiyong.tao@mediatek.com> <20220812092901.6429-2-zhiyong.tao@mediatek.com> <4a49b619deb5453749a47874377cad6a36a9a054.camel@mediatek.com> <9bc148119fc36c34f404091ca0f5a2e37727c285.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <9bc148119fc36c34f404091ca0f5a2e37727c285.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/08/2022 15:54, zhiyong.tao wrote: > On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote: >> On Fri, 12 Aug 2022 at 15:52, zhiyong.tao >> wrote: >>> >>> On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote: >>>> On 12/08/2022 12:29, Zhiyong Tao wrote: >>>>> Add mt6366 regulator document >>>>> >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + const: mediatek,mt6366-regulator >>>>> + >>>>> + regulators: >>>>> + type: object >>>>> + description: List of regulators and its properties >>>>> + >>>>> + patternProperties: >>>>> + "^buck- >>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>>> + unevaluatedProperties: false >>>>> + >>>>> + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$": >>>>> + type: object >>>>> + $ref: regulator.yaml# >>>> >>>> You miss unevaluatedProperties in most of the places. >>> >>> Hi Krzysztof, >>> Thanks for your suggestion, >>> Do you mean that all places should have the >>> unevaluatedProperties >>> Properties ? >> >> Yes. You put it in some of the places which does not really make >> sense... > > Hi Krzysztof, > Thanks for your suggestion, > We find that if there is a properties "compatible = "regulator- > fixed";" in ldo-vrf12, we should set unevaluatedProperties as true. > or it will check yaml warning "Unevaluated Properties are not > allowed('compatible' was unexpected)". is it right? > There is a properties "compatible = "regulator-fixed";"in ldo-vrf12. > It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a > required property". Can you help to give a suggestion to fix the > warning? Add regulator-name for ldo-vrf12 or other suggestion? > And how this regulator is supposed to work? Are you populating DT children in your driver? Best regards, Krzysztof