* [PATCH] dtc: srcpos_verror() should print to stderr
@ 2012-10-16 6:58 Michael Ellerman
[not found] ` <1350370736-22789-1-git-send-email-michael-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Ellerman @ 2012-10-16 6:58 UTC (permalink / raw)
To: jdl-CYoMK+44s/E; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
Errors should go to stderr.
Signed-off-by: Michael Ellerman <michael-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
---
srcpos.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpos.c b/srcpos.c
index 246ab4b..c20bc53 100644
--- a/srcpos.c
+++ b/srcpos.c
@@ -297,9 +297,9 @@ srcpos_verror(struct srcpos *pos, char const *fmt, va_list va)
srcstr = srcpos_string(pos);
- fprintf(stdout, "Error: %s ", srcstr);
- vfprintf(stdout, fmt, va);
- fprintf(stdout, "\n");
+ fprintf(stderr, "Error: %s ", srcstr);
+ vfprintf(stderr, fmt, va);
+ fprintf(stderr, "\n");
}
void
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dtc: srcpos_verror() should print to stderr
[not found] ` <1350370736-22789-1-git-send-email-michael-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
@ 2012-10-16 8:46 ` David Gibson
2012-10-16 14:36 ` Jon Loeliger
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2012-10-16 8:46 UTC (permalink / raw)
To: Michael Ellerman; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
On Tue, Oct 16, 2012 at 05:58:56PM +1100, Michael Ellerman wrote:
> Errors should go to stderr.
Oops, yes.
> Signed-off-by: Michael Ellerman <michael-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
Acked-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dtc: srcpos_verror() should print to stderr
[not found] ` <1350370736-22789-1-git-send-email-michael-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2012-10-16 8:46 ` David Gibson
@ 2012-10-16 14:36 ` Jon Loeliger
1 sibling, 0 replies; 3+ messages in thread
From: Jon Loeliger @ 2012-10-16 14:36 UTC (permalink / raw)
To: Michael Ellerman; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
> Errors should go to stderr.
>
> Signed-off-by: Michael Ellerman <michael-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
Applied.
Thanks,
jdl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-16 14:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-16 6:58 [PATCH] dtc: srcpos_verror() should print to stderr Michael Ellerman
[not found] ` <1350370736-22789-1-git-send-email-michael-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2012-10-16 8:46 ` David Gibson
2012-10-16 14:36 ` Jon Loeliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).