* [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio
@ 2012-10-18 9:25 Peter Ujfalusi
2012-10-18 10:00 ` Benoit Cousson
0 siblings, 1 reply; 4+ messages in thread
From: Peter Ujfalusi @ 2012-10-18 9:25 UTC (permalink / raw)
To: Tony Lindgren, Benoit Cousson
Cc: linux-omap, linux-arm-kernel, devicetree-discuss
Fixes the following errors:
[ 2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
[ 2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
Which is because we failed to link the sidetone hwmod for McBSP2/3. The
missing sidetone hwmod link will prevent omap_device_alloc() to append the
DMA resources since we - accidentally - end up having the same number of
resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports
without the ST resources.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi Tony, Benoit,
Can you please take this patch for 3.7 since if we boot with DT audio will not
work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.
Thank you,
Peter
arch/arm/boot/dts/omap3.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index f38ea87..696e929 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -257,7 +257,7 @@
interrupt-names = "common", "tx", "rx", "sidetone";
interrupt-parent = <&intc>;
ti,buffer-size = <1280>;
- ti,hwmods = "mcbsp2";
+ ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
};
mcbsp3: mcbsp@49024000 {
@@ -272,7 +272,7 @@
interrupt-names = "common", "tx", "rx", "sidetone";
interrupt-parent = <&intc>;
ti,buffer-size = <128>;
- ti,hwmods = "mcbsp3";
+ ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
};
mcbsp4: mcbsp@49026000 {
--
1.7.12.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio
2012-10-18 9:25 [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio Peter Ujfalusi
@ 2012-10-18 10:00 ` Benoit Cousson
2012-10-22 11:41 ` Péter Ujfalusi
0 siblings, 1 reply; 4+ messages in thread
From: Benoit Cousson @ 2012-10-18 10:00 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: Tony Lindgren, linux-omap, linux-arm-kernel, devicetree-discuss
On 10/18/2012 11:25 AM, Peter Ujfalusi wrote:
> Fixes the following errors:
> [ 2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
> [ 2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
>
> Which is because we failed to link the sidetone hwmod for McBSP2/3. The
> missing sidetone hwmod link will prevent omap_device_alloc() to append the
> DMA resources since we - accidentally - end up having the same number of
> resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports
> without the ST resources.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Benoit Cousson <b-cousson@ti.com>
Regards,
Benoit
> ---
>
> Hi Tony, Benoit,
>
> Can you please take this patch for 3.7 since if we boot with DT audio will not
> work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.
>
> Thank you,
> Peter
>
> arch/arm/boot/dts/omap3.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index f38ea87..696e929 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -257,7 +257,7 @@
> interrupt-names = "common", "tx", "rx", "sidetone";
> interrupt-parent = <&intc>;
> ti,buffer-size = <1280>;
> - ti,hwmods = "mcbsp2";
> + ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
> };
>
> mcbsp3: mcbsp@49024000 {
> @@ -272,7 +272,7 @@
> interrupt-names = "common", "tx", "rx", "sidetone";
> interrupt-parent = <&intc>;
> ti,buffer-size = <128>;
> - ti,hwmods = "mcbsp3";
> + ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
> };
>
> mcbsp4: mcbsp@49026000 {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio
2012-10-18 10:00 ` Benoit Cousson
@ 2012-10-22 11:41 ` Péter Ujfalusi
2012-10-22 20:38 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Péter Ujfalusi @ 2012-10-22 11:41 UTC (permalink / raw)
To: Benoit Cousson
Cc: Tony Lindgren, linux-omap, linux-arm-kernel, devicetree-discuss
Hi Tony,
On 10/18/2012 12:00 PM, Benoit Cousson wrote:
> On 10/18/2012 11:25 AM, Peter Ujfalusi wrote:
>> Fixes the following errors:
>> [ 2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
>> [ 2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
>>
>> Which is because we failed to link the sidetone hwmod for McBSP2/3. The
>> missing sidetone hwmod link will prevent omap_device_alloc() to append the
>> DMA resources since we - accidentally - end up having the same number of
>> resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports
>> without the ST resources.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Acked-by: Benoit Cousson <b-cousson@ti.com>
Can you take this patch for -rc3?
Thanks,
Péter
>
> Regards,
> Benoit
>
>> ---
>>
>> Hi Tony, Benoit,
>>
>> Can you please take this patch for 3.7 since if we boot with DT audio will not
>> work on BeagleBoard and on boards which uses McBSP2 or 3 for audio.
>>
>> Thank you,
>> Peter
>>
>> arch/arm/boot/dts/omap3.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
>> index f38ea87..696e929 100644
>> --- a/arch/arm/boot/dts/omap3.dtsi
>> +++ b/arch/arm/boot/dts/omap3.dtsi
>> @@ -257,7 +257,7 @@
>> interrupt-names = "common", "tx", "rx", "sidetone";
>> interrupt-parent = <&intc>;
>> ti,buffer-size = <1280>;
>> - ti,hwmods = "mcbsp2";
>> + ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
>> };
>>
>> mcbsp3: mcbsp@49024000 {
>> @@ -272,7 +272,7 @@
>> interrupt-names = "common", "tx", "rx", "sidetone";
>> interrupt-parent = <&intc>;
>> ti,buffer-size = <128>;
>> - ti,hwmods = "mcbsp3";
>> + ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
>> };
>>
>> mcbsp4: mcbsp@49026000 {
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio
2012-10-22 11:41 ` Péter Ujfalusi
@ 2012-10-22 20:38 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-10-22 20:38 UTC (permalink / raw)
To: Péter Ujfalusi
Cc: Benoit Cousson, linux-omap, linux-arm-kernel, devicetree-discuss
* Péter Ujfalusi <peter.ujfalusi@ti.com> [121022 04:42]:
> Hi Tony,
>
> On 10/18/2012 12:00 PM, Benoit Cousson wrote:
> > On 10/18/2012 11:25 AM, Peter Ujfalusi wrote:
> >> Fixes the following errors:
> >> [ 2.318084] omap-mcbsp 49022000.mcbsp: invalid rx DMA channel
> >> [ 2.324432] omap-mcbsp 49024000.mcbsp: invalid rx DMA channel
> >>
> >> Which is because we failed to link the sidetone hwmod for McBSP2/3. The
> >> missing sidetone hwmod link will prevent omap_device_alloc() to append the
> >> DMA resources since we - accidentally - end up having the same number of
> >> resources provided from DT (IO/IRQ) as we have in hwmod for the McBSP ports
> >> without the ST resources.
> >>
> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> >
> > Acked-by: Benoit Cousson <b-cousson@ti.com>
>
> Can you take this patch for -rc3?
Thanks will apply into omap-for-v3.7-rc2/fixes.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-22 20:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-18 9:25 [PATCH] ARM/dts: omap3: Fix mcbsp2/3 hwmods to be able to probe the drivers for audio Peter Ujfalusi
2012-10-18 10:00 ` Benoit Cousson
2012-10-22 11:41 ` Péter Ujfalusi
2012-10-22 20:38 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).