devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Philip, Avinash" <avinashphilip@ti.com>
To: thierry.reding@avionic-design.de, grant.likely@secretlab.ca,
	rob.herring@calxeda.com, rob@landley.net
Cc: linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	nsekhar@ti.com, gururaja.hebbar@ti.com, "Philip,
	Avinash" <avinashphilip@ti.com>
Subject: [PATCH] pwm: Device tree support for PWM polarity.
Date: Mon, 29 Oct 2012 23:10:27 +0530	[thread overview]
Message-ID: <1351532427-19881-1-git-send-email-avinashphilip@ti.com> (raw)

From: "Philip, Avinash" <avinashphilip@ti.com>

Adds support for 3rd cell in pwm-specifier. PWM polarity is encoded in
device tree support in bit encoded form. Platforms require polarity of
PWM device initialized during PWM device initialization has to encode
polarity in 3rd cell of pwm-specifier.

Signed-off-by: Philip, Avinash <avinashphilip@ti.com>
---
:100644 100644 73ec962... e522c59... M	Documentation/devicetree/bindings/pwm/pwm.txt
:100644 100644 f5acdaa... 1c6d50b... M	drivers/pwm/core.c
:100644 100644 112b314... d77c5b3... M	include/linux/pwm.h
 Documentation/devicetree/bindings/pwm/pwm.txt |   22 +++++++++++++++++++---
 drivers/pwm/core.c                            |   13 ++++++++++++-
 include/linux/pwm.h                           |    7 +++++++
 3 files changed, 38 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm.txt b/Documentation/devicetree/bindings/pwm/pwm.txt
index 73ec962..e522c59 100644
--- a/Documentation/devicetree/bindings/pwm/pwm.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm.txt
@@ -37,10 +37,26 @@ device:
 		pwm-names = "backlight";
 	};
 
+Note that in the example above, specifying the "pwm-names" is redundant
+because the name "backlight" would be used as fallback anyway.
+
 pwm-specifier typically encodes the chip-relative PWM number and the PWM
-period in nanoseconds. Note that in the example above, specifying the
-"pwm-names" is redundant because the name "backlight" would be used as
-fallback anyway.
+period in nanoseconds.
+Optional pwm-specifier can be encoded in 3rd cell in bit encoded form.
+ -------------------------------------------------------------
+|     Property   |  BIT position | Encoding                   |
+|-------------------------------------------------------------|
+| Polarity       |   0           | Set   -> Polarity inversed |
+|                |               | Clear -> Polarity Normal   |
+ -------------------------------------------------------------
+
+Exapmple with optional PWM specifier for inversed polarity
+
+	bl: backlight {
+		pwms = <&pwm 0 5000000 1>;
+		pwm-names = "backlight";
+	};
+
 
 2) PWM controller nodes
 -----------------------
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index f5acdaa..1c6d50b 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -146,6 +146,15 @@ of_pwm_simple_xlate(struct pwm_chip *pc, const struct of_phandle_args *args)
 
 	pwm_set_period(pwm, args->args[1]);
 
+	if (pc->of_pwm_n_cells > 2) {
+		enum pwm_polarity polarity;
+
+		/* Initialize polarity of PWM device */
+		polarity = args->args[2] & POLARITY_BIT ?
+			PWM_POLARITY_INVERSED : PWM_POLARITY_NORMAL;
+		pwm_set_polarity(pwm, polarity);
+	}
+
 	return pwm;
 }
 
@@ -156,7 +165,9 @@ static void of_pwmchip_add(struct pwm_chip *chip)
 
 	if (!chip->of_xlate) {
 		chip->of_xlate = of_pwm_simple_xlate;
-		chip->of_pwm_n_cells = 2;
+
+		if (chip->of_pwm_n_cells != 3)
+			chip->of_pwm_n_cells = 2;
 	}
 
 	of_node_get(chip->dev->of_node);
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 112b314..d77c5b3 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -78,6 +78,13 @@ enum {
 	PWMF_ENABLED = 1 << 1,
 };
 
+/*
+ * DT Platform property support.
+ * POLARITY - set bit 0 in DT platform property
+ */
+
+#define POLARITY_BIT	BIT(0)
+
 struct pwm_device {
 	const char		*label;
 	unsigned long		flags;
-- 
1.7.9.5


             reply	other threads:[~2012-10-29 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-29 17:40 Philip, Avinash [this message]
2012-11-09  8:30 ` [PATCH] pwm: Device tree support for PWM polarity Thierry Reding
2012-11-09 10:59   ` Philip, Avinash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351532427-19881-1-git-send-email-avinashphilip@ti.com \
    --to=avinashphilip@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=gururaja.hebbar@ti.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).