Re: [PATCH v2 03/10] dt-bindings: clock: provide separate bindings for qcom,gcc-mdm9615

[Dmitry Baryshkov <dmitry.baryshkov@linaro.org>]

On 12/05/2023 09:52, Krzysztof Kozlowski wrote:
> On 12/05/2023 02:32, Dmitry Baryshkov wrote:
>> The global clock controller on MDM9615 uses external CXO and PLL7
>> clocks. Split the qcom,gcc-mdm9615 to the separate schema file.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   .../bindings/clock/qcom,gcc-mdm9615.yaml      | 48 +++++++++++++++++++
>>   .../bindings/clock/qcom,gcc-other.yaml        |  3 --
>>   2 files changed, 48 insertions(+), 3 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml
>> new file mode 100644
>> index 000000000000..bc9786f2c1d5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml
>> @@ -0,0 +1,48 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,gcc-mdm9615.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Global Clock & Reset Controller on MDM9615
>> +
>> +maintainers:
>> +  - Stephen Boyd <sboyd@kernel.org>
>> +  - Taniya Das <quic_tdas@quicinc.com>
>> +
>> +description: |
>> +  Qualcomm global clock control module provides the clocks, resets and power
>> +  domains on MDM9615.
>> +
>> +  See also::
>> +    include/dt-bindings/clock/qcom,gcc-mdm9615.h
>> +    include/dt-bindings/reset/qcom,gcc-mdm9615.h
>> +
>> +allOf:
>> +  - $ref: qcom,gcc.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,gcc-mdm9615
>> +
>> +  clocks:
>> +    maxItems: 2
> 
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).

Indeed. I did this when preparing v1 and then skipped it when sending 
v2. Mea culpa.

-- 
With best wishes
Dmitry