From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0BD6C7EE24 for ; Fri, 12 May 2023 21:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238637AbjELVGl (ORCPT ); Fri, 12 May 2023 17:06:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238595AbjELVGk (ORCPT ); Fri, 12 May 2023 17:06:40 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FC203596 for ; Fri, 12 May 2023 14:06:39 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f139de8cefso54408052e87.0 for ; Fri, 12 May 2023 14:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683925595; x=1686517595; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EsiWgLFZscJzjm/g92UOpjZeba02UZH+himRJmD+dtQ=; b=n7IF88ZdZYqRZGDuqB/Dv/16wx9vbg/x6e6+WHnd+UnbMzZqXokFm4Zq4gQP1BbKnN tNLJwgsQfXJS6GMaLTz0LhuaVvVZCSlr8kSJXGdZ8vnh8u+/g2XgwzFX+lqHFgyHn+QZ Rt2CtSAwpZtGyeFxSXT0dpr72NRG/FXJ4mpk7iYevcaub0dspdK5RE+yZY6xSC0Pp/SB B3U5gGJCnXn8knfNef6eKHQ7y89OGuYPouv63+OGgG4EuBIx3+88ekszxw9oNwQ0CBIC O3HWeP5vLiM7afGd+dPZzyXZoRa8t5+MJ4CtOqGoZ8ycbTOnYIF89rGIr2kn0SUoSSpy 72xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683925595; x=1686517595; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EsiWgLFZscJzjm/g92UOpjZeba02UZH+himRJmD+dtQ=; b=JsLjbWsgm5rGzXZHMeoCJ6MAz+gj64jb063HCZUL8KD8q3bGAglvtjudcugpBCfex/ e7irvOflCCDR5Kjq5SHGOeA46w3D8HCz/3GHyCawk4YHodNis1uvG4aspNiLrt335+H4 yWDsjb563EgXGXZ+C0qzG6b5sTxyNFqF/mY5khkbmWsoET+2Ps6lbaqQpheTuJl5fqEs WW076pRIoQKOh8Rpqk3dA+YiyylHUoTRP/bqsAzqnDXzNRjdfjxQhAwQNG3durGMG7lX 6HAfNWcQcgccl7sn7gTRZ5OqjiDk1BoRTL1iu356qxjrAQXPZ3msVLXi+/OHyzcEilze 3now== X-Gm-Message-State: AC+VfDwZx4v0EH489ApWwCpoBNTzkR9y2yVUODArFQSTNi3U8SW3IaVS aGkTB3vRYgeqSgjnz2oTezpA1g== X-Google-Smtp-Source: ACHHUZ4CwKOHCsRb0bfIwwJbnr+PWrGViaDjdBuMWsTm/HnJwmySw0sQnF4fsrwMPM5AfAloglKfUg== X-Received: by 2002:a2e:a377:0:b0:2ac:826a:efae with SMTP id i23-20020a2ea377000000b002ac826aefaemr4628424ljn.5.1683925594723; Fri, 12 May 2023 14:06:34 -0700 (PDT) Received: from [192.168.2.40] ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id g9-20020a2eb0c9000000b002ac8164d77fsm2895728ljl.86.2023.05.12.14.06.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 14:06:34 -0700 (PDT) Message-ID: <1351c7b9-ab70-f6ec-3d0e-2b56af42c5c8@linaro.org> Date: Sat, 13 May 2023 00:06:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 03/10] dt-bindings: clock: provide separate bindings for qcom,gcc-mdm9615 Content-Language: en-GB To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org References: <20230512003230.3043284-1-dmitry.baryshkov@linaro.org> <20230512003230.3043284-4-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/05/2023 09:52, Krzysztof Kozlowski wrote: > On 12/05/2023 02:32, Dmitry Baryshkov wrote: >> The global clock controller on MDM9615 uses external CXO and PLL7 >> clocks. Split the qcom,gcc-mdm9615 to the separate schema file. >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Dmitry Baryshkov >> --- >> .../bindings/clock/qcom,gcc-mdm9615.yaml | 48 +++++++++++++++++++ >> .../bindings/clock/qcom,gcc-other.yaml | 3 -- >> 2 files changed, 48 insertions(+), 3 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml >> new file mode 100644 >> index 000000000000..bc9786f2c1d5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-mdm9615.yaml >> @@ -0,0 +1,48 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/qcom,gcc-mdm9615.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Global Clock & Reset Controller on MDM9615 >> + >> +maintainers: >> + - Stephen Boyd >> + - Taniya Das >> + >> +description: | >> + Qualcomm global clock control module provides the clocks, resets and power >> + domains on MDM9615. >> + >> + See also:: >> + include/dt-bindings/clock/qcom,gcc-mdm9615.h >> + include/dt-bindings/reset/qcom,gcc-mdm9615.h >> + >> +allOf: >> + - $ref: qcom,gcc.yaml# >> + >> +properties: >> + compatible: >> + const: qcom,gcc-mdm9615 >> + >> + clocks: >> + maxItems: 2 > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). Indeed. I did this when preparing v1 and then skipped it when sending v2. Mea culpa. -- With best wishes Dmitry