* [PATCH v2] usb: musb: dsps: dt binding - add resources, example
@ 2012-11-06 13:56 Afzal Mohammed
[not found] ` <1352210166-7253-1-git-send-email-afzal-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Afzal Mohammed @ 2012-11-06 13:56 UTC (permalink / raw)
To: Felipe Balbi
Cc: Grant Likely, Rob Herring, Rob Landley, Santhapuri Damodar,
Ravi Babu, Daniel Mack, devicetree-discuss, linux-doc, linux-usb,
linux-omap, Afzal Mohammed
OMAP2+ family of devices are now obtaining resources via DT, earlier
it was obtained from hwmod. Update binding document accrodingly, while
at it add example.
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
v2: node name changed to "usb"
.../devicetree/bindings/usb/am33xx-usb.txt | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
index a922505..ea840f7 100644
--- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt
+++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
@@ -1,5 +1,7 @@
AM33XX MUSB GLUE
- compatible : Should be "ti,musb-am33xx"
+ - reg : offset and length of register sets, first usbss, then for musb instances
+ - interrupts : usbss, musb instance interrupts in order
- ti,hwmods : must be "usb_otg_hs"
- multipoint : Should be "1" indicating the musb controller supports
multipoint. This is a MUSB configuration-specific setting.
@@ -12,3 +14,22 @@ AM33XX MUSB GLUE
represents PERIPHERAL.
- power : Should be "250". This signifies the controller can supply upto
500mA when operating in host mode.
+
+Example:
+
+usb@47400000 {
+ compatible = "ti,musb-am33xx";
+ reg = <0x47400000 0x1000 /* usbss */
+ 0x47401000 0x800 /* musb instance 0 */
+ 0x47401800 0x800>; /* musb instance 1 */
+ interrupts = <17 /* usbss */
+ 18 /* musb instance 0 */
+ 19>; /* musb instance 1 */
+ multipoint = <1>;
+ num-eps = <16>;
+ ram-bits = <12>;
+ port0-mode = <3>;
+ port1-mode = <3>;
+ power = <250>;
+ ti,hwmods = "usb_otg_hs";
+};
--
1.7.12
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1352210166-7253-1-git-send-email-afzal-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH v2] usb: musb: dsps: dt binding - add resources, example [not found] ` <1352210166-7253-1-git-send-email-afzal-l0cyMroinI0@public.gmane.org> @ 2012-11-06 16:44 ` Felipe Balbi 2012-11-06 16:58 ` Benoit Cousson 0 siblings, 1 reply; 5+ messages in thread From: Felipe Balbi @ 2012-11-06 16:44 UTC (permalink / raw) To: Afzal Mohammed Cc: Felipe Balbi, Grant Likely, Rob Herring, Rob Landley, Santhapuri Damodar, Ravi Babu, Daniel Mack, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-doc-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, Benoit Cousson [-- Attachment #1: Type: text/plain, Size: 2060 bytes --] Hi, On Tue, Nov 06, 2012 at 07:26:06PM +0530, Afzal Mohammed wrote: > OMAP2+ family of devices are now obtaining resources via DT, earlier > it was obtained from hwmod. Update binding document accrodingly, while > at it add example. > > Signed-off-by: Afzal Mohammed <afzal-l0cyMroinI0@public.gmane.org> this looks fine to me: Reviewed-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> Benoit, do you take Documentation patches too ? > --- > > v2: node name changed to "usb" > > .../devicetree/bindings/usb/am33xx-usb.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt > index a922505..ea840f7 100644 > --- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt > +++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt > @@ -1,5 +1,7 @@ > AM33XX MUSB GLUE > - compatible : Should be "ti,musb-am33xx" > + - reg : offset and length of register sets, first usbss, then for musb instances > + - interrupts : usbss, musb instance interrupts in order > - ti,hwmods : must be "usb_otg_hs" > - multipoint : Should be "1" indicating the musb controller supports > multipoint. This is a MUSB configuration-specific setting. > @@ -12,3 +14,22 @@ AM33XX MUSB GLUE > represents PERIPHERAL. > - power : Should be "250". This signifies the controller can supply upto > 500mA when operating in host mode. > + > +Example: > + > +usb@47400000 { > + compatible = "ti,musb-am33xx"; > + reg = <0x47400000 0x1000 /* usbss */ > + 0x47401000 0x800 /* musb instance 0 */ > + 0x47401800 0x800>; /* musb instance 1 */ > + interrupts = <17 /* usbss */ > + 18 /* musb instance 0 */ > + 19>; /* musb instance 1 */ > + multipoint = <1>; > + num-eps = <16>; > + ram-bits = <12>; > + port0-mode = <3>; > + port1-mode = <3>; > + power = <250>; > + ti,hwmods = "usb_otg_hs"; > +}; > -- > 1.7.12 > -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] usb: musb: dsps: dt binding - add resources, example 2012-11-06 16:44 ` Felipe Balbi @ 2012-11-06 16:58 ` Benoit Cousson 2012-11-06 18:22 ` Felipe Balbi 0 siblings, 1 reply; 5+ messages in thread From: Benoit Cousson @ 2012-11-06 16:58 UTC (permalink / raw) To: balbi Cc: Afzal Mohammed, Grant Likely, Rob Herring, Rob Landley, Santhapuri Damodar, Ravi Babu, Daniel Mack, devicetree-discuss, linux-doc, linux-usb, linux-omap On 11/06/2012 05:44 PM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 06, 2012 at 07:26:06PM +0530, Afzal Mohammed wrote: >> OMAP2+ family of devices are now obtaining resources via DT, earlier >> it was obtained from hwmod. Update binding document accrodingly, while >> at it add example. >> >> Signed-off-by: Afzal Mohammed <afzal@ti.com> > > this looks fine to me: > > Reviewed-by: Felipe Balbi <balbi@ti.com> > > Benoit, do you take Documentation patches too ? Well, ideally it should go with the driver change. But if this is a simple change related to generic attribute I can take it. Regards, Benoit > >> --- >> >> v2: node name changed to "usb" >> >> .../devicetree/bindings/usb/am33xx-usb.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt >> index a922505..ea840f7 100644 >> --- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt >> +++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt >> @@ -1,5 +1,7 @@ >> AM33XX MUSB GLUE >> - compatible : Should be "ti,musb-am33xx" >> + - reg : offset and length of register sets, first usbss, then for musb instances >> + - interrupts : usbss, musb instance interrupts in order >> - ti,hwmods : must be "usb_otg_hs" >> - multipoint : Should be "1" indicating the musb controller supports >> multipoint. This is a MUSB configuration-specific setting. >> @@ -12,3 +14,22 @@ AM33XX MUSB GLUE >> represents PERIPHERAL. >> - power : Should be "250". This signifies the controller can supply upto >> 500mA when operating in host mode. >> + >> +Example: >> + >> +usb@47400000 { >> + compatible = "ti,musb-am33xx"; >> + reg = <0x47400000 0x1000 /* usbss */ >> + 0x47401000 0x800 /* musb instance 0 */ >> + 0x47401800 0x800>; /* musb instance 1 */ >> + interrupts = <17 /* usbss */ >> + 18 /* musb instance 0 */ >> + 19>; /* musb instance 1 */ >> + multipoint = <1>; >> + num-eps = <16>; >> + ram-bits = <12>; >> + port0-mode = <3>; >> + port1-mode = <3>; >> + power = <250>; >> + ti,hwmods = "usb_otg_hs"; >> +}; >> -- >> 1.7.12 >> > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] usb: musb: dsps: dt binding - add resources, example 2012-11-06 16:58 ` Benoit Cousson @ 2012-11-06 18:22 ` Felipe Balbi 2012-11-07 11:03 ` Benoit Cousson 0 siblings, 1 reply; 5+ messages in thread From: Felipe Balbi @ 2012-11-06 18:22 UTC (permalink / raw) To: Benoit Cousson Cc: balbi, Afzal Mohammed, Grant Likely, Rob Herring, Rob Landley, Santhapuri Damodar, Ravi Babu, Daniel Mack, devicetree-discuss, linux-doc, linux-usb, linux-omap [-- Attachment #1: Type: text/plain, Size: 787 bytes --] Hi, On Tue, Nov 06, 2012 at 05:58:57PM +0100, Benoit Cousson wrote: > On 11/06/2012 05:44 PM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Nov 06, 2012 at 07:26:06PM +0530, Afzal Mohammed wrote: > >> OMAP2+ family of devices are now obtaining resources via DT, earlier > >> it was obtained from hwmod. Update binding document accrodingly, while > >> at it add example. > >> > >> Signed-off-by: Afzal Mohammed <afzal@ti.com> > > > > this looks fine to me: > > > > Reviewed-by: Felipe Balbi <balbi@ti.com> > > > > Benoit, do you take Documentation patches too ? > > Well, ideally it should go with the driver change. But if this is a > simple change related to generic attribute I can take it. ok, cool. Please take this via your tree. thanks -- balbi [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] usb: musb: dsps: dt binding - add resources, example 2012-11-06 18:22 ` Felipe Balbi @ 2012-11-07 11:03 ` Benoit Cousson 0 siblings, 0 replies; 5+ messages in thread From: Benoit Cousson @ 2012-11-07 11:03 UTC (permalink / raw) To: balbi Cc: Afzal Mohammed, Grant Likely, Rob Herring, Rob Landley, Santhapuri Damodar, Ravi Babu, Daniel Mack, devicetree-discuss, linux-doc, linux-usb, linux-omap Hi Felipe, On 11/06/2012 07:22 PM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 06, 2012 at 05:58:57PM +0100, Benoit Cousson wrote: >> On 11/06/2012 05:44 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Tue, Nov 06, 2012 at 07:26:06PM +0530, Afzal Mohammed wrote: >>>> OMAP2+ family of devices are now obtaining resources via DT, earlier >>>> it was obtained from hwmod. Update binding document accrodingly, while >>>> at it add example. >>>> >>>> Signed-off-by: Afzal Mohammed <afzal@ti.com> >>> >>> this looks fine to me: >>> >>> Reviewed-by: Felipe Balbi <balbi@ti.com> >>> >>> Benoit, do you take Documentation patches too ? >> >> Well, ideally it should go with the driver change. But if this is a >> simple change related to generic attribute I can take it. > > ok, cool. Please take this via your tree. Done. I've just applied it in my for_3.8/dts_part2 branch. Regards, Benoit ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-11-07 11:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-06 13:56 [PATCH v2] usb: musb: dsps: dt binding - add resources, example Afzal Mohammed
[not found] ` <1352210166-7253-1-git-send-email-afzal-l0cyMroinI0@public.gmane.org>
2012-11-06 16:44 ` Felipe Balbi
2012-11-06 16:58 ` Benoit Cousson
2012-11-06 18:22 ` Felipe Balbi
2012-11-07 11:03 ` Benoit Cousson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).