* [PATCH v2] ARM: dts: AM33XX: Add usbss node
@ 2012-11-06 14:29 Afzal Mohammed
2012-11-06 14:29 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Afzal Mohammed @ 2012-11-06 14:29 UTC (permalink / raw)
To: Benoit Cousson
Cc: Felipe Balbi, Russell King, Tony Lindgren, Rob Herring,
Vaibhav Hiremath, AnilKumar Ch, Ravi Babu, Santhapuri Damodar,
Daniel Mack, linux-omap, linux-arm-kernel, devicetree-discuss
From: Ajay Kumar Gupta <ajay.gupta@ti.com>
Device tree node for usbss on AM33XX. There are two musb
controllers on am33xx platform so have port0-mode and
port1-mode data.
[afzal@ti.com: reg & interrupt property addition]
Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
Signed-off-by: Ravi Babu <ravibabu@ti.com>
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
v2: node named as "usb"
Depends on "usb: musb: dsps: dt binding - add resources, example"
(https://patchwork.kernel.org/patch/1704691/)
arch/arm/boot/dts/am33xx.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 5dfd682..20a3f29 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -321,5 +321,22 @@
ti,hwmods = "spi1";
status = "disabled";
};
+
+ usb@47400000 {
+ compatible = "ti,musb-am33xx";
+ reg = <0x47400000 0x1000 /* usbss */
+ 0x47401000 0x800 /* musb instance 0 */
+ 0x47401800 0x800>; /* musb instance 1 */
+ interrupts = <17 /* usbss */
+ 18 /* musb instance 0 */
+ 19>; /* musb instance 1 */
+ multipoint = <1>;
+ num-eps = <16>;
+ ram-bits = <12>;
+ port0-mode = <3>;
+ port1-mode = <3>;
+ power = <250>;
+ ti,hwmods = "usb_otg_hs";
+ };
};
};
--
1.7.12
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: dts: AM33XX: Add usbss node
2012-11-06 14:29 [PATCH v2] ARM: dts: AM33XX: Add usbss node Afzal Mohammed
@ 2012-11-06 14:29 ` Felipe Balbi
2012-11-06 15:32 ` Benoit Cousson
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2012-11-06 14:29 UTC (permalink / raw)
To: Afzal Mohammed
Cc: Benoit Cousson, Felipe Balbi, Russell King, Tony Lindgren,
Rob Herring, Vaibhav Hiremath, AnilKumar Ch, Ravi Babu,
Santhapuri Damodar, Daniel Mack, linux-omap, linux-arm-kernel,
devicetree-discuss
[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]
Hi,
On Tue, Nov 06, 2012 at 07:59:38PM +0530, Afzal Mohammed wrote:
> From: Ajay Kumar Gupta <ajay.gupta@ti.com>
>
> Device tree node for usbss on AM33XX. There are two musb
> controllers on am33xx platform so have port0-mode and
> port1-mode data.
>
> [afzal@ti.com: reg & interrupt property addition]
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
to my eyes, this looks ok.
Reviewed-by: Felipe Balbi <balbi@ti.com>
> ---
>
> v2: node named as "usb"
>
> Depends on "usb: musb: dsps: dt binding - add resources, example"
> (https://patchwork.kernel.org/patch/1704691/)
>
> arch/arm/boot/dts/am33xx.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 5dfd682..20a3f29 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -321,5 +321,22 @@
> ti,hwmods = "spi1";
> status = "disabled";
> };
> +
> + usb@47400000 {
> + compatible = "ti,musb-am33xx";
> + reg = <0x47400000 0x1000 /* usbss */
> + 0x47401000 0x800 /* musb instance 0 */
> + 0x47401800 0x800>; /* musb instance 1 */
> + interrupts = <17 /* usbss */
> + 18 /* musb instance 0 */
> + 19>; /* musb instance 1 */
> + multipoint = <1>;
> + num-eps = <16>;
> + ram-bits = <12>;
> + port0-mode = <3>;
> + port1-mode = <3>;
> + power = <250>;
> + ti,hwmods = "usb_otg_hs";
> + };
> };
> };
> --
> 1.7.12
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: dts: AM33XX: Add usbss node
2012-11-06 14:29 ` Felipe Balbi
@ 2012-11-06 15:32 ` Benoit Cousson
0 siblings, 0 replies; 3+ messages in thread
From: Benoit Cousson @ 2012-11-06 15:32 UTC (permalink / raw)
To: balbi
Cc: Afzal Mohammed, Russell King, Tony Lindgren, Rob Herring,
Vaibhav Hiremath, AnilKumar Ch, Ravi Babu, Santhapuri Damodar,
Daniel Mack, linux-omap, linux-arm-kernel, devicetree-discuss
On 11/06/2012 03:29 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Nov 06, 2012 at 07:59:38PM +0530, Afzal Mohammed wrote:
>> From: Ajay Kumar Gupta <ajay.gupta@ti.com>
>>
>> Device tree node for usbss on AM33XX. There are two musb
>> controllers on am33xx platform so have port0-mode and
>> port1-mode data.
>>
>> [afzal@ti.com: reg & interrupt property addition]
>>
>> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>> Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
>> Signed-off-by: Ravi Babu <ravibabu@ti.com>
>> Signed-off-by: Afzal Mohammed <afzal@ti.com>
>
> to my eyes, this looks ok.
>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
Thanks Felipe. Patch applied in for_3.8/dts_part2 branch.
Regards,
Benoit
>
>> ---
>>
>> v2: node named as "usb"
>>
>> Depends on "usb: musb: dsps: dt binding - add resources, example"
>> (https://patchwork.kernel.org/patch/1704691/)
>>
>> arch/arm/boot/dts/am33xx.dtsi | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 5dfd682..20a3f29 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -321,5 +321,22 @@
>> ti,hwmods = "spi1";
>> status = "disabled";
>> };
>> +
>> + usb@47400000 {
>> + compatible = "ti,musb-am33xx";
>> + reg = <0x47400000 0x1000 /* usbss */
>> + 0x47401000 0x800 /* musb instance 0 */
>> + 0x47401800 0x800>; /* musb instance 1 */
>> + interrupts = <17 /* usbss */
>> + 18 /* musb instance 0 */
>> + 19>; /* musb instance 1 */
>> + multipoint = <1>;
>> + num-eps = <16>;
>> + ram-bits = <12>;
>> + port0-mode = <3>;
>> + port1-mode = <3>;
>> + power = <250>;
>> + ti,hwmods = "usb_otg_hs";
>> + };
>> };
>> };
>> --
>> 1.7.12
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-06 15:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-06 14:29 [PATCH v2] ARM: dts: AM33XX: Add usbss node Afzal Mohammed
2012-11-06 14:29 ` Felipe Balbi
2012-11-06 15:32 ` Benoit Cousson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).