From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Vinod Koul <vinod.koul@intel.com>,
linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org, spear-devel@list.st.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support
Date: Wed, 12 Dec 2012 10:40:21 +0200 [thread overview]
Message-ID: <1355301621.31620.66.camel@smile> (raw)
In-Reply-To: <CAKohpo=FjZuMOC-wuNc3q_FXbk546ttCLr55GkW9AL0Tz-HoBA@mail.gmail.com>
On Wed, 2012-12-12 at 08:30 +0530, Viresh Kumar wrote:
> > * It requires slave drivers to know that they are using the dw_dmac
> > driver and pass a pointer to dw_generic_filter, which is not
> > generic at all
> >
> > * It requires the dmac node to have information about all slaves
> >
> > There are also some minor issues, such as the naming of DT
> > properties, but the above need to be resolved first.
>
> I saw the binding document and it looks it can be applied to dw_dmac
> too, as there is nothing special for it.
>
> The question is how? We are already late for merge window and this
> one is queued. Supplying a new patch, getting it reviewed/tested and
> being pulled by Linus is not so easy :)
>
> Two ways:
> - Keep it as is, and i will fix it separately and quickly
> - Drop it :(
Will we survive if the patch is in mainline? I mean how big the impact
of it is?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2012-12-12 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 4:19 [PATCH V3 1/3] dmaengine: dw_dmac: Update documentation style comments for dw_dma_platform_data Viresh Kumar
2012-10-16 4:19 ` [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support Viresh Kumar
2012-10-26 8:55 ` Viresh Kumar
2012-10-26 8:48 ` Vinod Koul
2012-10-26 9:05 ` Viresh Kumar
2012-10-26 9:10 ` Vinod Koul
2012-12-10 22:08 ` Arnd Bergmann
2012-12-10 22:21 ` Arnd Bergmann
2012-12-12 3:00 ` Viresh Kumar
2012-12-12 8:40 ` Andy Shevchenko [this message]
2012-12-12 8:43 ` Viresh Kumar
2013-01-08 23:09 ` Arnd Bergmann
2012-12-12 8:42 ` Andy Shevchenko
2012-10-16 4:19 ` [PATCH V3 3/3] ARM: SPEAr13xx: Pass DW DMAC platform data from DT Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355301621.31620.66.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).