From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Prisk Subject: Re: [PATCH 1/9] sh-pfc: Add OF support Date: Fri, 04 Jan 2013 14:12:06 +1300 Message-ID: <1357261926.25326.2.camel@gitbox> References: <1357260060-32164-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1357260060-32164-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1357260060-32164-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Sender: linux-sh-owner@vger.kernel.org To: Laurent Pinchart Cc: linux-sh@vger.kernel.org, Simon Horman , Phil Edworthy , Kuninori Morimoto , devicetree-discuss@lists.ozlabs.org, Magnus Damm , Paul Mundt , Nobuhiro Iwamatsu , Guennadi Liakhovetski List-Id: devicetree@vger.kernel.org On Fri, 2013-01-04 at 01:40 +0100, Laurent Pinchart wrote: > +- #gpio-cells: Should be 2. The first cell is the pin number and the second cell > + is used to specify optional parameters (currently unused). ... > + gpio: pfc@e6050000 { > + compatible = "renesas,pfc-sh73a0"; > + reg = <0xe6050000 0x8000>, > + <0xe605801c 0x1c>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > +Example 2: A GPIO LED node that references a GPIO > + > + leds { > + compatible = "gpio-leds"; > + led1 { > + gpios = <&gpio 20 1>; /* Active low */ > + }; > + }; > + The second cell of gpio is '(currently unused)' but the example shows it being used? Regards Tony Prisk