From: Artem Bityutskiy <dedekind1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2] mtd: cfi_cmdset_0002: Support Persistent Protection Bits (PPB) locking
Date: Tue, 15 Jan 2013 11:10:38 +0200 [thread overview]
Message-ID: <1358241038.2731.118.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1355387350-14002-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1003 bytes --]
On Thu, 2012-12-13 at 09:29 +0100, Stefan Roese wrote:
> Currently cfi_cmdset_0002.c does not support PPB locking of sectors. This
> patch adds support for this locking/unlocking mechanism. It is needed on
> some platforms, since newer U-Boot versions do support this PPB locking
> and protect for example their environment sector(s) this way.
Some "#ifdef CONFIG_OF"s are missing:
drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘cfi_cmdset_0002’:
drivers/mtd/chips/cfi_cmdset_0002.c:579:4: error: implicit declaration of function ‘of_property_read_bool’ [-Werror=implicit-function-declaration]
drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘do_read_secsi_onechip’:
drivers/mtd/chips/cfi_cmdset_0002.c:1146:16: warning: variable ‘timeo’ set but not used [-Wunused-but-set-variable]
cc1: some warnings being treated as errors
make[4]: *** [drivers/mtd/chips/cfi_cmdset_0002.o] Error 1
Please, check allso the timeo warning.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 192 bytes --]
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
prev parent reply other threads:[~2013-01-15 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 8:29 [PATCH v2] mtd: cfi_cmdset_0002: Support Persistent Protection Bits (PPB) locking Stefan Roese
[not found] ` <1355387350-14002-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2013-01-15 9:10 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358241038.2731.118.camel@sauron.fi.intel.com \
--to=dedekind1-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=sr-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).