From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH 7/7] ARM i.MX5: Add system reset controller (SRC) to i.MX51 and i.MX53 device tree Date: Thu, 17 Jan 2013 11:45:21 +0100 Message-ID: <1358419521.2411.125.camel@pizza.hi.pengutronix.de> References: <1358352787-15441-1-git-send-email-p.zabel@pengutronix.de> <1358352787-15441-8-git-send-email-p.zabel@pengutronix.de> <50F72780.8040208@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50F72780.8040208-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Stephen Warren Cc: Marek Vasut , Fabio Estevam , Mike Turquette , Sascha Hauer , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Am Mittwoch, den 16.01.2013, 15:19 -0700 schrieb Stephen Warren: > On 01/16/2013 09:13 AM, Philipp Zabel wrote: > > Also, link SRC to IPU via phandle. > > Aside from the comments I already made, the series, > Reviewed-by: Stephen Warren Thank you. > although I'm not 100% sure if the ordering of patches maintains a > working i.MX build all the time? Does "git bisect" work across the series? Since IPU probing doesn't succeed if device_reset() fails, the IPU patch needs to be ordered after the i.MX5 patches. On the other hand, should device_reset() fail at all if no reset controller was specified in the device tree? regards Philipp