* [PATCH 1/6] ARM: dts: Update MFC DT binding documentation
2013-01-30 7:11 [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sachin Kamat
@ 2013-01-30 7:11 ` Sachin Kamat
2013-01-30 7:11 ` [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines Sachin Kamat
` (5 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 7:11 UTC (permalink / raw)
To: linux-samsung-soc
Cc: devicetree-discuss, kgene.kim, sachin.kamat, patches,
Arun Kumar K
Added an example for bindings for illustration and clarity.
Cc: devicetree-discuss@lists.ozlabs.org
Cc: Arun Kumar K <arun.kk@samsung.com>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
.../devicetree/bindings/media/s5p-mfc.txt | 21 ++++++++++++++++++++
1 files changed, 21 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt
index 67ec3d4..bf0182d 100644
--- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
+++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
@@ -21,3 +21,24 @@ Required properties:
- samsung,mfc-l : Base address of the second memory bank used by MFC
for DMA contiguous memory allocation and its size.
+
+Optional properties:
+ - samsung,power-domain : power-domain property defined with a phandle
+ to respective power domain.
+
+Example:
+SoC specific DT entry:
+
+mfc: codec@13400000 {
+ compatible = "samsung,mfc-v5";
+ reg = <0x13400000 0x10000>;
+ interrupts = <0 94 0>;
+ samsung,power-domain = <&pd_mfc>;
+};
+
+Board specific DT entry:
+
+codec@13400000 {
+ samsung,mfc-r = <0x43000000 0x800000>;
+ samsung,mfc-l = <0x51000000 0x800000>;
+};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines
2013-01-30 7:11 [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sachin Kamat
2013-01-30 7:11 ` [PATCH 1/6] ARM: dts: Update MFC DT binding documentation Sachin Kamat
@ 2013-01-30 7:11 ` Sachin Kamat
2013-01-30 7:11 ` [PATCH 3/6] ARM: dts: Add MFC codec support to SMDKV310 DT Sachin Kamat
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 7:11 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, kgene.kim, sachin.kamat, patches
This patch adds MFC codec support for Exynos4 DT machines.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4.dtsi | 8 ++++++++
arch/arm/mach-exynos/Kconfig | 1 +
arch/arm/mach-exynos/mach-exynos4-dt.c | 17 +++++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index e1347fc..6581bb2 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -131,6 +131,14 @@
status = "disabled";
};
+ mfc: codec@13400000 {
+ compatible = "samsung,mfc-v5";
+ reg = <0x13400000 0x10000>;
+ interrupts = <0 94 0>;
+ samsung,power-domain = <&pd_mfc>;
+ status = "disabled";
+ };
+
serial@13800000 {
compatible = "samsung,exynos4210-uart";
reg = <0x13800000 0x100>;
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index e103c29..f0d8f09 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -415,6 +415,7 @@ config MACH_EXYNOS4_DT
select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD
select PINCTRL
select PINCTRL_EXYNOS4
+ select S5P_DEV_MFC
select USE_OF
help
Machine support for Samsung Exynos4 machine with device tree enabled.
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index ab1dacc..8ae8da1 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -12,7 +12,9 @@
*/
#include <linux/of_platform.h>
+#include <linux/of_fdt.h>
#include <linux/serial_core.h>
+#include <linux/memblock.h>
#include <asm/mach/arch.h>
#include <asm/hardware/gic.h>
@@ -20,6 +22,7 @@
#include <plat/cpu.h>
#include <plat/regs-serial.h>
+#include <plat/mfc.h>
#include "common.h"
@@ -80,6 +83,7 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL),
OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
"exynos-tmu", NULL),
+ OF_DEV_AUXDATA("samsung,mfc-v5", 0x13400000, "s5p-mfc", NULL),
{},
};
@@ -102,6 +106,18 @@ static char const *exynos4_dt_compat[] __initdata = {
NULL
};
+static void __init exynos4_reserve(void)
+{
+#ifdef CONFIG_S5P_DEV_MFC
+ struct s5p_mfc_dt_meminfo mfc_mem;
+
+ /* Reserve memory for MFC only if it's available */
+ mfc_mem.compatible = "samsung,mfc-v5";
+ if (of_scan_flat_dt(s5p_fdt_find_mfc_mem, &mfc_mem))
+ s5p_mfc_reserve_mem(mfc_mem.roff, mfc_mem.rsize, mfc_mem.loff,
+ mfc_mem.lsize);
+#endif
+}
DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device Tree)")
/* Maintainer: Thomas Abraham <thomas.abraham@linaro.org> */
.smp = smp_ops(exynos_smp_ops),
@@ -114,4 +130,5 @@ DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device Tree)")
.timer = &exynos4_timer,
.dt_compat = exynos4_dt_compat,
.restart = exynos4_restart,
+ .reserve = exynos4_reserve,
MACHINE_END
--
1.7.4.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/6] ARM: dts: Add MFC codec support to SMDKV310 DT
2013-01-30 7:11 [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sachin Kamat
2013-01-30 7:11 ` [PATCH 1/6] ARM: dts: Update MFC DT binding documentation Sachin Kamat
2013-01-30 7:11 ` [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines Sachin Kamat
@ 2013-01-30 7:11 ` Sachin Kamat
2013-01-30 7:11 ` [PATCH 4/6] ARM: dts: Add MFC codec support to Origen DT Sachin Kamat
` (3 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 7:11 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, kgene.kim, sachin.kamat, patches
Added MFC codec support to SMDKV310 DT file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4210-smdkv310.dts | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index f634907..2b1e03a 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -43,6 +43,12 @@
status = "okay";
};
+ codec@13400000 {
+ samsung,mfc-r = <0x43000000 0x800000>;
+ samsung,mfc-l = <0x51000000 0x800000>;
+ status = "okay";
+ };
+
serial@13800000 {
status = "okay";
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 4/6] ARM: dts: Add MFC codec support to Origen DT
2013-01-30 7:11 [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sachin Kamat
` (2 preceding siblings ...)
2013-01-30 7:11 ` [PATCH 3/6] ARM: dts: Add MFC codec support to SMDKV310 DT Sachin Kamat
@ 2013-01-30 7:11 ` Sachin Kamat
2013-01-30 7:11 ` [PATCH 5/6] ARM: dts: Add MFC codec entry to exynos4412-origen DT file Sachin Kamat
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 7:11 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, kgene.kim, sachin.kamat, patches
This patch adds MFC codec support to Origen DT file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4210-origen.dts | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index f271001..052606b 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -57,6 +57,12 @@
status = "okay";
};
+ codec@13400000 {
+ samsung,mfc-r = <0x43000000 0x800000>;
+ samsung,mfc-l = <0x51000000 0x800000>;
+ status = "okay";
+ };
+
serial@13800000 {
status = "okay";
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 5/6] ARM: dts: Add MFC codec entry to exynos4412-origen DT file
2013-01-30 7:11 [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sachin Kamat
` (3 preceding siblings ...)
2013-01-30 7:11 ` [PATCH 4/6] ARM: dts: Add MFC codec support to Origen DT Sachin Kamat
@ 2013-01-30 7:11 ` Sachin Kamat
2013-01-30 7:11 ` [PATCH 6/6] ARM: dts: Add MFC codec entry to exynos4412-smdk4412 " Sachin Kamat
2013-01-30 9:00 ` [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sylwester Nawrocki
6 siblings, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 7:11 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, kgene.kim, sachin.kamat, patches
Added MFC codec entry to exynos4412-origen.dts.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4412-origen.dts | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 4eba374..e066fc6 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -44,6 +44,12 @@
status = "okay";
};
+ codec@13400000 {
+ samsung,mfc-r = <0x43000000 0x800000>;
+ samsung,mfc-l = <0x51000000 0x800000>;
+ status = "okay";
+ };
+
serial@13800000 {
status = "okay";
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 6/6] ARM: dts: Add MFC codec entry to exynos4412-smdk4412 DT file
2013-01-30 7:11 [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sachin Kamat
` (4 preceding siblings ...)
2013-01-30 7:11 ` [PATCH 5/6] ARM: dts: Add MFC codec entry to exynos4412-origen DT file Sachin Kamat
@ 2013-01-30 7:11 ` Sachin Kamat
2013-01-30 9:00 ` [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sylwester Nawrocki
6 siblings, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 7:11 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, kgene.kim, sachin.kamat, patches
Added MFC DT entry to exynos4412-smdk4412.dts file.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4412-smdk4412.dts | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index e885971..6ae4276 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -34,6 +34,12 @@
status = "okay";
};
+ codec@13400000 {
+ samsung,mfc-r = <0x43000000 0x800000>;
+ samsung,mfc-l = <0x51000000 0x800000>;
+ status = "okay";
+ };
+
serial@13800000 {
status = "okay";
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4
2013-01-30 7:11 [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sachin Kamat
` (5 preceding siblings ...)
2013-01-30 7:11 ` [PATCH 6/6] ARM: dts: Add MFC codec entry to exynos4412-smdk4412 " Sachin Kamat
@ 2013-01-30 9:00 ` Sylwester Nawrocki
2013-01-30 10:31 ` Sachin Kamat
2013-02-05 5:52 ` Sachin Kamat
6 siblings, 2 replies; 14+ messages in thread
From: Sylwester Nawrocki @ 2013-01-30 9:00 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, patches
On 01/30/2013 08:11 AM, Sachin Kamat wrote:
> Changes since v1:
> Addressed comments from Sylwester
> - Updated documentation
> - Added 'status' to the nodes
> - Updated Kconfig entry
>
> This series is based on for-next branch of Kukjin Kim's tree.
> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> Sachin Kamat (6):
> ARM: dts: Update MFC DT binding documentation
> ARM: dts: Add MFC codec support for Exynos4 DT machines
> ARM: dts: Add MFC codec support to SMDKV310 DT
> ARM: dts: Add MFC codec support to Origen DT
> ARM: dts: Add MFC codec entry to exynos4412-origen DT file
> ARM: dts: Add MFC codec entry to exynos4412-smdk4412 DT file
Thanks Sachin. For the whole series:
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
I have also tested patch 2/6 on an Exynos4412 based board,
just added the mfc clock entries in the codec node.
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4
2013-01-30 9:00 ` [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sylwester Nawrocki
@ 2013-01-30 10:31 ` Sachin Kamat
2013-02-05 5:52 ` Sachin Kamat
1 sibling, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 10:31 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, patches
>
> Thanks Sachin. For the whole series:
>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
> I have also tested patch 2/6 on an Exynos4412 based board,
> just added the mfc clock entries in the codec node.
Thanks Sylwester for your review and testing.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4
2013-01-30 9:00 ` [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4 Sylwester Nawrocki
2013-01-30 10:31 ` Sachin Kamat
@ 2013-02-05 5:52 ` Sachin Kamat
2013-02-05 6:01 ` Kukjin Kim
1 sibling, 1 reply; 14+ messages in thread
From: Sachin Kamat @ 2013-02-05 5:52 UTC (permalink / raw)
To: Kukjin Kim
Cc: linux-samsung-soc, devicetree-discuss, patches,
Sylwester Nawrocki
Hi Kukjin,
On 30 January 2013 14:30, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
> On 01/30/2013 08:11 AM, Sachin Kamat wrote:
>> Changes since v1:
>> Addressed comments from Sylwester
>> - Updated documentation
>> - Added 'status' to the nodes
>> - Updated Kconfig entry
>>
>> This series is based on for-next branch of Kukjin Kim's tree.
>> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
>> Sachin Kamat (6):
>> ARM: dts: Update MFC DT binding documentation
>> ARM: dts: Add MFC codec support for Exynos4 DT machines
>> ARM: dts: Add MFC codec support to SMDKV310 DT
>> ARM: dts: Add MFC codec support to Origen DT
>> ARM: dts: Add MFC codec entry to exynos4412-origen DT file
>> ARM: dts: Add MFC codec entry to exynos4412-smdk4412 DT file
>
> Thanks Sachin. For the whole series:
>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>
Can you please review/add this patch series?
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4
2013-02-05 5:52 ` Sachin Kamat
@ 2013-02-05 6:01 ` Kukjin Kim
0 siblings, 0 replies; 14+ messages in thread
From: Kukjin Kim @ 2013-02-05 6:01 UTC (permalink / raw)
To: 'Sachin Kamat'
Cc: linux-samsung-soc, devicetree-discuss, patches,
'Sylwester Nawrocki'
Sachin Kamat wrote:
>
> Hi Kukjin,
>
> On 30 January 2013 14:30, Sylwester Nawrocki <s.nawrocki@samsung.com>
> wrote:
> > On 01/30/2013 08:11 AM, Sachin Kamat wrote:
> >> Changes since v1:
> >> Addressed comments from Sylwester
> >> - Updated documentation
> >> - Added 'status' to the nodes
> >> - Updated Kconfig entry
> >>
> >> This series is based on for-next branch of Kukjin Kim's tree.
> >> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> >> Sachin Kamat (6):
> >> ARM: dts: Update MFC DT binding documentation
> >> ARM: dts: Add MFC codec support for Exynos4 DT machines
> >> ARM: dts: Add MFC codec support to SMDKV310 DT
> >> ARM: dts: Add MFC codec support to Origen DT
> >> ARM: dts: Add MFC codec entry to exynos4412-origen DT file
> >> ARM: dts: Add MFC codec entry to exynos4412-smdk4412 DT file
> >
> > Thanks Sachin. For the whole series:
> >
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >
>
> Can you please review/add this patch series?
>
Looks good to me, applied.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines
2013-01-29 4:13 [PATCH Resend " Sachin Kamat
@ 2013-01-29 4:13 ` Sachin Kamat
2013-01-29 13:36 ` Sylwester Nawrocki
0 siblings, 1 reply; 14+ messages in thread
From: Sachin Kamat @ 2013-01-29 4:13 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: devicetree-discuss, kgene.kim, sachin.kamat, patches
This patch adds MFC codec support for Exynos4 DT machines.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos4.dtsi | 7 +++++++
arch/arm/mach-exynos/mach-exynos4-dt.c | 17 +++++++++++++++++
2 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index e1347fc..1122fb1 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -289,4 +289,11 @@
interrupts = <0 34 0>;
};
};
+
+ mfc: codec@13400000 {
+ compatible = "samsung,mfc-v5";
+ reg = <0x13400000 0x10000>;
+ interrupts = <0 94 0>;
+ samsung,power-domain = <&pd_mfc>;
+ };
};
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index ab1dacc..8ae8da1 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -12,7 +12,9 @@
*/
#include <linux/of_platform.h>
+#include <linux/of_fdt.h>
#include <linux/serial_core.h>
+#include <linux/memblock.h>
#include <asm/mach/arch.h>
#include <asm/hardware/gic.h>
@@ -20,6 +22,7 @@
#include <plat/cpu.h>
#include <plat/regs-serial.h>
+#include <plat/mfc.h>
#include "common.h"
@@ -80,6 +83,7 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL),
OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
"exynos-tmu", NULL),
+ OF_DEV_AUXDATA("samsung,mfc-v5", 0x13400000, "s5p-mfc", NULL),
{},
};
@@ -102,6 +106,18 @@ static char const *exynos4_dt_compat[] __initdata = {
NULL
};
+static void __init exynos4_reserve(void)
+{
+#ifdef CONFIG_S5P_DEV_MFC
+ struct s5p_mfc_dt_meminfo mfc_mem;
+
+ /* Reserve memory for MFC only if it's available */
+ mfc_mem.compatible = "samsung,mfc-v5";
+ if (of_scan_flat_dt(s5p_fdt_find_mfc_mem, &mfc_mem))
+ s5p_mfc_reserve_mem(mfc_mem.roff, mfc_mem.rsize, mfc_mem.loff,
+ mfc_mem.lsize);
+#endif
+}
DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device Tree)")
/* Maintainer: Thomas Abraham <thomas.abraham@linaro.org> */
.smp = smp_ops(exynos_smp_ops),
@@ -114,4 +130,5 @@ DT_MACHINE_START(EXYNOS4210_DT, "Samsung Exynos4 (Flattened Device Tree)")
.timer = &exynos4_timer,
.dt_compat = exynos4_dt_compat,
.restart = exynos4_restart,
+ .reserve = exynos4_reserve,
MACHINE_END
--
1.7.4.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines
2013-01-29 4:13 ` [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines Sachin Kamat
@ 2013-01-29 13:36 ` Sylwester Nawrocki
2013-01-30 6:00 ` Sachin Kamat
0 siblings, 1 reply; 14+ messages in thread
From: Sylwester Nawrocki @ 2013-01-29 13:36 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, patches
On 01/29/2013 05:13 AM, Sachin Kamat wrote:
> This patch adds MFC codec support for Exynos4 DT machines.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 7 +++++++
> arch/arm/mach-exynos/mach-exynos4-dt.c | 17 +++++++++++++++++
> 2 files changed, 24 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e1347fc..1122fb1 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -289,4 +289,11 @@
> interrupts = <0 34 0>;
> };
> };
> +
> + mfc: codec@13400000 {
> + compatible = "samsung,mfc-v5";
> + reg = <0x13400000 0x10000>;
> + interrupts = <0 94 0>;
> + samsung,power-domain = <&pd_mfc>;
Please add:
status = "disabled";
> + };
> };
> diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
> index ab1dacc..8ae8da1 100644
> --- a/arch/arm/mach-exynos/mach-exynos4-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
> @@ -12,7 +12,9 @@
> */
>
> #include <linux/of_platform.h>
> +#include <linux/of_fdt.h>
> #include <linux/serial_core.h>
> +#include <linux/memblock.h>
>
> #include <asm/mach/arch.h>
> #include <asm/hardware/gic.h>
> @@ -20,6 +22,7 @@
>
> #include <plat/cpu.h>
> #include <plat/regs-serial.h>
> +#include <plat/mfc.h>
>
> #include "common.h"
>
> @@ -80,6 +83,7 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[] __initconst = {
> OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_MDMA1, "dma-pl330.2", NULL),
> OF_DEV_AUXDATA("samsung,exynos4210-tmu", EXYNOS4_PA_TMU,
> "exynos-tmu", NULL),
> + OF_DEV_AUXDATA("samsung,mfc-v5", 0x13400000, "s5p-mfc", NULL),
> {},
> };
>
> @@ -102,6 +106,18 @@ static char const *exynos4_dt_compat[] __initdata = {
> NULL
> };
>
> +static void __init exynos4_reserve(void)
> +{
> +#ifdef CONFIG_S5P_DEV_MFC
Where is this symbol supposed to be enabled ?
Don't you need a change like this as a part of this patch ?
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 1d9312a..1ae72d9 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -413,6 +413,7 @@ config MACH_EXYNOS4_DT
select USE_OF
select EXYNOS4_SETUP_USB_PHY
select ARM_DMA_USE_IOMMU if EXYNOS_IOMMU
+ select S5P_DEV_MFC
help
Machine support for Samsung Exynos4 machine with device tree enabled.
Select this if a fdt blob is available for the Exynos4 SoC based board.
--
Thanks,
Sylwester
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/6] ARM: dts: Add MFC codec support for Exynos4 DT machines
2013-01-29 13:36 ` Sylwester Nawrocki
@ 2013-01-30 6:00 ` Sachin Kamat
0 siblings, 0 replies; 14+ messages in thread
From: Sachin Kamat @ 2013-01-30 6:00 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-samsung-soc, devicetree-discuss, kgene.kim, patches
Hi Sylwester,
>> + mfc: codec@13400000 {
>> + compatible = "samsung,mfc-v5";
>> + reg = <0x13400000 0x10000>;
>> + interrupts = <0 94 0>;
>> + samsung,power-domain = <&pd_mfc>;
>
> Please add:
> status = "disabled";
OK
>
>> + };
>> };
>> +static void __init exynos4_reserve(void)
>> +{
>> +#ifdef CONFIG_S5P_DEV_MFC
>
> Where is this symbol supposed to be enabled ?
>
> Don't you need a change like this as a part of this patch ?
Yes. Good catch. Since this symbol was defined under other machines
which were getting enabled, I did not notice this.
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 14+ messages in thread