* [PATCH v3 0/2] Add support for Xiaomi Poco F1 EBBG variant
@ 2022-08-06 21:02 Joel Selvaraj
2022-08-06 21:02 ` [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts Joel Selvaraj
2022-08-06 21:02 ` [PATCH v3 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco F1 EBBG variant Joel Selvaraj
0 siblings, 2 replies; 6+ messages in thread
From: Joel Selvaraj @ 2022-08-06 21:02 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Joel Selvaraj
There are two variants of Xiaomi Poco F1.
- Tianma variant with NOVATEK NT36672A panel + touchscreen manufactured
by Tianma
- EBBG variant with Focaltech FT8719 panel + touchscreen manufactured
by EBBG
The current sdm845-xiaomi-beryllium.dts represents Tianma panel variant.
To add support for the EBBG variant,
In the PATCH 1/2, let's
-----------------------
- Rename sdm845-xiaomi-beryllium.dts to sdm845-xiaomi-beryllium-common.dtsi
- Generalize the display panel node by assigning label, removing
compatible property and renaming the panel endpoints to be generic.
- Create a dts for the Tianma variant called
sdm845-xiaomi-beryllium-tianma.dts which will inherit the common dtsi and
set the compatible property for the respective display panel.
- Adjust the Makefile since the sdm845-xiaomi-beryllium.dts is now called
sdm845-xiaomi-beryllium-tianma.dts for the tianma variant.
In the PATCH 2/2, let's
-----------------------
- Create sdm845-xiaomi-beryllium-ebbg.dts for the EBBG variant which will
inherit the common dtsi and set the compatible property for the respective
display panel.
Changes in v3:
--------------
- Approach suggested by Marijn Suijten and Krzysztof Kozlowski to make
git handle renames more appropriately and to avoid moving large chunks of
code. Helps with reviewing the patch.
Changes in v2:
--------------
- Fix issue with builds breaking across multiple commits making git bisect
harder to find where the rename has happened.
Note:
-----
Both the panels are already upstreamed and the split is based on them.
There were patches earlier for both the touchscreens, but they are not
accepted in upstream yet. Once they are accepted, we will add them to
respective variants.
Joel Selvaraj (2):
arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts
arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco
F1 EBBG variant
arch/arm64/boot/dts/qcom/Makefile | 3 ++-
...ryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} | 9 +++++----
.../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 10 ++++++++++
.../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 10 ++++++++++
4 files changed, 27 insertions(+), 5 deletions(-)
rename arch/arm64/boot/dts/qcom/{sdm845-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} (98%)
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
--
2.37.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts
2022-08-06 21:02 [PATCH v3 0/2] Add support for Xiaomi Poco F1 EBBG variant Joel Selvaraj
@ 2022-08-06 21:02 ` Joel Selvaraj
2022-08-08 6:32 ` Krzysztof Kozlowski
2022-08-08 13:12 ` Marijn Suijten
2022-08-06 21:02 ` [PATCH v3 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco F1 EBBG variant Joel Selvaraj
1 sibling, 2 replies; 6+ messages in thread
From: Joel Selvaraj @ 2022-08-06 21:02 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Joel Selvaraj
There are two panel variants of Xiaomi Poco F1. Tianma and EBBG panel.
The previous beryllium dts supported the Tianma variant. In order to
add support for EBBG variant, the common nodes from beryllium dts are
moved to a new common dtsi and to make the variants distinguishable,
sdm845-xiaomi-beryllium.dts is now named as
sdm845-xiaomi-beryllium-tianma.dts
Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
---
arch/arm64/boot/dts/qcom/Makefile | 2 +-
...ryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} | 9 +++++----
.../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 10 ++++++++++
3 files changed, 16 insertions(+), 5 deletions(-)
rename arch/arm64/boot/dts/qcom/{sdm845-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} (98%)
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 2f8aec2cc6db..02db413b228c 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -106,7 +106,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akari.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akatsuki.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-apollo.dtb
-dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium-tianma.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-shift-axolotl.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm850-samsung-w737.dtb
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
similarity index 98%
rename from arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
rename to arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index d88dc07205f7..83edcb1171f5 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -221,8 +221,7 @@ &dsi0 {
status = "okay";
vdda-supply = <&vreg_l26a_1p2>;
- panel@0 {
- compatible = "tianma,fhd-video";
+ display_panel: panel@0 {
reg = <0>;
vddio-supply = <&vreg_l14a_1p8>;
vddpos-supply = <&lab>;
@@ -234,8 +233,10 @@ panel@0 {
backlight = <&pmi8998_wled>;
reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+ status = "disabled";
+
port {
- tianma_nt36672a_in_0: endpoint {
+ panel_in_0: endpoint {
remote-endpoint = <&dsi0_out>;
};
};
@@ -243,7 +244,7 @@ tianma_nt36672a_in_0: endpoint {
};
&dsi0_out {
- remote-endpoint = <&tianma_nt36672a_in_0>;
+ remote-endpoint = <&panel_in_0>;
data-lanes = <0 1 2 3>;
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
new file mode 100644
index 000000000000..fcbef5ad2909
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/dts-v1/;
+
+#include "sdm845-xiaomi-beryllium-common.dtsi"
+
+&display_panel {
+ compatible = "tianma,fhd-video";
+ status = "okay";
+};
--
2.37.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts
2022-08-06 21:02 ` [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts Joel Selvaraj
@ 2022-08-08 6:32 ` Krzysztof Kozlowski
2022-08-08 13:12 ` Marijn Suijten
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-08 6:32 UTC (permalink / raw)
To: Joel Selvaraj, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 06/08/2022 23:02, Joel Selvaraj wrote:
> There are two panel variants of Xiaomi Poco F1. Tianma and EBBG panel.
> The previous beryllium dts supported the Tianma variant. In order to
> add support for EBBG variant, the common nodes from beryllium dts are
> moved to a new common dtsi and to make the variants distinguishable,
> sdm845-xiaomi-beryllium.dts is now named as
> sdm845-xiaomi-beryllium-tianma.dts
>
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 2 +-
> ...ryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} | 9 +++++----
> .../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 10 ++++++++++
> 3 files changed, 16 insertions(+), 5 deletions(-)
> rename arch/arm64/boot/dts/qcom/{sdm845-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} (98%)
> create mode 100644 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 2f8aec2cc6db..02db413b228c 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -106,7 +106,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akari.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akatsuki.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-apollo.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium-tianma.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-shift-axolotl.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm850-samsung-w737.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> similarity index 98%
> rename from arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> rename to arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index d88dc07205f7..83edcb1171f5 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -221,8 +221,7 @@ &dsi0 {
> status = "okay";
> vdda-supply = <&vreg_l26a_1p2>;
>
> - panel@0 {
> - compatible = "tianma,fhd-video";
> + display_panel: panel@0 {
> reg = <0>;
> vddio-supply = <&vreg_l14a_1p8>;
> vddpos-supply = <&lab>;
> @@ -234,8 +233,10 @@ panel@0 {
> backlight = <&pmi8998_wled>;
> reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
>
> + status = "disabled";
> +
> port {
> - tianma_nt36672a_in_0: endpoint {
> + panel_in_0: endpoint {
> remote-endpoint = <&dsi0_out>;
> };
> };
> @@ -243,7 +244,7 @@ tianma_nt36672a_in_0: endpoint {
> };
>
> &dsi0_out {
> - remote-endpoint = <&tianma_nt36672a_in_0>;
> + remote-endpoint = <&panel_in_0>;
> data-lanes = <0 1 2 3>;
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
> new file mode 100644
> index 000000000000..fcbef5ad2909
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
> @@ -0,0 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +/dts-v1/;
> +
> +#include "sdm845-xiaomi-beryllium-common.dtsi"
Nice diff.
However what happened to compatibles? Why do you have now two boards
with same compatible and model name?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts
2022-08-06 21:02 ` [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts Joel Selvaraj
2022-08-08 6:32 ` Krzysztof Kozlowski
@ 2022-08-08 13:12 ` Marijn Suijten
1 sibling, 0 replies; 6+ messages in thread
From: Marijn Suijten @ 2022-08-08 13:12 UTC (permalink / raw)
To: Joel Selvaraj
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 2022-08-07 02:32:19, Joel Selvaraj wrote:
> There are two panel variants of Xiaomi Poco F1. Tianma and EBBG panel.
> The previous beryllium dts supported the Tianma variant. In order to
> add support for EBBG variant, the common nodes from beryllium dts are
> moved to a new common dtsi and to make the variants distinguishable,
> sdm845-xiaomi-beryllium.dts is now named as
> sdm845-xiaomi-beryllium-tianma.dts
>
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
Nice, this is much more concise now and keeps the tree compiling _with
this dts_ at all times, at the detriment of stuffing "many" changes in a
single patch which is fine here, IMO.
I just hope users of this dtb notice the name changed (unless
unreferenced dtbs get cleaned after a dirty-rebuild) when their scripts
are inevitably hardcoded to take this specificly named dtb to flash to
the(ir) phone.
After giving both DTs a unique compatible as pointed out by Krzysztof,
please add my:
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 2 +-
> ...ryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} | 9 +++++----
> .../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 10 ++++++++++
> 3 files changed, 16 insertions(+), 5 deletions(-)
> rename arch/arm64/boot/dts/qcom/{sdm845-xiaomi-beryllium.dts => sdm845-xiaomi-beryllium-common.dtsi} (98%)
> create mode 100644 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 2f8aec2cc6db..02db413b228c 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -106,7 +106,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akari.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akatsuki.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-apollo.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium-tianma.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-shift-axolotl.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm850-samsung-w737.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> similarity index 98%
> rename from arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> rename to arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> index d88dc07205f7..83edcb1171f5 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
> @@ -221,8 +221,7 @@ &dsi0 {
> status = "okay";
> vdda-supply = <&vreg_l26a_1p2>;
>
> - panel@0 {
> - compatible = "tianma,fhd-video";
> + display_panel: panel@0 {
> reg = <0>;
> vddio-supply = <&vreg_l14a_1p8>;
> vddpos-supply = <&lab>;
> @@ -234,8 +233,10 @@ panel@0 {
> backlight = <&pmi8998_wled>;
> reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
>
> + status = "disabled";
> +
> port {
> - tianma_nt36672a_in_0: endpoint {
> + panel_in_0: endpoint {
> remote-endpoint = <&dsi0_out>;
> };
> };
> @@ -243,7 +244,7 @@ tianma_nt36672a_in_0: endpoint {
> };
>
> &dsi0_out {
> - remote-endpoint = <&tianma_nt36672a_in_0>;
> + remote-endpoint = <&panel_in_0>;
> data-lanes = <0 1 2 3>;
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
> new file mode 100644
> index 000000000000..fcbef5ad2909
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts
> @@ -0,0 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +/dts-v1/;
> +
> +#include "sdm845-xiaomi-beryllium-common.dtsi"
> +
> +&display_panel {
> + compatible = "tianma,fhd-video";
> + status = "okay";
> +};
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco F1 EBBG variant
2022-08-06 21:02 [PATCH v3 0/2] Add support for Xiaomi Poco F1 EBBG variant Joel Selvaraj
2022-08-06 21:02 ` [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts Joel Selvaraj
@ 2022-08-06 21:02 ` Joel Selvaraj
2022-08-08 13:16 ` Marijn Suijten
1 sibling, 1 reply; 6+ messages in thread
From: Joel Selvaraj @ 2022-08-06 21:02 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel, Joel Selvaraj
Introduce support for the Xiaomi Poco F1 EBBG variant. The EBBG variant
uses EBBG FT8719 panel manufactured by EBBG.
Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 10 ++++++++++
2 files changed, 11 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 02db413b228c..29f15031a199 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -106,6 +106,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akari.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akatsuki.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-apollo.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium-ebbg.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium-tianma.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-shift-axolotl.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
new file mode 100644
index 000000000000..1e0be481b9da
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
+
+/dts-v1/;
+
+#include "sdm845-xiaomi-beryllium-common.dtsi"
+
+&display_panel {
+ compatible = "ebbg,ft8719";
+ status = "okay";
+};
--
2.37.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco F1 EBBG variant
2022-08-06 21:02 ` [PATCH v3 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco F1 EBBG variant Joel Selvaraj
@ 2022-08-08 13:16 ` Marijn Suijten
0 siblings, 0 replies; 6+ messages in thread
From: Marijn Suijten @ 2022-08-08 13:16 UTC (permalink / raw)
To: Joel Selvaraj
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel,
~postmarketos/upstreaming, phone-devel
On 2022-08-07 02:32:20, Joel Selvaraj wrote:
> Introduce support for the Xiaomi Poco F1 EBBG variant. The EBBG variant
> uses EBBG FT8719 panel manufactured by EBBG.
>
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
Also after adding a distinct compatible to the new board file:
Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> .../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 10 ++++++++++
> 2 files changed, 11 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 02db413b228c..29f15031a199 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -106,6 +106,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-oneplus-fajita.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akari.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-akatsuki.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-sony-xperia-tama-apollo.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium-ebbg.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium-tianma.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm845-shift-axolotl.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
> new file mode 100644
> index 000000000000..1e0be481b9da
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts
> @@ -0,0 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +/dts-v1/;
> +
> +#include "sdm845-xiaomi-beryllium-common.dtsi"
> +
> +&display_panel {
> + compatible = "ebbg,ft8719";
> + status = "okay";
> +};
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-08 13:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-06 21:02 [PATCH v3 0/2] Add support for Xiaomi Poco F1 EBBG variant Joel Selvaraj
2022-08-06 21:02 ` [PATCH v3 1/2] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts Joel Selvaraj
2022-08-08 6:32 ` Krzysztof Kozlowski
2022-08-08 13:12 ` Marijn Suijten
2022-08-06 21:02 ` [PATCH v3 2/2] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco F1 EBBG variant Joel Selvaraj
2022-08-08 13:16 ` Marijn Suijten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).