Re: [PATCH v1 1/2] dt-bindings: hwmon: ina2xx: add supply property

Krzysztof Kozlowski
2023-03-08T13:16:44Z

On 08/03/2023 13:58, Svyatoslav Ryhel wrote:
>
>
> 8 березня 2023 р. 14:54:34 GMT+02:00, Mark Brown <broonie@kernel.org> написав(-ла):
>> On Wed, Mar 08, 2023 at 11:40:23AM +0200, Svyatoslav Ryhel wrote:
>>> Add supply property.
>>
>>> + vdd-supply: true
>>> +
>>> required:
>>> - compatible
>>> - reg
>>
>> Unless the device can work without power the supply should be required.
>
> Device can work without supply defined on most devices,

Are you sure they can work without any power? INA231 does not say VS
supply is optional. Datasheet says:
"The INA231 is typically powered by a separate supply that can range
from 2.7 V to 5.5 V."

Although it uses word "typically" which could suggest other design, but
are you sure it can work without it? From where it gets the power?

> but in my case power is gated with gpio and devices will not work
without fixed regulator.

BTW, wrap your lines to match mailing list style.

Best regards,
Krzysztof