From: Andreas Larsson <andreas@gaisler.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, software@gaisler.com
Subject: [PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion
Date: Tue, 5 Feb 2013 11:33:02 +0100 [thread overview]
Message-ID: <1360060383-16880-2-git-send-email-andreas@gaisler.com> (raw)
In-Reply-To: <1360060383-16880-1-git-send-email-andreas@gaisler.com>
The swap to convert LE to BE in bgpio_pin2mask_be should be on byte level, not
on bit level.
Signed-off-by: Andreas Larsson <andreas@gaisler.com>
---
drivers/gpio/gpio-generic.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c
index 05fcc0f..7f11537 100644
--- a/drivers/gpio/gpio-generic.c
+++ b/drivers/gpio/gpio-generic.c
@@ -112,7 +112,10 @@ static unsigned long bgpio_pin2mask(struct bgpio_chip *bgc, unsigned int pin)
static unsigned long bgpio_pin2mask_be(struct bgpio_chip *bgc,
unsigned int pin)
{
- return 1 << (bgc->bits - 1 - pin);
+ unsigned int bit = pin & 0x7; /* Bit number within byte */
+ unsigned int base = pin - bit; /* Pin that is bit 0 within byte */
+
+ return 1 << ((bgc->bits - base - 8) + bit); /* shifted base + bit */
}
static int bgpio_get(struct gpio_chip *gc, unsigned int gpio)
--
1.7.0.4
next prev parent reply other threads:[~2013-02-05 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 10:33 [PATCH 0/2] gpio: Fix gpio-generic bug and add driver for GRGPIO cores Andreas Larsson
2013-02-05 10:33 ` Andreas Larsson [this message]
2013-02-09 14:58 ` [PATCH 1/2] gpio: gpio-generic: Fix bug in big endian bit conversion Grant Likely
2013-02-26 7:52 ` Grant Likely
2013-02-26 10:46 ` Andreas Larsson
2013-02-26 12:17 ` Andreas Larsson
2013-03-02 9:16 ` Grant Likely
2013-02-05 10:33 ` [PATCH 2/2] gpio: Add device driver for GRGPIO cores Andreas Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360060383-16880-2-git-send-email-andreas@gaisler.com \
--to=andreas@gaisler.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=software@gaisler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).