From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Andy Shevchenko
<andriy.shevchenko-b5Z7lJ3WibVrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH] of: dma: protect list write operation by spin_lock
Date: Wed, 13 Feb 2013 09:48:29 +0200 [thread overview]
Message-ID: <1360741709.14581.20.camel@smile> (raw)
In-Reply-To: <20130212172027.GT3789-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tue, 2013-02-12 at 09:20 -0800, Vinod Koul wrote:
> On Tue, Jan 29, 2013 at 09:36:45AM -0600, Rob Herring wrote:
> > >> Vinod, it's probably better to move drivers/of/dma.c to drivers/dma.
> > >> That's been the direction we've been taking with new OF binding code. I
> > >> must have missed that in the review.
> > > ok, do you have any patches on your tree for this if not then I can update my tree
> > > for this change and then we can apply changes thru slave-dma tree.
> >
> > No, I don't have one prepared.
> Okay, I have committed and pushed drivers/of/dma.c to be moved to
> drivers/dma/of-dma.c
>
> From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Date: Tue, 12 Feb 2013 09:15:02 -0800
> Subject: [PATCH] dmaengine: move drivers/of/dma.c -> drivers/dma/of-dma.c
>
> as requested by Rob
>
> Suggested-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/{of/dma.c => dma/of-dma.c} | 0
> 1 files changed, 0 insertions(+), 0 deletions(-)
> rename drivers/{of/dma.c => dma/of-dma.c} (100%)
>
What about Kconfig(s) / Makefile(s)?
And I think the of_dma.c looks better as a name of the file.
> diff --git a/drivers/of/dma.c b/drivers/dma/of-dma.c
> similarity index 100%
> rename from drivers/of/dma.c
> rename to drivers/dma/of-dma.c
> --
> 1.7.0.4
>
> Anyone cares to Ack?
>
> --
> ~Vinod
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
next prev parent reply other threads:[~2013-02-13 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 15:24 [PATCH] of: dma: protect list write operation by spin_lock Andy Shevchenko
[not found] ` <1359386694-20548-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-01-28 15:52 ` Rob Herring
[not found] ` <51069EA0.4040004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-28 16:07 ` Vinod Koul
[not found] ` <20130128160757.GA6396-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-29 15:36 ` Rob Herring
[not found] ` <5107EC8D.5070001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-02-12 17:20 ` Vinod Koul
[not found] ` <20130212172027.GT3789-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-13 7:48 ` Andy Shevchenko [this message]
2013-02-13 10:48 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360741709.14581.20.camel@smile \
--to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=andriy.shevchenko-b5Z7lJ3WibVrdx17CPfAsdBPR1lH4CV8@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).