[PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sachin Kamat]

Added documentaion about G2D bindings.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 .../devicetree/bindings/gpu/samsung-g2d.txt        |   30 ++++++++++++++++++++
 1 files changed, 30 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt

diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
new file mode 100644
index 0000000..838b26b
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
@@ -0,0 +1,30 @@
+* Samsung 2D Graphics Accelerator
+
+Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer.
+We set the drawing-context registers for configuring the rendering parameters
+and then start rendering.
+The G2D has V4L2 as well as DRM framework based driver support.
+
+Required properties:
+  - compatible : value should be one among the following
+	(a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 SoC
+	(b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
+	(b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
+
+  - reg : Physical base address of the IP registers and length of memory
+	  mapped region.
+
+  - interrupts : G2D interrupt number to the CPU.
+
+Optional properties:
+  - samsung,power-domain : power-domain property defined with a phandle
+			   to respective power domain.
+
+Example:
+	g2d@12800000 {
+		compatible = "samsung,s5pv210-g2d";
+		reg = <0x12800000 0x1000>;
+		interrupts = <0 89 0>;
+		samsung,power-domain = <&pd_lcd0>;
+		status = "disabled";
+	};
-- 
1.7.4.1

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sylwester Nawrocki]

On 02/06/2013 12:51 PM, Sachin Kamat wrote:
> Added documentaion about G2D bindings.

s/documentaion/documentation

> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
>   .../devicetree/bindings/gpu/samsung-g2d.txt        |   30 ++++++++++++++++++++
>   1 files changed, 30 insertions(+), 0 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> new file mode 100644
> index 0000000..838b26b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> @@ -0,0 +1,30 @@
> +* Samsung 2D Graphics Accelerator
> +

> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer.
> +We set the drawing-context registers for configuring the rendering parameters
> +and then start rendering.
> +The G2D has V4L2 as well as DRM framework based driver support.

IMHO this whole paragraph is irrelevant and could be dropped.

> +Required properties:
> +  - compatible : value should be one among the following

missing colon at the end of line ?

> +	(a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210&  Exynos4210 SoC
> +	(b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
> +	(b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC

s/(b)/(c)

> +
> +  - reg : Physical base address of the IP registers and length of memory
> +	  mapped region.
> +
> +  - interrupts : G2D interrupt number to the CPU.
> +
> +Optional properties:
> +  - samsung,power-domain : power-domain property defined with a phandle
> +			   to respective power domain.
> +
> +Example:
> +	g2d@12800000 {
> +		compatible = "samsung,s5pv210-g2d";
> +		reg =<0x12800000 0x1000>;
> +		interrupts =<0 89 0>;
> +		samsung,power-domain =<&pd_lcd0>;
> +		status = "disabled";
> +	};

Otherwise looks good to me.

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Tomasz Figa]

Hi Sachin,

On Wednesday 06 of February 2013 17:21:17 Sachin Kamat wrote:
> Added documentaion about G2D bindings.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  .../devicetree/bindings/gpu/samsung-g2d.txt        |   30
> ++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-)
>  create mode 100644
> Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt new file mode
> 100644
> index 0000000..838b26b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
> @@ -0,0 +1,30 @@
> +* Samsung 2D Graphics Accelerator
> +
> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block
> Transfer. +We set the drawing-context registers for configuring the
> rendering parameters +and then start rendering.
> +The G2D has V4L2 as well as DRM framework based driver support.
> +
> +Required properties:
> +  - compatible : value should be one among the following
> +	(a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210
> SoC +	(b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12
> SoCs +	(b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250
> SoC +
> +  - reg : Physical base address of the IP registers and length of
> memory +	  mapped region.
> +
> +  - interrupts : G2D interrupt number to the CPU.
> +
> +Optional properties:
> +  - samsung,power-domain : power-domain property defined with a phandle
> +			   to respective power domain.

I'm not sure if samsung,power-domain should be mentioned in this 
documentation file. The driver itself does not use this property.

Otherwise looks fine.

Best regards,
Tomasz

> +
> +Example:
> +	g2d@12800000 {
> +		compatible = "samsung,s5pv210-g2d";
> +		reg = <0x12800000 0x1000>;
> +		interrupts = <0 89 0>;
> +		samsung,power-domain = <&pd_lcd0>;
> +		status = "disabled";
> +	};

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sachin Kamat]

[-- Attachment #1.1: Type: text/plain, Size: 2474 bytes --]

On Thursday, 14 February 2013, Sylwester Nawrocki <
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 02/06/2013 12:51 PM, Sachin Kamat wrote:
>>
>> Added documentaion about G2D bindings.
>
> s/documentaion/documentation

Ok.
>
>> Signed-off-by: Sachin Kamat<sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>   .../devicetree/bindings/gpu/samsung-g2d.txt        |   30
++++++++++++++++++++
>>   1 files changed, 30 insertions(+), 0 deletions(-)
>>   create mode 100644
Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> new file mode 100644
>> index 0000000..838b26b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> @@ -0,0 +1,30 @@
>> +* Samsung 2D Graphics Accelerator
>> +
>
>> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block
Transfer.
>> +We set the drawing-context registers for configuring the rendering
parameters
>> +and then start rendering.
>> +The G2D has V4L2 as well as DRM framework based driver support.
>
> IMHO this whole paragraph is irrelevant and could be dropped.

Ok. Had formatted this based on mfc document.
>
>> +Required properties:
>> +  - compatible : value should be one among the following
>
> missing colon at the end of line ?

Hmm. I think so.

>
>> +       (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210&
 Exynos4210 SoC
>> +       (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12
SoCs
>> +       (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
>
> s/(b)/(c)

Yes, copy paste error :)

>
>> +
>> +  - reg : Physical base address of the IP registers and length of memory
>> +         mapped region.
>> +
>> +  - interrupts : G2D interrupt number to the CPU.
>> +
>> +Optional properties:
>> +  - samsung,power-domain : power-domain property defined with a phandle
>> +                          to respective power domain.
>> +
>> +Example:
>> +       g2d@12800000 {
>> +               compatible = "samsung,s5pv210-g2d";
>> +               reg =<0x12800000 0x1000>;
>> +               interrupts =<0 89 0>;
>> +               samsung,power-domain =<&pd_lcd0>;
>> +               status = "disabled";
>> +       };
>
> Otherwise looks good to me.

Thanks for reviewing. Does the filename look good or should it be
exynos-g2d?

Regards,
Sachin.

-- 
With warm regards,
Sachin

[-- Attachment #1.2: Type: text/html, Size: 3312 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sachin Kamat]

[-- Attachment #1.1: Type: text/plain, Size: 2589 bytes --]

Hi Tomasz,

On Thursday, 14 February 2013, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hi Sachin,
>
> On Wednesday 06 of February 2013 17:21:17 Sachin Kamat wrote:
>> Added documentaion about G2D bindings.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>  .../devicetree/bindings/gpu/samsung-g2d.txt        |   30
>> ++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-)
>>  create mode 100644
>> Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt new file mode
>> 100644
>> index 0000000..838b26b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> @@ -0,0 +1,30 @@
>> +* Samsung 2D Graphics Accelerator
>> +
>> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block
>> Transfer. +We set the drawing-context registers for configuring the
>> rendering parameters +and then start rendering.
>> +The G2D has V4L2 as well as DRM framework based driver support.
>> +
>> +Required properties:
>> +  - compatible : value should be one among the following
>> +     (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 &
Exynos4210
>> SoC + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12
>> SoCs +        (b) "samsung,exynos5250-g2d" for G2D IP present in
Exynos5250
>> SoC +
>> +  - reg : Physical base address of the IP registers and length of
>> memory +        mapped region.
>> +
>> +  - interrupts : G2D interrupt number to the CPU.
>> +
>> +Optional properties:
>> +  - samsung,power-domain : power-domain property defined with a phandle
>> +                        to respective power domain.
>
> I'm not sure if samsung,power-domain should be mentioned in this
> documentation file. The driver itself does not use this property.

Oh ok. I will check this again and remove if unnecessary.

>
> Otherwise looks fine.
>
> Best regards,
> Tomasz
>
>> +
>> +Example:
>> +     g2d@12800000 {
>> +             compatible = "samsung,s5pv210-g2d";
>> +             reg = <0x12800000 0x1000>;
>> +             interrupts = <0 89 0>;
>> +             samsung,power-domain = <&pd_lcd0>;
>> +             status = "disabled";
>> +     };
> --
> To unsubscribe from this list: send the line "unsubscribe
linux-samsung-soc" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
With warm regards,
Sachin

[-- Attachment #1.2: Type: text/html, Size: 3560 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sylwester Nawrocki]

On 02/14/2013 04:45 PM, Sachin Kamat wrote:
> Thanks for reviewing. Does the filename look good or should it be exynos-g2d?

You're welcome. My apologies for being a bit late.
I guess exynos-g2d.txt would be more appropriate. OTOH if this document is
going to cover all Samsung G2D IP blocks then current name might be better.
I used samsung- prefix for fimc and mipi-csis as those documents are supposed
to cover the S5P and Exynos4 SoCs.

[PATCH v2 0/7] Add G2D nodes to Exynos4 machines

[Sachin Kamat]

This patch series is based on Kukjin Kim's next/dt-exynos branch of
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
tree.

Changes since v1:
* Removed power-domain entry in patch 1/7 as the driver currently
  does not use it.
* Addressed review comments from Sylwester Nawrocki and Tomasz Figa
  in patch 7/7.

Sachin Kamat (7):
  ARM: dts: Add G2D node to exynos4210.dtsi
  ARM: dts: Add G2D node to SMDKV310
  ARM: dts: Add G2D node to exynos4210-origen
  ARM: dts: Add G2D node to exynos4x12.dtsi
  ARM: dts: Add G2D node to SMDK4412
  ARM: dts: Add G2D node to exynos4412-origen
  ARM: dts: Add Samsung G2D DT bindings documentation

 .../devicetree/bindings/gpu/samsung-g2d.txt        |   20 ++++++++++++++++++++
 arch/arm/boot/dts/exynos4210-origen.dts            |    4 ++++
 arch/arm/boot/dts/exynos4210-smdkv310.dts          |    4 ++++
 arch/arm/boot/dts/exynos4210.dtsi                  |    7 +++++++
 arch/arm/boot/dts/exynos4412-smdk4412.dts          |    8 ++++++++
 arch/arm/boot/dts/exynos4x12.dtsi                  |    7 +++++++
 6 files changed, 50 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt

-- 
1.7.4.1

[PATCH 1/7] ARM: dts: Add G2D node to exynos4210.dtsi

[Sachin Kamat]

Added G2D DT node to Exynos4210.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4210.dtsi |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index e31bfc4..19aa167 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -47,6 +47,13 @@
 			     <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>;
 	};
 
+	g2d@12800000 {
+		compatible = "samsung,s5pv210-g2d";
+		reg = <0x12800000 0x1000>;
+		interrupts = <0 89 0>;
+		status = "disabled";
+	};
+
 	pinctrl_0: pinctrl@11400000 {
 		compatible = "samsung,pinctrl-exynos4210";
 		reg = <0x11400000 0x1000>;
-- 
1.7.4.1

[PATCH 2/7] ARM: dts: Add G2D node to SMDKV310

[Sachin Kamat]

Added G2D DT node to SMDKV310 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4210-smdkv310.dts |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index 2b1e03a..7bb16aa 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -43,6 +43,10 @@
 		status = "okay";
 	};
 
+	g2d@12800000 {
+		status = "okay";
+	};
+
 	codec@13400000 {
 		samsung,mfc-r = <0x43000000 0x800000>;
 		samsung,mfc-l = <0x51000000 0x800000>;
-- 
1.7.4.1

[PATCH 3/7] ARM: dts: Add G2D node to exynos4210-origen

[Sachin Kamat]

Added G2D DT node to Origen4210 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4210-origen.dts |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 052606b..e081d89 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -57,6 +57,10 @@
 		status = "okay";
 	};
 
+	g2d@12800000 {
+		status = "okay";
+	};
+
 	codec@13400000 {
 		samsung,mfc-r = <0x43000000 0x800000>;
 		samsung,mfc-l = <0x51000000 0x800000>;
-- 
1.7.4.1

[PATCH 4/7] ARM: dts: Add G2D node to exynos4x12.dtsi

[Sachin Kamat]

Added G2D DT node to exynos4x12.dtsi file.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4x12.dtsi |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 179a62e..3721eec 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -36,6 +36,13 @@
 			     <0 16 0>, <0 17 0>, <0 18 0>, <0 19 0>;
 	};
 
+	g2d@10800000 {
+		compatible = "samsung,exynos4212-g2d";
+		reg = <0x10800000 0x1000>;
+		interrupts = <0 89 0>;
+		status = "disabled";
+	};
+
 	pinctrl_0: pinctrl@11400000 {
 		compatible = "samsung,pinctrl-exynos4x12";
 		reg = <0x11400000 0x1000>;
-- 
1.7.4.1

[PATCH 5/7] ARM: dts: Add G2D node to SMDK4412

[Sachin Kamat]

Added G2D DT node to SMDK4412 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4412-smdk4412.dts |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index 6ae4276..bba53a8 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -27,6 +27,10 @@
 		bootargs ="root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC1,115200 init=/linuxrc";
 	};
 
+	g2d@10800000 {
+		status = "okay";
+	};
+
 	sdhci@12530000 {
 		bus-width = <4>;
 		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
-- 
1.7.4.1

[PATCH 6/7] ARM: dts: Add G2D node to exynos4412-origen

[Sachin Kamat]

Added G2D DT node to Origen4412 board.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 arch/arm/boot/dts/exynos4412-smdk4412.dts |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts b/arch/arm/boot/dts/exynos4412-smdk4412.dts
index bba53a8..539670b 100644
--- a/arch/arm/boot/dts/exynos4412-smdk4412.dts
+++ b/arch/arm/boot/dts/exynos4412-smdk4412.dts
@@ -31,6 +31,10 @@
 		status = "okay";
 	};
 
+	g2d@10800000 {
+		status = "okay";
+	};
+
 	sdhci@12530000 {
 		bus-width = <4>;
 		pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
-- 
1.7.4.1

[PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sachin Kamat]

Added documentaion about G2D bindings.

Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 .../devicetree/bindings/gpu/samsung-g2d.txt        |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt

diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
new file mode 100644
index 0000000..2b14a94
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
@@ -0,0 +1,20 @@
+* Samsung 2D Graphics Accelerator
+
+Required properties:
+  - compatible : value should be one among the following:
+	(a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 SoC
+	(b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs
+	(c) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
+
+  - reg : Physical base address of the IP registers and length of memory
+	  mapped region.
+
+  - interrupts : G2D interrupt number to the CPU.
+
+Example:
+	g2d@12800000 {
+		compatible = "samsung,s5pv210-g2d";
+		reg = <0x12800000 0x1000>;
+		interrupts = <0 89 0>;
+		status = "disabled";
+	};
-- 
1.7.4.1

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sachin Kamat]

Hi Sylwester,

On 14 February 2013 21:31, Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> On 02/14/2013 04:45 PM, Sachin Kamat wrote:
>> Thanks for reviewing. Does the filename look good or should it be exynos-g2d?
>
> You're welcome. My apologies for being a bit late.
> I guess exynos-g2d.txt would be more appropriate. OTOH if this document is
> going to cover all Samsung G2D IP blocks then current name might be better.
> I used samsung- prefix for fimc and mipi-csis as those documents are supposed
> to cover the S5P and Exynos4 SoCs.
>

I have retained the filename as it was since it addresses both S5P as
well as Exynos IPs.
Thanks for the tip.
I have resent this series with your other comments addressed.

-- 
With warm regards,
Sachin

Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sachin Kamat]

Hi Tomasz,

>>> +Optional properties:
>>> +  - samsung,power-domain : power-domain property defined with a phandle
>>> +                        to respective power domain.
>>
>> I'm not sure if samsung,power-domain should be mentioned in this
>> documentation file. The driver itself does not use this property.
>
> Oh ok. I will check this again and remove if unnecessary.

The driver does not use power-domain property for now and hence I have
removed this in V2.
Thanks for pointing out.

-- 
With warm regards,
Sachin

Re: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

[Sachin Kamat]

Hi Kukjin,

Can you please look into this series as it is pending since quite some time.

On 18 February 2013 10:32, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> This patch series is based on Kukjin Kim's next/dt-exynos branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> tree.
>
> Changes since v1:
> * Removed power-domain entry in patch 1/7 as the driver currently
>   does not use it.
> * Addressed review comments from Sylwester Nawrocki and Tomasz Figa
>   in patch 7/7.
>
> Sachin Kamat (7):
>   ARM: dts: Add G2D node to exynos4210.dtsi
>   ARM: dts: Add G2D node to SMDKV310
>   ARM: dts: Add G2D node to exynos4210-origen
>   ARM: dts: Add G2D node to exynos4x12.dtsi
>   ARM: dts: Add G2D node to SMDK4412
>   ARM: dts: Add G2D node to exynos4412-origen
>   ARM: dts: Add Samsung G2D DT bindings documentation

RE: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

[Kukjin Kim]

Sachin Kamat wrote:
> 
> Hi Kukjin,
> 
> Can you please look into this series as it is pending since quite some time.
> 
Applied, I have another opinion about the compatible string though...

I think, it can be sorted out next time :-)

Thanks.

- Kukjin

> On 18 February 2013 10:32, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > This patch series is based on Kukjin Kim's next/dt-exynos branch of
> > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> > tree.
> >
> > Changes since v1:
> > * Removed power-domain entry in patch 1/7 as the driver currently
> >   does not use it.
> > * Addressed review comments from Sylwester Nawrocki and Tomasz Figa
> >   in patch 7/7.
> >
> > Sachin Kamat (7):
> >   ARM: dts: Add G2D node to exynos4210.dtsi
> >   ARM: dts: Add G2D node to SMDKV310
> >   ARM: dts: Add G2D node to exynos4210-origen
> >   ARM: dts: Add G2D node to exynos4x12.dtsi
> >   ARM: dts: Add G2D node to SMDK4412
> >   ARM: dts: Add G2D node to exynos4412-origen
> >   ARM: dts: Add Samsung G2D DT bindings documentation

Re: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

[Sachin Kamat]

On 11 March 2013 12:24, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Sachin Kamat wrote:
>>
>> Hi Kukjin,
>>
>> Can you please look into this series as it is pending since quite some time.
>>
> Applied, I have another opinion about the compatible string though...

Couldn't find this series in your latest for-next. Please let me know
which branch this is applied to.



>> On 18 February 2013 10:32, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> > This patch series is based on Kukjin Kim's next/dt-exynos branch of
>> > git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
>> > tree.
>> >
>> > Changes since v1:
>> > * Removed power-domain entry in patch 1/7 as the driver currently
>> >   does not use it.
>> > * Addressed review comments from Sylwester Nawrocki and Tomasz Figa
>> >   in patch 7/7.
>> >
>> > Sachin Kamat (7):
>> >   ARM: dts: Add G2D node to exynos4210.dtsi
>> >   ARM: dts: Add G2D node to SMDKV310
>> >   ARM: dts: Add G2D node to exynos4210-origen
>> >   ARM: dts: Add G2D node to exynos4x12.dtsi
>> >   ARM: dts: Add G2D node to SMDK4412
>> >   ARM: dts: Add G2D node to exynos4412-origen
>> >   ARM: dts: Add Samsung G2D DT bindings documentation
>



-- 
With warm regards,
Sachin

RE: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

[Kukjin Kim]

Sachin Kamat wrote:
> 
> On 11 March 2013 12:24, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Sachin Kamat wrote:
> >>
> >> Hi Kukjin,
> >>
> >> Can you please look into this series as it is pending since quite some
> time.
> >>
> > Applied, I have another opinion about the compatible string though...
> 
> Couldn't find this series in your latest for-next. Please let me know
> which branch this is applied to.
> 
Please check again then if any problems, let me know. I think, it should be
fine :-)

Thanks for your gentle reminder.

- Kukjin