* [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576
@ 2024-10-14 2:03 Frank Wang
2024-10-14 2:03 ` [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data Frank Wang
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Frank Wang @ 2024-10-14 2:03 UTC (permalink / raw)
To: vkoul, kishon, robh, krzk+dt, conor+dt, heiko
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, william.wu, tim.chen, yubing.zhang, Frank Wang
From: Frank Wang <frank.wang@rock-chips.com>
Add compatible for the USBDP phy in the Rockchip RK3576 SoC.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
index 1f1f8863b80d..b42f1272903d 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
@@ -13,6 +13,7 @@ maintainers:
properties:
compatible:
enum:
+ - rockchip,rk3576-usbdp-phy
- rockchip,rk3588-usbdp-phy
reg:
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data
2024-10-14 2:03 [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Frank Wang
@ 2024-10-14 2:03 ` Frank Wang
2024-10-14 3:55 ` Dragan Simic
2024-10-14 6:50 ` Heiko Stübner
2024-10-14 3:53 ` [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Dragan Simic
` (3 subsequent siblings)
4 siblings, 2 replies; 8+ messages in thread
From: Frank Wang @ 2024-10-14 2:03 UTC (permalink / raw)
To: vkoul, kishon, robh, krzk+dt, conor+dt, heiko
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, william.wu, tim.chen, yubing.zhang, Frank Wang
From: Frank Wang <frank.wang@rock-chips.com>
This adds RK3576 device match data support.
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
drivers/phy/rockchip/phy-rockchip-usbdp.c | 41 +++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c
index 2c51e5c62d3e..5b1e8a3806ed 100644
--- a/drivers/phy/rockchip/phy-rockchip-usbdp.c
+++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c
@@ -1538,6 +1538,43 @@ static const char * const rk_udphy_rst_list[] = {
"init", "cmn", "lane", "pcs_apb", "pma_apb"
};
+static const struct rk_udphy_cfg rk3576_udphy_cfgs = {
+ .num_phys = 1,
+ .phy_ids = { 0x2b010000 },
+ .num_rsts = ARRAY_SIZE(rk_udphy_rst_list),
+ .rst_list = rk_udphy_rst_list,
+ .grfcfg = {
+ /* u2phy-grf */
+ .bvalid_phy_con = RK_UDPHY_GEN_GRF_REG(0x0010, 1, 0, 0x2, 0x3),
+ .bvalid_grf_con = RK_UDPHY_GEN_GRF_REG(0x0000, 15, 14, 0x1, 0x3),
+
+ /* usb-grf */
+ .usb3otg0_cfg = RK_UDPHY_GEN_GRF_REG(0x0030, 15, 0, 0x1100, 0x0188),
+
+ /* usbdpphy-grf */
+ .low_pwrn = RK_UDPHY_GEN_GRF_REG(0x0004, 13, 13, 0, 1),
+ .rx_lfps = RK_UDPHY_GEN_GRF_REG(0x0004, 14, 14, 0, 1),
+ },
+ .vogrfcfg = {
+ {
+ .hpd_trigger = RK_UDPHY_GEN_GRF_REG(0x0000, 11, 10, 1, 3),
+ .dp_lane_reg = 0x0000,
+ },
+ },
+ .dp_tx_ctrl_cfg = {
+ rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
+ rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
+ rk3588_dp_tx_drv_ctrl_hbr2,
+ rk3588_dp_tx_drv_ctrl_hbr3,
+ },
+ .dp_tx_ctrl_cfg_typec = {
+ rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
+ rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
+ rk3588_dp_tx_drv_ctrl_hbr2,
+ rk3588_dp_tx_drv_ctrl_hbr3,
+ },
+};
+
static const struct rk_udphy_cfg rk3588_udphy_cfgs = {
.num_phys = 2,
.phy_ids = {
@@ -1584,6 +1621,10 @@ static const struct rk_udphy_cfg rk3588_udphy_cfgs = {
};
static const struct of_device_id rk_udphy_dt_match[] = {
+ {
+ .compatible = "rockchip,rk3576-usbdp-phy",
+ .data = &rk3576_udphy_cfgs
+ },
{
.compatible = "rockchip,rk3588-usbdp-phy",
.data = &rk3588_udphy_cfgs
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576
2024-10-14 2:03 [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Frank Wang
2024-10-14 2:03 ` [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data Frank Wang
@ 2024-10-14 3:53 ` Dragan Simic
2024-10-14 6:50 ` Heiko Stübner
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Dragan Simic @ 2024-10-14 3:53 UTC (permalink / raw)
To: Frank Wang
Cc: vkoul, kishon, robh, krzk+dt, conor+dt, heiko, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, linux-rockchip,
william.wu, tim.chen, yubing.zhang, Frank Wang
Hello Frank,
On 2024-10-14 04:03, Frank Wang wrote:
> From: Frank Wang <frank.wang@rock-chips.com>
>
> Add compatible for the USBDP phy in the Rockchip RK3576 SoC.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Looking good to me, thanks for the patch.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> ---
> Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> index 1f1f8863b80d..b42f1272903d 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> @@ -13,6 +13,7 @@ maintainers:
> properties:
> compatible:
> enum:
> + - rockchip,rk3576-usbdp-phy
> - rockchip,rk3588-usbdp-phy
>
> reg:
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data
2024-10-14 2:03 ` [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data Frank Wang
@ 2024-10-14 3:55 ` Dragan Simic
2024-10-14 6:50 ` Heiko Stübner
1 sibling, 0 replies; 8+ messages in thread
From: Dragan Simic @ 2024-10-14 3:55 UTC (permalink / raw)
To: Frank Wang
Cc: vkoul, kishon, robh, krzk+dt, conor+dt, heiko, linux-phy,
devicetree, linux-arm-kernel, linux-kernel, linux-rockchip,
william.wu, tim.chen, yubing.zhang, Frank Wang
Hello Frank,
On 2024-10-14 04:03, Frank Wang wrote:
> From: Frank Wang <frank.wang@rock-chips.com>
>
> This adds RK3576 device match data support.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Looking good to me, thanks for the patch. My focus was on
making sure there are no possible regressions.
Acked-by: Dragan Simic <dsimic@manjaro.org>
> ---
> drivers/phy/rockchip/phy-rockchip-usbdp.c | 41 +++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c
> b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> index 2c51e5c62d3e..5b1e8a3806ed 100644
> --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c
> +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> @@ -1538,6 +1538,43 @@ static const char * const rk_udphy_rst_list[] =
> {
> "init", "cmn", "lane", "pcs_apb", "pma_apb"
> };
>
> +static const struct rk_udphy_cfg rk3576_udphy_cfgs = {
> + .num_phys = 1,
> + .phy_ids = { 0x2b010000 },
> + .num_rsts = ARRAY_SIZE(rk_udphy_rst_list),
> + .rst_list = rk_udphy_rst_list,
> + .grfcfg = {
> + /* u2phy-grf */
> + .bvalid_phy_con = RK_UDPHY_GEN_GRF_REG(0x0010, 1, 0, 0x2, 0x3),
> + .bvalid_grf_con = RK_UDPHY_GEN_GRF_REG(0x0000, 15, 14, 0x1, 0x3),
> +
> + /* usb-grf */
> + .usb3otg0_cfg = RK_UDPHY_GEN_GRF_REG(0x0030, 15, 0, 0x1100,
> 0x0188),
> +
> + /* usbdpphy-grf */
> + .low_pwrn = RK_UDPHY_GEN_GRF_REG(0x0004, 13, 13, 0, 1),
> + .rx_lfps = RK_UDPHY_GEN_GRF_REG(0x0004, 14, 14, 0, 1),
> + },
> + .vogrfcfg = {
> + {
> + .hpd_trigger = RK_UDPHY_GEN_GRF_REG(0x0000, 11, 10, 1, 3),
> + .dp_lane_reg = 0x0000,
> + },
> + },
> + .dp_tx_ctrl_cfg = {
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_hbr2,
> + rk3588_dp_tx_drv_ctrl_hbr3,
> + },
> + .dp_tx_ctrl_cfg_typec = {
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_hbr2,
> + rk3588_dp_tx_drv_ctrl_hbr3,
> + },
> +};
> +
> static const struct rk_udphy_cfg rk3588_udphy_cfgs = {
> .num_phys = 2,
> .phy_ids = {
> @@ -1584,6 +1621,10 @@ static const struct rk_udphy_cfg
> rk3588_udphy_cfgs = {
> };
>
> static const struct of_device_id rk_udphy_dt_match[] = {
> + {
> + .compatible = "rockchip,rk3576-usbdp-phy",
> + .data = &rk3576_udphy_cfgs
> + },
> {
> .compatible = "rockchip,rk3588-usbdp-phy",
> .data = &rk3588_udphy_cfgs
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576
2024-10-14 2:03 [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Frank Wang
2024-10-14 2:03 ` [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data Frank Wang
2024-10-14 3:53 ` [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Dragan Simic
@ 2024-10-14 6:50 ` Heiko Stübner
2024-10-15 20:00 ` Rob Herring (Arm)
2024-10-17 15:35 ` Vinod Koul
4 siblings, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2024-10-14 6:50 UTC (permalink / raw)
To: vkoul, kishon, robh, krzk+dt, conor+dt, Frank Wang
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, william.wu, tim.chen, yubing.zhang, Frank Wang
Am Montag, 14. Oktober 2024, 04:03:41 CEST schrieb Frank Wang:
> From: Frank Wang <frank.wang@rock-chips.com>
>
> Add compatible for the USBDP phy in the Rockchip RK3576 SoC.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> index 1f1f8863b80d..b42f1272903d 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml
> @@ -13,6 +13,7 @@ maintainers:
> properties:
> compatible:
> enum:
> + - rockchip,rk3576-usbdp-phy
> - rockchip,rk3588-usbdp-phy
>
> reg:
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data
2024-10-14 2:03 ` [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data Frank Wang
2024-10-14 3:55 ` Dragan Simic
@ 2024-10-14 6:50 ` Heiko Stübner
1 sibling, 0 replies; 8+ messages in thread
From: Heiko Stübner @ 2024-10-14 6:50 UTC (permalink / raw)
To: vkoul, kishon, robh, krzk+dt, conor+dt, Frank Wang
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, william.wu, tim.chen, yubing.zhang, Frank Wang
Am Montag, 14. Oktober 2024, 04:03:42 CEST schrieb Frank Wang:
> From: Frank Wang <frank.wang@rock-chips.com>
>
> This adds RK3576 device match data support.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
Nice, that the rk3576 support fits in so easily :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/phy/rockchip/phy-rockchip-usbdp.c | 41 +++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> index 2c51e5c62d3e..5b1e8a3806ed 100644
> --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c
> +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c
> @@ -1538,6 +1538,43 @@ static const char * const rk_udphy_rst_list[] = {
> "init", "cmn", "lane", "pcs_apb", "pma_apb"
> };
>
> +static const struct rk_udphy_cfg rk3576_udphy_cfgs = {
> + .num_phys = 1,
> + .phy_ids = { 0x2b010000 },
> + .num_rsts = ARRAY_SIZE(rk_udphy_rst_list),
> + .rst_list = rk_udphy_rst_list,
> + .grfcfg = {
> + /* u2phy-grf */
> + .bvalid_phy_con = RK_UDPHY_GEN_GRF_REG(0x0010, 1, 0, 0x2, 0x3),
> + .bvalid_grf_con = RK_UDPHY_GEN_GRF_REG(0x0000, 15, 14, 0x1, 0x3),
> +
> + /* usb-grf */
> + .usb3otg0_cfg = RK_UDPHY_GEN_GRF_REG(0x0030, 15, 0, 0x1100, 0x0188),
> +
> + /* usbdpphy-grf */
> + .low_pwrn = RK_UDPHY_GEN_GRF_REG(0x0004, 13, 13, 0, 1),
> + .rx_lfps = RK_UDPHY_GEN_GRF_REG(0x0004, 14, 14, 0, 1),
> + },
> + .vogrfcfg = {
> + {
> + .hpd_trigger = RK_UDPHY_GEN_GRF_REG(0x0000, 11, 10, 1, 3),
> + .dp_lane_reg = 0x0000,
> + },
> + },
> + .dp_tx_ctrl_cfg = {
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_hbr2,
> + rk3588_dp_tx_drv_ctrl_hbr3,
> + },
> + .dp_tx_ctrl_cfg_typec = {
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_rbr_hbr_typec,
> + rk3588_dp_tx_drv_ctrl_hbr2,
> + rk3588_dp_tx_drv_ctrl_hbr3,
> + },
> +};
> +
> static const struct rk_udphy_cfg rk3588_udphy_cfgs = {
> .num_phys = 2,
> .phy_ids = {
> @@ -1584,6 +1621,10 @@ static const struct rk_udphy_cfg rk3588_udphy_cfgs = {
> };
>
> static const struct of_device_id rk_udphy_dt_match[] = {
> + {
> + .compatible = "rockchip,rk3576-usbdp-phy",
> + .data = &rk3576_udphy_cfgs
> + },
> {
> .compatible = "rockchip,rk3588-usbdp-phy",
> .data = &rk3588_udphy_cfgs
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576
2024-10-14 2:03 [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Frank Wang
` (2 preceding siblings ...)
2024-10-14 6:50 ` Heiko Stübner
@ 2024-10-15 20:00 ` Rob Herring (Arm)
2024-10-17 15:35 ` Vinod Koul
4 siblings, 0 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2024-10-15 20:00 UTC (permalink / raw)
To: Frank Wang
Cc: kishon, vkoul, heiko, yubing.zhang, linux-kernel, linux-rockchip,
Frank Wang, devicetree, conor+dt, tim.chen, william.wu, linux-phy,
krzk+dt, linux-arm-kernel
On Mon, 14 Oct 2024 10:03:41 +0800, Frank Wang wrote:
> From: Frank Wang <frank.wang@rock-chips.com>
>
> Add compatible for the USBDP phy in the Rockchip RK3576 SoC.
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> ---
> Documentation/devicetree/bindings/phy/phy-rockchip-usbdp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576
2024-10-14 2:03 [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Frank Wang
` (3 preceding siblings ...)
2024-10-15 20:00 ` Rob Herring (Arm)
@ 2024-10-17 15:35 ` Vinod Koul
4 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2024-10-17 15:35 UTC (permalink / raw)
To: kishon, robh, krzk+dt, conor+dt, heiko, Frank Wang
Cc: linux-phy, devicetree, linux-arm-kernel, linux-kernel,
linux-rockchip, william.wu, tim.chen, yubing.zhang, Frank Wang
On Mon, 14 Oct 2024 10:03:41 +0800, Frank Wang wrote:
> Add compatible for the USBDP phy in the Rockchip RK3576 SoC.
>
>
Applied, thanks!
[1/2] dt-bindings: phy: rockchip-usbdp: add rk3576
commit: b3e804ab9aad465ba7285aa5daf83656d5efc59f
[2/2] phy: rockchip: usbdp: add rk3576 device match data
commit: a76de028c619dd18f89786805bcc7bb4d379ea9f
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-10-17 15:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 2:03 [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Frank Wang
2024-10-14 2:03 ` [PATCH 2/2] phy: rockchip: usbdp: add rk3576 device match data Frank Wang
2024-10-14 3:55 ` Dragan Simic
2024-10-14 6:50 ` Heiko Stübner
2024-10-14 3:53 ` [PATCH 1/2] dt-bindings: phy: rockchip-usbdp: add rk3576 Dragan Simic
2024-10-14 6:50 ` Heiko Stübner
2024-10-15 20:00 ` Rob Herring (Arm)
2024-10-17 15:35 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).