From: Tony Prisk <linux@prisktech.co.nz>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: cjb@laptop.org, grant.likely@secretlab.ca,
rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH -next] mmc: wmt-sdmmc: remove unused variable in wmt_complete_data_request()
Date: Tue, 12 Mar 2013 17:03:48 +1300 [thread overview]
Message-ID: <1363061028.23051.1.camel@gitbox> (raw)
In-Reply-To: <CAPgLHd-7nVD3=83wpNtw1cBmkr+xs5iD7tuxZM+PdxWPLtwZsQ@mail.gmail.com>
On Mon, 2013-03-11 at 22:36 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable 'mmc' is initialized but never used
> otherwise, so remove the unused variable.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/mmc/host/wmt-sdmmc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> index 154f0e8..41d5802 100644
> --- a/drivers/mmc/host/wmt-sdmmc.c
> +++ b/drivers/mmc/host/wmt-sdmmc.c
> @@ -348,13 +348,11 @@ static void wmt_complete_data_request(struct wmt_mci_priv *priv)
>
> static irqreturn_t wmt_mci_dma_isr(int irq_num, void *data)
> {
> - struct mmc_host *mmc;
> struct wmt_mci_priv *priv;
>
> int status;
>
> priv = (struct wmt_mci_priv *)data;
> - mmc = priv->mmc;
>
> status = readl(priv->sdmmc_base + SDDMA_CCR) & 0x0F;
>
>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
next prev parent reply other threads:[~2013-03-12 4:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 14:36 [PATCH -next] mmc: wmt-sdmmc: remove unused variable in wmt_complete_data_request() Wei Yongjun
2013-03-12 4:03 ` Tony Prisk [this message]
2013-03-22 16:38 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363061028.23051.1.camel@gitbox \
--to=linux@prisktech.co.nz \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).