* [PATCH -next] mmc: wmt-sdmmc: remove unused variable in wmt_complete_data_request()
@ 2013-03-11 14:36 Wei Yongjun
2013-03-12 4:03 ` Tony Prisk
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-03-11 14:36 UTC (permalink / raw)
To: linux, cjb, grant.likely, rob.herring
Cc: yongjun_wei, linux-arm-kernel, linux-mmc, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The variable 'mmc' is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/mmc/host/wmt-sdmmc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
index 154f0e8..41d5802 100644
--- a/drivers/mmc/host/wmt-sdmmc.c
+++ b/drivers/mmc/host/wmt-sdmmc.c
@@ -348,13 +348,11 @@ static void wmt_complete_data_request(struct wmt_mci_priv *priv)
static irqreturn_t wmt_mci_dma_isr(int irq_num, void *data)
{
- struct mmc_host *mmc;
struct wmt_mci_priv *priv;
int status;
priv = (struct wmt_mci_priv *)data;
- mmc = priv->mmc;
status = readl(priv->sdmmc_base + SDDMA_CCR) & 0x0F;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] mmc: wmt-sdmmc: remove unused variable in wmt_complete_data_request()
2013-03-11 14:36 [PATCH -next] mmc: wmt-sdmmc: remove unused variable in wmt_complete_data_request() Wei Yongjun
@ 2013-03-12 4:03 ` Tony Prisk
2013-03-22 16:38 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Tony Prisk @ 2013-03-12 4:03 UTC (permalink / raw)
To: Wei Yongjun
Cc: cjb, grant.likely, rob.herring, yongjun_wei, linux-arm-kernel,
linux-mmc, devicetree-discuss
On Mon, 2013-03-11 at 22:36 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable 'mmc' is initialized but never used
> otherwise, so remove the unused variable.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/mmc/host/wmt-sdmmc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> index 154f0e8..41d5802 100644
> --- a/drivers/mmc/host/wmt-sdmmc.c
> +++ b/drivers/mmc/host/wmt-sdmmc.c
> @@ -348,13 +348,11 @@ static void wmt_complete_data_request(struct wmt_mci_priv *priv)
>
> static irqreturn_t wmt_mci_dma_isr(int irq_num, void *data)
> {
> - struct mmc_host *mmc;
> struct wmt_mci_priv *priv;
>
> int status;
>
> priv = (struct wmt_mci_priv *)data;
> - mmc = priv->mmc;
>
> status = readl(priv->sdmmc_base + SDDMA_CCR) & 0x0F;
>
>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] mmc: wmt-sdmmc: remove unused variable in wmt_complete_data_request()
2013-03-12 4:03 ` Tony Prisk
@ 2013-03-22 16:38 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2013-03-22 16:38 UTC (permalink / raw)
To: Tony Prisk
Cc: Wei Yongjun, grant.likely, rob.herring, yongjun_wei,
linux-arm-kernel, linux-mmc, devicetree-discuss
Hi,
On Tue, Mar 12 2013, Tony Prisk wrote:
> On Mon, 2013-03-11 at 22:36 +0800, Wei Yongjun wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> The variable 'mmc' is initialized but never used
>> otherwise, so remove the unused variable.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>> ---
>> drivers/mmc/host/wmt-sdmmc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
>> index 154f0e8..41d5802 100644
>> --- a/drivers/mmc/host/wmt-sdmmc.c
>> +++ b/drivers/mmc/host/wmt-sdmmc.c
>> @@ -348,13 +348,11 @@ static void wmt_complete_data_request(struct wmt_mci_priv *priv)
>>
>> static irqreturn_t wmt_mci_dma_isr(int irq_num, void *data)
>> {
>> - struct mmc_host *mmc;
>> struct wmt_mci_priv *priv;
>>
>> int status;
>>
>> priv = (struct wmt_mci_priv *)data;
>> - mmc = priv->mmc;
>>
>> status = readl(priv->sdmmc_base + SDDMA_CCR) & 0x0F;
>>
>>
>
> Acked-by: Tony Prisk <linux@prisktech.co.nz>
Thanks, pushed to mmc-next for 3.10.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-22 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-11 14:36 [PATCH -next] mmc: wmt-sdmmc: remove unused variable in wmt_complete_data_request() Wei Yongjun
2013-03-12 4:03 ` Tony Prisk
2013-03-22 16:38 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).