devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: sameo@linux.intel.com
Cc: balbi@ti.com, b-cousson@ti.com, mark.rutland@arm.com,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	rogerq@ti.com
Subject: [PATCH 3/6] mfd: omap-usb-host: Actually update hostconfig
Date: Tue, 12 Mar 2013 12:25:37 +0200	[thread overview]
Message-ID: <1363083940-20050-4-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1363083940-20050-1-git-send-email-rogerq@ti.com>

The helper functions omap_usbhs_rev1_hostconfig()
and omap_usbhs_rev2_hostconfig() don't write into
the hostconfig register. Make sure that we write
the return value into the hostconfig register.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/mfd/omap-usb-host.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 502a779..c3efe64 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -446,15 +446,15 @@ static void omap_usbhs_init(struct device *dev)
 
 	switch (omap->usbhs_rev) {
 	case OMAP_USBHS_REV1:
-		omap_usbhs_rev1_hostconfig(omap, reg);
+		reg = omap_usbhs_rev1_hostconfig(omap, reg);
 		break;
 
 	case OMAP_USBHS_REV2:
-		omap_usbhs_rev2_hostconfig(omap, reg);
+		reg = omap_usbhs_rev2_hostconfig(omap, reg);
 		break;
 
 	default:	/* newer revisions */
-		omap_usbhs_rev2_hostconfig(omap, reg);
+		reg = omap_usbhs_rev2_hostconfig(omap, reg);
 		break;
 	}
 
-- 
1.7.4.1

  parent reply	other threads:[~2013-03-12 10:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 10:25 [PATCH 0/6] mfd: omap-usb-host: Device tree support for 3.10 Roger Quadros
2013-03-12 10:25 ` [PATCH 2/6] mfd: omap-usb-host: Remove PHY reset handling code Roger Quadros
2013-03-12 10:25 ` Roger Quadros [this message]
     [not found]   ` <1363083940-20050-4-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-03-14 14:03     ` [PATCH 3/6] mfd: omap-usb-host: Actually update hostconfig Felipe Balbi
2013-03-12 10:25 ` [PATCH 4/6] mfd: omap-usb-tll: move configuration code to omap_tll_init() Roger Quadros
2013-03-12 10:25 ` [PATCH 5/6] mfd: omap-usb-tll: Add device tree support and binding information Roger Quadros
     [not found] ` <1363083940-20050-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-03-12 10:25   ` [PATCH 1/6] mfd: omap-usb-host: update nports in platform_data Roger Quadros
2013-03-12 10:25   ` [PATCH 6/6] mfd: omap-usb-host: Add device tree support and binding information Roger Quadros
2013-03-25 10:42 ` [PATCH 0/6] mfd: omap-usb-host: Device tree support for 3.10 Roger Quadros
2013-04-09  7:54   ` Samuel Ortiz
2013-04-09  8:39     ` Roger Quadros
     [not found]       ` <1365496758-16287-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-04-09  8:39         ` [PATCH 1/2] mfd: omap-usb-host: Remove PHY reset handling code Roger Quadros
2013-04-09  8:39         ` [PATCH 2/2] mfd: omap-usb-host: Add device tree support and binding information Roger Quadros
2013-04-09  9:00         ` [PATCH 0/6] mfd: omap-usb-host: Device tree support for 3.10 Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363083940-20050-4-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).