devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
To: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	balbi-l0cyMroinI0@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	rogerq-l0cyMroinI0@public.gmane.org
Subject: [PATCH 02/24] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data
Date: Tue, 12 Mar 2013 13:43:04 +0200	[thread overview]
Message-ID: <1363088606-2692-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1363088606-2692-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>

Add platform device and data for 'nop-usb-xceiv'. This will be used
as PHY for HS USB port 1, so provide binding information for it.

Get rid of managing the PHY clock as it will be done by the PHY driver.
For that to work we create a clock alias that links the PHY clock name
to the PHY device name.

Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
---
 arch/arm/mach-omap2/board-omap4panda.c |   34 ++++++++++++++++++++++---------
 1 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index b02c2f0..feffde6 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -31,6 +31,7 @@
 #include <linux/ti_wilink_st.h>
 #include <linux/usb/musb.h>
 #include <linux/usb/phy.h>
+#include <linux/usb/nop-usb-xceiv.h>
 #include <linux/wl12xx.h>
 #include <linux/irqchip/arm-gic.h>
 #include <linux/platform_data/omap-abe-twl6040.h>
@@ -132,12 +133,27 @@ static struct platform_device btwilink_device = {
 	.id	= -1,
 };
 
+/* PHY device on HS USB Port 1 i.e. nop_usb_xceiv.1 */
+static struct nop_usb_xceiv_platform_data hsusb1_phy_data = {
+	/* FREF_CLK3 provides the 19.2 MHz reference clock to the PHY */
+	.clk_rate = 19200000,
+};
+
+static struct platform_device hsusb1_phy_device = {
+	.name	= "nop_usb_xceiv",
+	.id	= 1,
+	.dev	= {
+		.platform_data = &hsusb1_phy_data,
+	},
+};
+
 static struct platform_device *panda_devices[] __initdata = {
 	&leds_gpio,
 	&wl1271_device,
 	&panda_abe_audio,
 	&panda_hdmi_audio_codec,
 	&btwilink_device,
+	&hsusb1_phy_device,
 };
 
 static struct usbhs_omap_platform_data usbhs_bdata __initdata = {
@@ -158,16 +174,6 @@ static struct gpio panda_ehci_gpios[] __initdata = {
 static void __init omap4_ehci_init(void)
 {
 	int ret;
-	struct clk *phy_ref_clk;
-
-	/* FREF_CLK3 provides the 19.2 MHz reference clock to the PHY */
-	phy_ref_clk = clk_get(NULL, "auxclk3_ck");
-	if (IS_ERR(phy_ref_clk)) {
-		pr_err("Cannot request auxclk3\n");
-		return;
-	}
-	clk_set_rate(phy_ref_clk, 19200000);
-	clk_prepare_enable(phy_ref_clk);
 
 	/* disable the power to the usb hub prior to init and reset phy+hub */
 	ret = gpio_request_array(panda_ehci_gpios,
@@ -181,6 +187,14 @@ static void __init omap4_ehci_init(void)
 	gpio_export(GPIO_HUB_NRESET, 0);
 	gpio_set_value(GPIO_HUB_NRESET, 1);
 
+	/* FREF_CLK3 provides the 19.2 MHz reference clock to the PHY */
+	ret = clk_add_alias("main_clk", "nop_usb_xceiv.1", "auxclk3_ck", NULL);
+	if (ret)
+		pr_err("Failed to add main_clk alias to auxclk3_ck\n");
+
+	/* PHY on HS USB Port 1 i.e. index 0 */
+	usb_bind_phy("ehci-omap.0", 0, "nop_usb_xceiv.1");
+
 	usbhs_init(&usbhs_bdata);
 
 	/* enable power to hub */
-- 
1.7.4.1

  parent reply	other threads:[~2013-03-12 11:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 11:43 [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10 Roger Quadros
2013-03-12 11:43 ` [PATCH 01/24] usb: phy: nop: Add some parameters to platform data Roger Quadros
2013-03-12 11:43 ` [PATCH 03/24] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes Roger Quadros
2013-03-12 11:43 ` [PATCH 06/24] ARM: OMAP3: 3630SDP: " Roger Quadros
2013-03-12 11:43 ` [PATCH 07/24] ARM: OMAP: AM3517crane: " Roger Quadros
2013-03-12 11:43 ` [PATCH 09/24] ARM: OMAP3: cm-t35: " Roger Quadros
     [not found] ` <1363088606-2692-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-03-12 11:43   ` Roger Quadros [this message]
2013-03-12 11:43   ` [PATCH 04/24] ARM: OMAP3: Beagle: " Roger Quadros
2013-03-12 11:43   ` [PATCH 05/24] ARM: OMAP3: 3430SDP: " Roger Quadros
2013-03-12 11:43   ` [PATCH 08/24] ARM: OMAP: AM3517evm: " Roger Quadros
2013-03-12 11:43   ` [PATCH 10/24] ARM: OMAP3: cm-t3517: " Roger Quadros
2013-03-12 11:43   ` [PATCH 12/24] ARM: OMAP3: igep0020: " Roger Quadros
2013-03-12 11:43   ` [PATCH 14/24] ARM: OMAP3: omap3pandora: " Roger Quadros
2013-03-12 11:43   ` [PATCH 15/24] ARM: OMAP3: omap3stalker: " Roger Quadros
2013-03-12 11:43 ` [PATCH 11/24] ARM: OMAP: devkit8000: " Roger Quadros
2013-03-12 11:43 ` [PATCH 13/24] ARM: OMAP3: omap3evm: " Roger Quadros
2013-03-12 11:43 ` [PATCH 16/24] ARM: OMAP3: omap3touchbook: " Roger Quadros
2013-03-12 11:43 ` [PATCH 17/24] ARM: OMAP3: overo: " Roger Quadros
2013-03-12 11:43 ` [PATCH 18/24] ARM: OMAP: zoom: " Roger Quadros
2013-03-12 11:43 ` [PATCH 19/24] ARM: dts: OMAP4: Add HS USB Host IP nodes Roger Quadros
2013-03-12 11:43 ` [PATCH 20/24] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-03-12 11:43 ` [PATCH 21/24] ARM: dts: OMAP3: Add HS USB Host IP nodes Roger Quadros
2013-03-12 11:43 ` [PATCH 22/24] ARM: dts: omap3-beagle: Add USB Host support Roger Quadros
2013-03-12 11:43 ` [PATCH 23/24] ARM: OMAP2+: Allow clock alias provision from device tree Roger Quadros
2013-03-12 13:17   ` Benoit Cousson
     [not found]     ` <513F2AEB.8070702-l0cyMroinI0@public.gmane.org>
2013-03-12 14:01       ` Roger Quadros
2013-03-12 11:43 ` [PATCH 24/24] ARM: dts: omap4-panda: Add clock alias for USB PHY Roger Quadros
2013-03-12 16:40 ` [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10 Tony Lindgren
     [not found]   ` <20130312164007.GZ26093-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-03-13 13:41     ` Roger Quadros
2013-03-13 16:24       ` Tony Lindgren
2013-03-13 16:36         ` Roger Quadros
2013-03-13 16:57           ` Tony Lindgren
2013-03-14 15:41             ` Roger Quadros
2013-03-14 16:54               ` Tony Lindgren
2013-03-15  9:22                 ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363088606-2692-3-git-send-email-rogerq@ti.com \
    --to=rogerq-l0cymroini0@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).