devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: tony@atomide.com
Cc: balbi@ti.com, linux-omap@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, rogerq@ti.com
Subject: [PATCH v2 04/23] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes
Date: Fri, 15 Mar 2013 17:16:25 +0200	[thread overview]
Message-ID: <1363360604-21368-5-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1363360604-21368-1-git-send-email-rogerq@ti.com>

Use usbhs_init_phys() to register the PHY's VCC and RESET
regulators.

The VCC and RESET will then be managed by the PHY driver.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/mach-omap2/board-omap4panda.c |   37 +++++++++----------------------
 1 files changed, 11 insertions(+), 26 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
index feffde6..1c22880 100644
--- a/arch/arm/mach-omap2/board-omap4panda.c
+++ b/arch/arm/mach-omap2/board-omap4panda.c
@@ -147,6 +147,16 @@ static struct platform_device hsusb1_phy_device = {
 	},
 };
 
+static struct usbhs_phy_data phy_data[] __initdata = {
+	{
+		.port = 1,
+		.reset_gpio = GPIO_HUB_NRESET,
+		.vcc_gpio = GPIO_HUB_POWER,
+		.vcc_polarity = 1,
+		.phy_id = "nop_usb_xceiv.1",
+	},
+};
+
 static struct platform_device *panda_devices[] __initdata = {
 	&leds_gpio,
 	&wl1271_device,
@@ -158,35 +168,12 @@ static struct platform_device *panda_devices[] __initdata = {
 
 static struct usbhs_omap_platform_data usbhs_bdata __initdata = {
 	.port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
-	.port_mode[1] = OMAP_USBHS_PORT_MODE_UNUSED,
-	.port_mode[2] = OMAP_USBHS_PORT_MODE_UNUSED,
-	.phy_reset  = false,
-	.reset_gpio_port[0]  = -EINVAL,
-	.reset_gpio_port[1]  = -EINVAL,
-	.reset_gpio_port[2]  = -EINVAL
-};
-
-static struct gpio panda_ehci_gpios[] __initdata = {
-	{ GPIO_HUB_POWER,	GPIOF_OUT_INIT_LOW,  "hub_power"  },
-	{ GPIO_HUB_NRESET,	GPIOF_OUT_INIT_LOW,  "hub_nreset" },
 };
 
 static void __init omap4_ehci_init(void)
 {
 	int ret;
 
-	/* disable the power to the usb hub prior to init and reset phy+hub */
-	ret = gpio_request_array(panda_ehci_gpios,
-				 ARRAY_SIZE(panda_ehci_gpios));
-	if (ret) {
-		pr_err("Unable to initialize EHCI power/reset\n");
-		return;
-	}
-
-	gpio_export(GPIO_HUB_POWER, 0);
-	gpio_export(GPIO_HUB_NRESET, 0);
-	gpio_set_value(GPIO_HUB_NRESET, 1);
-
 	/* FREF_CLK3 provides the 19.2 MHz reference clock to the PHY */
 	ret = clk_add_alias("main_clk", "nop_usb_xceiv.1", "auxclk3_ck", NULL);
 	if (ret)
@@ -195,10 +182,8 @@ static void __init omap4_ehci_init(void)
 	/* PHY on HS USB Port 1 i.e. index 0 */
 	usb_bind_phy("ehci-omap.0", 0, "nop_usb_xceiv.1");
 
+	usbhs_init_phys(phy_data, ARRAY_SIZE(phy_data));
 	usbhs_init(&usbhs_bdata);
-
-	/* enable power to hub */
-	gpio_set_value(GPIO_HUB_POWER, 1);
 }
 
 static struct omap_musb_board_data musb_board_data = {
-- 
1.7.4.1

  reply	other threads:[~2013-03-15 15:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 15:16 [PATCH v2 00/23] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10 Roger Quadros
2013-03-15 15:16 ` Roger Quadros [this message]
2013-03-15 15:16 ` [PATCH v2 06/23] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes Roger Quadros
2013-03-15 16:12   ` Tony Lindgren
2013-03-18 12:42     ` Roger Quadros
2013-03-15 15:16 ` [PATCH v2 08/23] ARM: OMAP: AM3517crane: " Roger Quadros
2013-03-15 15:16 ` [PATCH v2 10/23] ARM: OMAP3: cm-t35: " Roger Quadros
     [not found] ` <1363360604-21368-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-03-15 15:16   ` [PATCH v2 01/23] usb: phy: nop: Add some parameters to platform data Roger Quadros
2013-03-15 15:16   ` [PATCH v2 02/23] ARM: OMAP2+: omap-usb-host: Add usbhs_init_phys() Roger Quadros
2013-03-15 15:16   ` [PATCH v2 03/23] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data Roger Quadros
2013-03-15 15:16   ` [PATCH v2 05/23] ARM: OMAP3: Beagle: Adapt to ehci-omap changes Roger Quadros
2013-03-15 15:16   ` [PATCH v2 07/23] ARM: OMAP3: 3630SDP: " Roger Quadros
2013-03-15 15:16   ` [PATCH v2 09/23] ARM: OMAP: AM3517evm: " Roger Quadros
2013-03-15 15:16   ` [PATCH v2 11/23] ARM: OMAP3: cm-t3517: " Roger Quadros
2013-03-15 15:16   ` [PATCH v2 12/23] ARM: OMAP: devkit8000: " Roger Quadros
2013-03-15 15:16   ` [PATCH v2 18/23] ARM: OMAP3: overo: " Roger Quadros
2013-03-15 15:16   ` [PATCH v2 22/23] ARM: dts: OMAP3: Add HS USB Host IP nodes Roger Quadros
2013-03-15 15:16 ` [PATCH v2 13/23] ARM: OMAP3: igep0020: Adapt to ehci-omap changes Roger Quadros
2013-03-15 15:16 ` [PATCH v2 14/23] ARM: OMAP3: omap3evm: " Roger Quadros
2013-03-15 15:16 ` [PATCH v2 15/23] ARM: OMAP3: omap3pandora: " Roger Quadros
2013-03-15 15:16 ` [PATCH v2 16/23] ARM: OMAP3: omap3stalker: " Roger Quadros
2013-03-15 15:16 ` [PATCH v2 17/23] ARM: OMAP3: omap3touchbook: " Roger Quadros
2013-03-15 15:16 ` [PATCH v2 19/23] ARM: OMAP: zoom: " Roger Quadros
2013-03-15 15:16 ` [PATCH v2 20/23] ARM: dts: OMAP4: Add HS USB Host IP nodes Roger Quadros
2013-03-15 15:16 ` [PATCH v2 21/23] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-03-15 15:16 ` [PATCH v2 23/23] ARM: dts: omap3-beagle: " Roger Quadros
2013-03-19 18:37 ` [PATCH v2 00/23] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10 Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363360604-21368-5-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).