From: "Manjunathappa, Prakash" <prakash.pm@ti.com>
To: davinci-linux-open-source@linux.davincidsp.com,
linux-mmc@vger.kernel.org
Cc: cjb@laptop.org, nsekhar@ti.com, grant.likely@secretlab.ca,
rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk,
hs@denx.de, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mark.rutland@arm.com, arnd@arndb.de, "Manjunathappa,
Prakash" <prakash.pm@ti.com>
Subject: [PATCH v7 1/5] mmc: davinci: allow driver to work without DMA resource
Date: Thu, 28 Mar 2013 18:40:07 +0530 [thread overview]
Message-ID: <1364476211-14322-2-git-send-email-prakash.pm@ti.com> (raw)
In-Reply-To: <1364476211-14322-1-git-send-email-prakash.pm@ti.com>
Do not return probe failure with missing DMA resources,
allow driver to work in PIO mode.
Tested on da850-evm by mounting partition followed by
file creation and deletion.
Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
Tested-by: Sekhar Nori <nsekhar@ti.com>
---
drivers/mmc/host/davinci_mmc.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index f5d46ea..bd848d3 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1191,13 +1191,15 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
if (!r)
- goto out;
- host->rxdma = r->start;
+ dev_warn(&pdev->dev, "RX DMA resource not specified\n");
+ else
+ host->rxdma = r->start;
r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
if (!r)
- goto out;
- host->txdma = r->start;
+ dev_warn(&pdev->dev, "TX DMA resource not specified\n");
+ else
+ host->txdma = r->start;
host->mem_res = mem;
host->base = ioremap(mem->start, mem_size);
--
1.7.4.1
next prev parent reply other threads:[~2013-03-28 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 13:10 [PATCH v7 0/5] Add DT support for davinci_mmc driver Manjunathappa, Prakash
2013-03-28 13:10 ` Manjunathappa, Prakash [this message]
2013-04-02 8:39 ` [PATCH v7 1/5] mmc: davinci: allow driver to work without DMA resource Sekhar Nori
2013-04-02 9:55 ` Manjunathappa, Prakash
2013-03-28 15:28 ` [PATCH v7 0/5] Add DT support for davinci_mmc driver Arnd Bergmann
[not found] ` <1364476211-14322-1-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-04-02 9:57 ` Sekhar Nori
2013-04-02 16:01 ` Chris Ball
[not found] ` <87wqskx6pd.fsf-DGHOrqG7t0YzNDMTQreKSUB+6BGkLq7r@public.gmane.org>
2013-04-03 4:17 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364476211-14322-2-git-send-email-prakash.pm@ti.com \
--to=prakash.pm@ti.com \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hs@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).