From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: linux-arm-kernel@lists.infradead.org,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Stephen Warren <swarren@wwwdotorg.org>,
Russell King <linux@arm.linux.org.uk>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Simon Glass <sjg@chromium.org>, Rhyland Klein <rklein@nvidia.com>,
Pritesh Raithatha <praithatha@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hiroshi Doyu <hdoyu@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Andrew Chew <achew@nvidia.com>,
Mike Turquette <mturquette@linaro.org>,
Thierry Reding <thierry.reding@avionic-design.de>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v9 03/14] clk: tegra: Add TEGRA_PLL_BYPASS flag
Date: Wed, 3 Apr 2013 17:40:37 +0300 [thread overview]
Message-ID: <1365000110-8916-4-git-send-email-pdeschrijver@nvidia.com> (raw)
In-Reply-To: <1365000110-8916-1-git-send-email-pdeschrijver@nvidia.com>
Not all PLLs in Tegra114 have a bypass bit. Adapt the common code to only use
this bit when available.
Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
---
drivers/clk/tegra/clk-pll.c | 12 ++++++++----
drivers/clk/tegra/clk.h | 2 ++
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 3feefb1..4ee6d03 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -171,7 +171,8 @@ static void _clk_pll_enable(struct clk_hw *hw)
clk_pll_enable_lock(pll);
val = pll_readl_base(pll);
- val &= ~PLL_BASE_BYPASS;
+ if (pll->flags & TEGRA_PLL_BYPASS)
+ val &= ~PLL_BASE_BYPASS;
val |= PLL_BASE_ENABLE;
pll_writel_base(val, pll);
@@ -188,7 +189,9 @@ static void _clk_pll_disable(struct clk_hw *hw)
u32 val;
val = pll_readl_base(pll);
- val &= ~(PLL_BASE_BYPASS | PLL_BASE_ENABLE);
+ if (pll->flags & TEGRA_PLL_BYPASS)
+ val &= ~PLL_BASE_BYPASS;
+ val &= ~PLL_BASE_ENABLE;
pll_writel_base(val, pll);
if (pll->flags & TEGRA_PLLM) {
@@ -459,7 +462,7 @@ static unsigned long clk_pll_recalc_rate(struct clk_hw *hw,
val = pll_readl_base(pll);
- if (val & PLL_BASE_BYPASS)
+ if ((pll->flags & TEGRA_PLL_BYPASS) && (val & PLL_BASE_BYPASS))
return parent_rate;
if ((pll->flags & TEGRA_PLL_FIXED) && !(val & PLL_BASE_OVERRIDE)) {
@@ -671,6 +674,7 @@ struct clk *tegra_clk_register_pll(const char *name, const char *parent_name,
struct tegra_clk_pll *pll;
struct clk *clk;
+ pll_flags |= TEGRA_PLL_BYPASS;
pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
freq_table, lock);
if (IS_ERR(pll))
@@ -692,8 +696,8 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name,
{
struct tegra_clk_pll *pll;
struct clk *clk;
- pll_flags |= TEGRA_PLL_LOCK_MISC;
+ pll_flags |= TEGRA_PLL_LOCK_MISC | TEGRA_PLL_BYPASS;
pll = _tegra_init_pll(clk_base, pmc, fixed_rate, pll_params, pll_flags,
freq_table, lock);
if (IS_ERR(pll))
diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h
index b9691dd..fff520a 100644
--- a/drivers/clk/tegra/clk.h
+++ b/drivers/clk/tegra/clk.h
@@ -184,6 +184,7 @@ struct tegra_clk_pll_params {
* TEGRA_PLLE_CONFIGURE - Configure PLLE when enabling.
* TEGRA_PLL_LOCK_MISC - Lock bit is in the misc register instead of the
* base register.
+ * TEGRA_PLL_BYPASS - PLL has bypass bit
*/
struct tegra_clk_pll {
struct clk_hw hw;
@@ -213,6 +214,7 @@ struct tegra_clk_pll {
#define TEGRA_PLL_FIXED BIT(6)
#define TEGRA_PLLE_CONFIGURE BIT(7)
#define TEGRA_PLL_LOCK_MISC BIT(8)
+#define TEGRA_PLL_BYPASS BIT(9)
extern const struct clk_ops tegra_clk_pll_ops;
extern const struct clk_ops tegra_clk_plle_ops;
--
1.7.7.rc0.72.g4b5ea.dirty
next prev parent reply other threads:[~2013-04-03 14:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 14:40 [PATCH v9 00/14] Tegra114 clockframework Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 01/14] clk: tegra: provide dummy cpu car ops Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 02/14] clk: tegra: Refactor PLL programming code Peter De Schrijver
2013-04-03 14:40 ` Peter De Schrijver [this message]
2013-04-03 14:40 ` [PATCH v9 05/14] clk: tegra: Add PLL post divider table Peter De Schrijver
[not found] ` <1365000110-8916-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-03 14:40 ` [PATCH v9 04/14] clk: tegra: introduce TEGRA_PLL_HAS_LOCK_ENABLE Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 06/14] clk: tegra: move from a lock bit idx to a lock mask Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 08/14] clk: tegra: Add flags to tegra_clk_periph() Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 10/14] ARM: tegra: Define Tegra114 CAR binding Peter De Schrijver
2013-04-03 17:55 ` Stephen Warren
2013-04-04 23:29 ` [PATCH v9 00/14] Tegra114 clockframework Stephen Warren
2013-04-03 14:40 ` [PATCH v9 07/14] clk: tegra: Add new fields and PLL types for Tegra114 Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 09/14] clk: tegra: Workaround for Tegra114 MSENC problem Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 11/14] clk: tegra: Implement clocks for Tegra114 Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 12/14] clk: tegra: devicetree match for nvidia,tegra114-car Peter De Schrijver
[not found] ` <1365000110-8916-13-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-03 18:10 ` [PATCH v9 12/14] clk: tegra: devicetree match for nvidia, tegra114-car Stephen Warren
2013-04-03 14:40 ` [PATCH v9 13/14] ARM: dt: Add references to tegra_car clocks Peter De Schrijver
2013-04-03 14:40 ` Peter De Schrijver
2013-04-03 14:40 ` [PATCH v9 14/14] clk: tegra: Remove forced clk_enable of uartd Peter De Schrijver
2013-04-03 17:52 ` [PATCH v9 00/14] Tegra114 clockframework Stephen Warren
[not found] ` <515C6C6E.6060302-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-03 18:27 ` Stephen Warren
[not found] ` <515C7495.8060106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-03 23:23 ` Stephen Warren
[not found] ` <515CB9D9.90303-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-04 8:20 ` Peter De Schrijver
[not found] ` <20130404082043.GY18519-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-04-04 21:20 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365000110-8916-4-git-send-email-pdeschrijver@nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=achew@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=hdoyu@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=pgaikwad@nvidia.com \
--cc=praithatha@nvidia.com \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sjg@chromium.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).