devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>
Cc: devicetree-discuss@lists.ozlabs.org,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Markus Pargmann <mpa@pengutronix.de>,
	Anatolij Gustschin <agust@denx.de>
Subject: [PATCH v3 3/5] mmc: mxcmmc: use slot-gpio API for write-protect detection
Date: Mon,  8 Apr 2013 23:28:07 +0200	[thread overview]
Message-ID: <1365456489-13152-4-git-send-email-agust@denx.de> (raw)
In-Reply-To: <1365456489-13152-1-git-send-email-agust@denx.de>

slot-gpio API suppors read-only detection when "wp-gpios"
property is present in the device tree mmc node. Use this
API for write-protect detection.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
---
v3:
 - add Acked-by line

v2:
 - no changes

 drivers/mmc/host/mxcmmc.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c
index 9845b2d..eb45bf0 100644
--- a/drivers/mmc/host/mxcmmc.c
+++ b/drivers/mmc/host/mxcmmc.c
@@ -38,6 +38,7 @@
 #include <linux/of_device.h>
 #include <linux/of_dma.h>
 #include <linux/of_gpio.h>
+#include <linux/mmc/slot-gpio.h>
 
 #include <asm/dma.h>
 #include <asm/irq.h>
@@ -917,10 +918,11 @@ static int mxcmci_get_ro(struct mmc_host *mmc)
 	if (host->pdata && host->pdata->get_ro)
 		return !!host->pdata->get_ro(mmc_dev(mmc));
 	/*
-	 * Board doesn't support read only detection; let the mmc core
-	 * decide what to do.
+	 * If board doesn't support read only detection (no mmc_gpio
+	 * context or gpio is invalid), then let the mmc core decide
+	 * what to do.
 	 */
-	return -ENOSYS;
+	return mmc_gpio_get_ro(mmc);
 }
 
 static void mxcmci_enable_sdio_irq(struct mmc_host *mmc, int enable)
-- 
1.7.5.4


  parent reply	other threads:[~2013-04-08 21:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 21:28 [PATCH v3 0/5] mmc: mxcmmc: add mpc512x support Anatolij Gustschin
     [not found] ` <1365456489-13152-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2013-04-08 21:28   ` [PATCH v3 1/5] mmc: mxcmmc: fix race conditions for host->req and host->data access Anatolij Gustschin
2013-04-08 21:28 ` [PATCH v3 2/5] mmc: mxcmmc: add mpc512x SDHC support Anatolij Gustschin
2013-04-08 21:28 ` Anatolij Gustschin [this message]
2013-04-08 21:28 ` [PATCH v3 4/5] mmc: mxcmmc: constify mxcmci_devtype Anatolij Gustschin
2013-04-08 21:28 ` [PATCH v3 5/5] mmc: mxcmmc: enable DMA support on mpc512x Anatolij Gustschin
2013-04-12 19:14 ` [PATCH v3 0/5] mmc: mxcmmc: add mpc512x support Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365456489-13152-4-git-send-email-agust@denx.de \
    --to=agust@denx.de \
    --cc=cjb@laptop.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).