From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: [PATCH 00/10 v3] usage()/--help clean up & unification, and extend fdtdump
Date: Mon, 15 Apr 2013 22:13:07 -0400 [thread overview]
Message-ID: <1366078397-14889-1-git-send-email-vapier@gentoo.org> (raw)
Each utility currently open codes how they process options and
implement usage(). This leads to inconsistent behavior and output
which sucks. A bunch also get common things wrong (like sending
--help to stderr).
Rather than go through them one by one and fix their bugs, start
a new mini framework in the util.[ch] code base. This allows the
utils to be much more data driven in their approach to options --
they declare certain structures with the right format, and then
call usage() as needed. The new util code takes care of the rest.
I also snuck in a few minor fixes in this patch series that I
noticed as I was hacking on things. Really I just wanted --scan
and --debug options in the fdtdump tool :).
I've made sure each patch builds & passes `make check` by itself.
So things should be git bisectable.
For the v3 series:
- add dedicated _len read helpers rather than rework existing ones
- rename dprintf() to dumpf() in fdtdump
Mike Frysinger (10):
utilfdt_read_err: use xmalloc funcs
utilfdt_read: pass back up the length of data read
die: constify format string arg
util_version: new helper for displaying version info
fdtdump: make usage a bit more friendly
fdtdump: add a --scan option
dtc/fdt{get,put}/convert-dtsv0-lexer: convert to new usage helpers
util: drop "long" from usage helpers
util: add common ARRAY_SIZE define
fdtdump: add a debug mode
convert-dtsv0-lexer.l | 24 +++++++----
dtc.c | 116 +++++++++++++++++++++++++-------------------------
dtc.h | 1 -
fdtdump.c | 110 ++++++++++++++++++++++++++++++++++++++++++-----
fdtget.c | 60 ++++++++++++--------------
fdtput.c | 63 +++++++++++++--------------
util.c | 84 +++++++++++++++++++++++++++++++++---
util.h | 85 +++++++++++++++++++++++++++++++++++-
8 files changed, 393 insertions(+), 150 deletions(-)
--
1.8.1.2
next reply other threads:[~2013-04-16 2:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 2:13 Mike Frysinger [this message]
[not found] ` <1366078397-14889-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-16 2:13 ` [PATCH 01/10] utilfdt_read_err: use xmalloc funcs Mike Frysinger
2013-04-16 2:13 ` [PATCH 02/10] utilfdt_read: pass back up the length of data read Mike Frysinger
[not found] ` <1366078397-14889-3-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-19 0:49 ` David Gibson
2013-04-16 2:13 ` [PATCH 03/10] die: constify format string arg Mike Frysinger
2013-04-16 2:13 ` [PATCH 04/10] util_version: new helper for displaying version info Mike Frysinger
[not found] ` <1366078397-14889-5-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-19 0:50 ` David Gibson
[not found] ` <20130419005046.GL16400-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2013-04-21 19:26 ` Jon Loeliger
[not found] ` <E1UTztj-0006SA-F8-CYoMK+44s/E@public.gmane.org>
2013-04-22 0:25 ` Mike Frysinger
[not found] ` <201304212025.47665.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-22 15:37 ` Jon Loeliger
[not found] ` <E1UUIno-0004Ox-Dd-CYoMK+44s/E@public.gmane.org>
2013-04-22 15:54 ` Mike Frysinger
[not found] ` <201304221154.08100.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-22 20:44 ` Jon Loeliger
[not found] ` <E1UUNba-0005oJ-Ur-CYoMK+44s/E@public.gmane.org>
2013-04-22 21:16 ` Mike Frysinger
2013-04-22 21:19 ` Mike Frysinger
[not found] ` <201304221719.42982.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-29 10:55 ` David Gibson
2013-04-16 2:13 ` [PATCH 05/10] fdtdump: make usage a bit more friendly Mike Frysinger
[not found] ` <1366078397-14889-6-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-30 8:12 ` David Gibson
[not found] ` <20130430081219.GF20202-W9XWwYn+TF0XU02nzanrWNbf9cGiqdzd@public.gmane.org>
2013-05-13 1:45 ` David Gibson
2013-04-16 2:13 ` [PATCH 06/10] fdtdump: add a --scan option Mike Frysinger
[not found] ` <1366078397-14889-7-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-30 8:12 ` David Gibson
2013-04-16 2:13 ` [PATCH 07/10] dtc/fdt{get, put}/convert-dtsv0-lexer: convert to new usage helpers Mike Frysinger
[not found] ` <1366078397-14889-8-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-30 8:23 ` David Gibson
2013-04-16 2:13 ` [PATCH 08/10] util: drop "long" from " Mike Frysinger
[not found] ` <1366078397-14889-9-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-30 8:12 ` David Gibson
2013-04-16 2:13 ` [PATCH 09/10] util: add common ARRAY_SIZE define Mike Frysinger
[not found] ` <1366078397-14889-10-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-29 10:51 ` David Gibson
2013-04-16 2:13 ` [PATCH 10/10] fdtdump: add a debug mode Mike Frysinger
[not found] ` <1366078397-14889-11-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2013-04-30 8:13 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366078397-14889-1-git-send-email-vapier@gentoo.org \
--to=vapier-abrp7r+bbdudnm+yrofe0a@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).