From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanho Park <chanho61.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: exynoautov9: add syscon reboot/reboot_mode support
Date: Fri, 20 May 2022 12:46:26 +0200 [thread overview]
Message-ID: <13662a9c-19c6-cb3d-6073-c87835a3c95d@linaro.org> (raw)
In-Reply-To: <20220520045210.55132-1-chanho61.park@samsung.com>
On 20/05/2022 06:52, Chanho Park wrote:
> Reboot of exynosautov9 SoC can be handled by setting the bit(
> SWRESET_SYSTEM[1]) of SYSTEM_CONFIGURATION register(PMU + 0x3a00).
> syscon-reboot-mode can be used to indicate the reboot mode for
> bootloader. SYSIP_DAT0 register(PMU + 0x810) will not be cleared after
> reboot so bootloader can enter the boot mode according to the value.
>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> index 0ce46ec5cdc3..d99e53406ee0 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
> @@ -312,6 +312,22 @@ pinctrl_peric1: pinctrl@10830000 {
> pmu_system_controller: system-controller@10460000 {
> compatible = "samsung,exynos7-pmu", "syscon";
> reg = <0x10460000 0x10000>;
> +
> + reboot: syscon-reboot {
> + compatible = "syscon-reboot";
> + regmap = <&pmu_system_controller>;
> + offset = <0x3a00>; /* SYSTEM_CONFIGURATION */
> + value = <0x2>;
> + mask = <0x2>;
> + };
> +
> + reboot_mode: syscon-reboot-mode {
Node name: just "reboot-mode"
> + compatible = "syscon-reboot-mode";
> + offset = <0x810>; /* SYSIP_DAT0 */
> + mode-bootloader = <0xfc>;
> + mode-fastboot = <0xfa>;
> + mode-recovery = <0xff>;
These are magic values understood by firmware, so please add a header
for them (something like include/dt-bindings/soc/rockchip,boot-mode.h
but with some prefixes like EXYNOSAUTOV9_BOOT_FASTBOOT))
> + };
> };
>
> syscon_fsys2: syscon@17c20000 {
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-20 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220520045124epcas2p12235472b7e9f7588003a7c8c238e8866@epcas2p1.samsung.com>
2022-05-20 4:52 ` [PATCH] arm64: dts: exynoautov9: add syscon reboot/reboot_mode support Chanho Park
2022-05-20 10:46 ` Krzysztof Kozlowski [this message]
2022-05-20 11:15 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13662a9c-19c6-cb3d-6073-c87835a3c95d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).