* [PATCH] clk/mpc85xx: Update the compatible string
@ 2013-05-22 8:22 Yuantian.Tang-KZfg59tc24xl57MIdRCFDg
2013-05-30 18:57 ` Mike Turquette
0 siblings, 1 reply; 5+ messages in thread
From: Yuantian.Tang-KZfg59tc24xl57MIdRCFDg @ 2013-05-22 8:22 UTC (permalink / raw)
To: mturquette-QSEj5FYQhm4dnm+yROfE0A
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ
From: Tang Yuantian <yuantian.tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
The compatible string of clock is changed from *-2 to *-2.0
on chassis 2. So updated it accordingly.
Signed-off-by: Tang Yuantian <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/clk/clk-ppc-corenet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
index a2d483f..e958707 100644
--- a/drivers/clk/clk-ppc-corenet.c
+++ b/drivers/clk/clk-ppc-corenet.c
@@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
static const struct of_device_id ppc_clk_ids[] __initconst = {
{ .compatible = "fsl,qoriq-clockgen-1.0", },
- { .compatible = "fsl,qoriq-clockgen-2", },
+ { .compatible = "fsl,qoriq-clockgen-2.0", },
{}
};
--
1.8.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] clk/mpc85xx: Update the compatible string
2013-05-22 8:22 [PATCH] clk/mpc85xx: Update the compatible string Yuantian.Tang-KZfg59tc24xl57MIdRCFDg
@ 2013-05-30 18:57 ` Mike Turquette
2013-05-30 19:21 ` Mike Turquette
0 siblings, 1 reply; 5+ messages in thread
From: Mike Turquette @ 2013-05-30 18:57 UTC (permalink / raw)
Cc: Tang Yuantian, devicetree-discuss, linuxppc-dev
Quoting Yuantian.Tang@freescale.com (2013-05-22 01:22:19)
> From: Tang Yuantian <yuantian.tang@freescale.com>
>
> The compatible string of clock is changed from *-2 to *-2.0
> on chassis 2. So updated it accordingly.
>
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
Taken into clk-next.
Regards,
Mike
> ---
> drivers/clk/clk-ppc-corenet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
> index a2d483f..e958707 100644
> --- a/drivers/clk/clk-ppc-corenet.c
> +++ b/drivers/clk/clk-ppc-corenet.c
> @@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
>
> static const struct of_device_id ppc_clk_ids[] __initconst = {
> { .compatible = "fsl,qoriq-clockgen-1.0", },
> - { .compatible = "fsl,qoriq-clockgen-2", },
> + { .compatible = "fsl,qoriq-clockgen-2.0", },
> {}
> };
>
> --
> 1.8.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk/mpc85xx: Update the compatible string
2013-05-30 18:57 ` Mike Turquette
@ 2013-05-30 19:21 ` Mike Turquette
2013-05-30 19:26 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Mike Turquette @ 2013-05-30 19:21 UTC (permalink / raw)
To: Mike Turquette, Yuantian.Tang-KZfg59tc24xl57MIdRCFDg
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ
Quoting Mike Turquette (2013-05-30 11:57:32)
> Quoting Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org (2013-05-22 01:22:19)
> > From: Tang Yuantian <yuantian.tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >
> > The compatible string of clock is changed from *-2 to *-2.0
> > on chassis 2. So updated it accordingly.
> >
> > Signed-off-by: Tang Yuantian <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Taken into clk-next.
>
One small nitpick. I updated the $SUBJECT to:
clk: mpc85xx: Update the compatible string
The difference being "clk: mpc85xx:" versus "clk/mpc85xx:". Please use
the former format in the future.
Thanks,
Mike
> Regards,
> Mike
>
> > ---
> > drivers/clk/clk-ppc-corenet.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c
> > index a2d483f..e958707 100644
> > --- a/drivers/clk/clk-ppc-corenet.c
> > +++ b/drivers/clk/clk-ppc-corenet.c
> > @@ -260,7 +260,7 @@ static int __init ppc_corenet_clk_probe(struct platform_device *pdev)
> >
> > static const struct of_device_id ppc_clk_ids[] __initconst = {
> > { .compatible = "fsl,qoriq-clockgen-1.0", },
> > - { .compatible = "fsl,qoriq-clockgen-2", },
> > + { .compatible = "fsl,qoriq-clockgen-2.0", },
> > {}
> > };
> >
> > --
> > 1.8.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] clk/mpc85xx: Update the compatible string
2013-05-30 19:21 ` Mike Turquette
@ 2013-05-30 19:26 ` Kumar Gala
[not found] ` <17C23704-7017-427C-A00F-CEFA6247D65D-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2013-05-30 19:26 UTC (permalink / raw)
To: Mike Turquette
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ
On May 30, 2013, at 2:21 PM, Mike Turquette wrote:
> Quoting Mike Turquette (2013-05-30 11:57:32)
>> Quoting Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org (2013-05-22 01:22:19)
>>> From: Tang Yuantian <yuantian.tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>>
>>> The compatible string of clock is changed from *-2 to *-2.0
>>> on chassis 2. So updated it accordingly.
>>>
>>> Signed-off-by: Tang Yuantian <Yuantian.Tang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>
>> Taken into clk-next.
>>
>
> One small nitpick. I updated the $SUBJECT to:
>
> clk: mpc85xx: Update the compatible string
>
> The difference being "clk: mpc85xx:" versus "clk/mpc85xx:". Please use
> the former format in the future.
>
> Thanks,
> Mike
Mike,
If clk-ppc-corenet.c went into v3.10, than I think this fix is needed there and shouldn't wait til v3.11
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-30 19:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-22 8:22 [PATCH] clk/mpc85xx: Update the compatible string Yuantian.Tang-KZfg59tc24xl57MIdRCFDg
2013-05-30 18:57 ` Mike Turquette
2013-05-30 19:21 ` Mike Turquette
2013-05-30 19:26 ` Kumar Gala
[not found] ` <17C23704-7017-427C-A00F-CEFA6247D65D-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2013-05-30 19:44 ` Mike Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).