public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names
Date: Fri, 20 Jan 2023 13:54:07 +0900	[thread overview]
Message-ID: <13697e8c-977d-aad3-18d6-e520fc1013f8@socionext.com> (raw)
In-Reply-To: <20230120020339.3223112-1-robh@kernel.org>

Hi Rob,

On 2023/01/20 11:03, Rob Herring wrote:
> The child nodes 'pinctrl', 'usb-hub', and 'clock-controller' in the
> socionext,uniphier-soc-glue binding are not patterns, but the full node
> name, so move them to 'properties'. As patterns, they were missing start
> and end anchors so any prefix or suffix was allowed.
> 
> Fixes: 0611adff8b3a ("dt-bindings: soc: socionext: Add UniPhier SoC-glue
> logic")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   .../bindings/soc/socionext/socionext,uniphier-soc-glue.yaml      | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> index 4b6852db4747..7845dcfca986 100644
> ---
> a/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> +++
> b/Documentation/devicetree/bindings/soc/socionext/socionext,uniphier-soc-g
> lue.yaml
> @@ -32,7 +32,6 @@ properties:
>     reg:
>       maxItems: 1
>   
> -patternProperties:
>     pinctrl:
>       $ref: /schemas/pinctrl/socionext,uniphier-pinctrl.yaml#
>   

Thanks for pointing out.
This is because I forgot to remove it when I changed the child node,
and it should be removed.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Thank you,

---
Best Regards
Kunihiko Hayashi

  reply	other threads:[~2023-01-20  5:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20  2:03 [PATCH] dt-bindings: soc: socionext,uniphier-soc-glue: Make child node names fixed names Rob Herring
2023-01-20  4:54 ` Kunihiko Hayashi [this message]
2023-01-23 21:24 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13697e8c-977d-aad3-18d6-e520fc1013f8@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox