From: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
To: myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
anish198519851985-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
kishon-l0cyMroinI0@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: [PATCH 4/5] usb: dwc3: omap: improve error handling of dwc3_omap_probe
Date: Mon, 3 Jun 2013 21:43:39 +0530 [thread overview]
Message-ID: <1370276020-17446-5-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1370276020-17446-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
Improved the error handling of dwc3_omap_probe so that on error
conditions dwc3_omap is left in the original state.
Signed-off-by: Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>
---
drivers/usb/dwc3/dwc3-omap.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 34638b9..f8f76e6 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -347,7 +347,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
dev_err(dev, "get_sync failed with err %d\n", ret);
- return ret;
+ goto err0;
}
reg = dwc3_omap_readl(omap->base, USBOTGSS_UTMI_OTG_STATUS);
@@ -376,7 +376,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
if (ret) {
dev_err(dev, "failed to request IRQ #%d --> %d\n",
omap->irq, ret);
- return ret;
+ goto err1;
}
dwc3_omap_enable_irqs(omap);
@@ -384,10 +384,21 @@ static int dwc3_omap_probe(struct platform_device *pdev)
ret = of_platform_populate(node, NULL, NULL, dev);
if (ret) {
dev_err(&pdev->dev, "failed to create dwc3 core\n");
- return ret;
+ goto err2;
}
return 0;
+
+err2:
+ dwc3_omap_disable_irqs(omap);
+
+err1:
+ pm_runtime_put_sync(dev);
+
+err0:
+ pm_runtime_disable(dev);
+
+ return ret;
}
static int dwc3_omap_remove(struct platform_device *pdev)
--
1.7.10.4
next prev parent reply other threads:[~2013-06-03 16:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 16:13 [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework Kishon Vijay Abraham I
[not found] ` <1370276020-17446-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-03 16:13 ` [PATCH 1/5] extcon: Add an API to get extcon device from dt node Kishon Vijay Abraham I
2013-06-12 1:28 ` Chanwoo Choi
[not found] ` <1370276020-17446-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-12 1:39 ` [PATCH] " Chanwoo Choi
2013-06-12 5:16 ` anish singh
2013-06-12 6:55 ` Kishon Vijay Abraham I
2013-06-14 5:08 ` Chanwoo Choi
2013-06-14 7:15 ` [PATCH v2] " Chanwoo Choi
[not found] ` <1371194146-17260-1-git-send-email-cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-06-14 8:36 ` Kishon Vijay Abraham I
2013-06-14 8:51 ` Chanwoo Choi
2013-06-19 5:26 ` [PATCH v3] " Chanwoo Choi
2013-06-03 16:13 ` [PATCH 2/5] extcon: Kconfig: Make extcon config type as bool Kishon Vijay Abraham I
2013-06-03 16:13 ` Kishon Vijay Abraham I [this message]
2013-06-03 16:13 ` [PATCH 3/5] extcon: add EXPORT_SYMBOL_GPL for exported functions Kishon Vijay Abraham I
2013-06-03 16:13 ` [v3 PATCH 5/5] usb: dwc3: use extcon fwrk to receive connect/disconnect Kishon Vijay Abraham I
2013-06-14 13:10 ` [PATCH v4] " Kishon Vijay Abraham I
2013-06-17 4:09 ` Chanwoo Choi
[not found] ` <51BE8C0D.9060003-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-06-20 8:54 ` Kishon Vijay Abraham I
2013-06-21 11:58 ` [PATCH v5] " Kishon Vijay Abraham I
[not found] ` <1371815921-28303-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-24 11:12 ` Chanwoo Choi
2013-06-04 14:23 ` [PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework Ruchika Kharwar
2013-06-05 4:49 ` Kishon Vijay Abraham I
2013-06-12 0:54 ` Chanwoo Choi
[not found] ` <51B7C6E0.3000603-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-06-12 0:58 ` Chanwoo Choi
2013-06-12 0:59 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370276020-17446-5-git-send-email-kishon@ti.com \
--to=kishon-l0cymroini0@public.gmane.org \
--cc=anish198519851985-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).