From: Joe Perches <joe@perches.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: grant.likely@linaro.org, rob.herring@calxeda.com,
maxime.ripard@free-electrons.com, davem@davemloft.net,
sr@denx.de, yongjun_wei@trendmicro.com.cn,
netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH -next] net: sun4i-emac: fix a typo in emac_probe()
Date: Mon, 03 Jun 2013 09:20:49 -0700 [thread overview]
Message-ID: <1370276449.2025.33.camel@joe-AO722> (raw)
In-Reply-To: <CAPgLHd-fXnt9H_CxDD1Ww=C-6nn3COVkYirKY6ucOJVR2Pkwkw@mail.gmail.com>
On Mon, 2013-06-03 at 21:36 +0800, Wei Yongjun wrote:
> Just fixed a typo in emac_probe().
also fixed a memory leak.
> diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
[]
> @@ -821,7 +821,7 @@ static int emac_probe(struct platform_device *pdev)
> db->membase = of_iomap(np, 0);
> if (!db->membase) {
> dev_err(&pdev->dev, "failed to remap registers\n");
> - return -ENOMEM;
> + ret = -ENOMEM;
> goto out;
> }
out:
dev_err(db->dev, "not found (%d).\n", ret);
free_netdev(ndev);
next prev parent reply other threads:[~2013-06-03 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:36 [PATCH -next] net: sun4i-emac: fix a typo in emac_probe() Wei Yongjun
2013-06-03 16:20 ` Joe Perches [this message]
2013-06-04 13:24 ` Maxime Ripard
2013-06-05 0:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370276449.2025.33.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=sr@denx.de \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).