devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: grant.likely@linaro.org, tony@atomide.com, balbi@ti.com,
	kishon@ti.com, arnd@arndb.de, swarren@nvidia.com,
	sylvester.nawrocki@gmail.com, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	akpm@linux-foundation.org
Cc: rob.herring@calxeda.com, rob@landley.net, b-cousson@ti.com,
	linux@arm.linux.org.uk, benoit.cousson@linaro.org,
	mchehab@redhat.com, cesarb@cesarb.net, davem@davemloft.net,
	rnayak@ti.com, shawn.guo@linaro.org, santosh.shilimkar@ti.com,
	devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
	nsekhar@ti.com
Subject: [PATCH v7 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops
Date: Thu, 13 Jun 2013 14:13:59 +0530	[thread overview]
Message-ID: <1371113039-5784-10-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1371113039-5784-1-git-send-email-kishon@ti.com>

Now that twl4030-usb is adapted to the new generic PHY framework,
*set_suspend* and *phy_init* ops can be removed from twl4030-usb driver.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/usb/phy/phy-twl4030-usb.c |   55 ++++++++-----------------------------
 1 file changed, 12 insertions(+), 43 deletions(-)

diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c
index fba9697..5245b86 100644
--- a/drivers/usb/phy/phy-twl4030-usb.c
+++ b/drivers/usb/phy/phy-twl4030-usb.c
@@ -422,25 +422,20 @@ static void twl4030_phy_power(struct twl4030_usb *twl, int on)
 	}
 }
 
-static void twl4030_phy_suspend(struct twl4030_usb *twl, int controller_off)
+static int twl4030_phy_power_off(struct phy *phy)
 {
+	struct twl4030_usb *twl = dev_get_drvdata(&phy->dev);
+
 	if (twl->asleep)
-		return;
+		return 0;
 
 	twl4030_phy_power(twl, 0);
 	twl->asleep = 1;
 	dev_dbg(twl->dev, "%s\n", __func__);
-}
-
-static int twl4030_phy_power_off(struct phy *phy)
-{
-	struct twl4030_usb *twl = dev_get_drvdata(&phy->dev);
-
-	twl4030_phy_suspend(twl, 0);
 	return 0;
 }
 
-static void __twl4030_phy_resume(struct twl4030_usb *twl)
+static void __twl4030_phy_power_on(struct twl4030_usb *twl)
 {
 	twl4030_phy_power(twl, 1);
 	twl4030_i2c_access(twl, 1);
@@ -449,11 +444,13 @@ static void __twl4030_phy_resume(struct twl4030_usb *twl)
 		twl4030_i2c_access(twl, 0);
 }
 
-static void twl4030_phy_resume(struct twl4030_usb *twl)
+static int twl4030_phy_power_on(struct phy *phy)
 {
+	struct twl4030_usb *twl = dev_get_drvdata(&phy->dev);
+
 	if (!twl->asleep)
-		return;
-	__twl4030_phy_resume(twl);
+		return 0;
+	__twl4030_phy_power_on(twl);
 	twl->asleep = 0;
 	dev_dbg(twl->dev, "%s\n", __func__);
 
@@ -466,13 +463,6 @@ static void twl4030_phy_resume(struct twl4030_usb *twl)
 		cancel_delayed_work(&twl->id_workaround_work);
 		schedule_delayed_work(&twl->id_workaround_work, HZ);
 	}
-}
-
-static int twl4030_phy_power_on(struct phy *phy)
-{
-	struct twl4030_usb *twl = dev_get_drvdata(&phy->dev);
-
-	twl4030_phy_resume(twl);
 	return 0;
 }
 
@@ -604,9 +594,9 @@ static void twl4030_id_workaround_work(struct work_struct *work)
 	}
 }
 
-static int twl4030_usb_phy_init(struct usb_phy *phy)
+static int twl4030_phy_init(struct phy *phy)
 {
-	struct twl4030_usb *twl = phy_to_twl(phy);
+	struct twl4030_usb *twl = dev_get_drvdata(&phy->dev);
 	enum omap_musb_vbus_id_status status;
 
 	/*
@@ -628,25 +618,6 @@ static int twl4030_usb_phy_init(struct usb_phy *phy)
 	return 0;
 }
 
-static int twl4030_phy_init(struct phy *phy)
-{
-	struct twl4030_usb *twl = dev_get_drvdata(&phy->dev);
-
-	return twl4030_usb_phy_init(&twl->phy);
-}
-
-static int twl4030_set_suspend(struct usb_phy *x, int suspend)
-{
-	struct twl4030_usb *twl = phy_to_twl(x);
-
-	if (suspend)
-		twl4030_phy_suspend(twl, 1);
-	else
-		twl4030_phy_resume(twl);
-
-	return 0;
-}
-
 static int twl4030_set_peripheral(struct usb_otg *otg,
 					struct usb_gadget *gadget)
 {
@@ -717,8 +688,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
 	twl->phy.label		= "twl4030";
 	twl->phy.otg		= otg;
 	twl->phy.type		= USB_PHY_TYPE_USB2;
-	twl->phy.set_suspend	= twl4030_set_suspend;
-	twl->phy.init		= twl4030_usb_phy_init;
 
 	otg->phy		= &twl->phy;
 	otg->set_host		= twl4030_set_host;
-- 
1.7.10.4


  parent reply	other threads:[~2013-06-13  8:43 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13  8:43 [PATCH v7 0/9] Generic PHY Framework Kishon Vijay Abraham I
2013-06-13  8:43 ` [PATCH v7 1/9] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-06-18  9:38   ` Felipe Balbi
2013-06-18 21:22   ` Sylwester Nawrocki
2013-06-24  6:37     ` Kishon Vijay Abraham I
2013-06-19 15:49   ` Sylwester Nawrocki
2013-06-20  5:28     ` Kishon Vijay Abraham I
2013-06-13  8:43 ` [PATCH v7 3/9] usb: phy: twl4030: use the new " Kishon Vijay Abraham I
2013-06-18  9:42   ` Felipe Balbi
     [not found] ` <1371113039-5784-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-13  8:43   ` [PATCH v7 2/9] usb: phy: omap-usb2: " Kishon Vijay Abraham I
2013-06-18  9:40     ` Felipe Balbi
     [not found]       ` <20130618094058.GQ5461-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-06-18  9:49         ` Kishon Vijay Abraham I
2013-06-18  9:50           ` Felipe Balbi
2013-06-18  9:56             ` Kishon Vijay Abraham I
2013-06-18 10:00               ` Felipe Balbi
2013-06-13  8:43   ` [PATCH v7 4/9] usb: phy: twl4030: twl4030 shouldn't be subsys_initcall Kishon Vijay Abraham I
     [not found]     ` <1371113039-5784-5-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-18  9:43       ` Felipe Balbi
2013-06-13  8:43   ` [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-06-18  9:44     ` Felipe Balbi
     [not found]       ` <20130618094438.GT5461-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-06-18 10:04         ` Kishon Vijay Abraham I
2013-06-18 10:27           ` Felipe Balbi
2013-06-18 11:13             ` Kishon Vijay Abraham I
2013-06-18 12:35               ` Felipe Balbi
2013-06-18 14:55                 ` Kishon Vijay Abraham I
2013-06-18 14:57                   ` Felipe Balbi
2013-06-13  8:43   ` [PATCH v7 6/9] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-06-18  9:45     ` Felipe Balbi
2013-06-13  8:43   ` [PATCH v7 8/9] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-06-18  9:47     ` Felipe Balbi
2013-06-13  8:43 ` [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-06-18  9:47   ` Felipe Balbi
2013-06-24  5:31     ` Kishon Vijay Abraham I
2013-06-24  6:37       ` Felipe Balbi
2013-06-13  8:43 ` Kishon Vijay Abraham I [this message]
2013-06-18  9:47   ` [PATCH v7 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Felipe Balbi
2013-06-17 10:16 ` [PATCH v7 0/9] Generic PHY Framework Sylwester Nawrocki
     [not found]   ` <51BEE203.6090103-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-06-18  9:49     ` Felipe Balbi
2013-06-24 19:27       ` Sylwester Nawrocki
     [not found]         ` <51C89D98.1070806-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-06-24 19:34           ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371113039-5784-10-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=benoit.cousson@linaro.org \
    --cc=cesarb@cesarb.net \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mchehab@redhat.com \
    --cc=nsekhar@ti.com \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=santosh.shilimkar@ti.com \
    --cc=shawn.guo@linaro.org \
    --cc=swarren@nvidia.com \
    --cc=sylvester.nawrocki@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).