* [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()
@ 2013-06-18 5:00 Wei Yongjun
2013-06-18 10:03 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-06-18 5:00 UTC (permalink / raw)
To: mchehab, grant.likely, rob.herring, p.zabel, javier.martin,
k.debski, hans.verkuil
Cc: yongjun_wei, linux-media, devicetree-discuss
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing unlock before return from function coda_stop_streaming()
in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/media/platform/coda.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
index df4ada88..2c3cd17 100644
--- a/drivers/media/platform/coda.c
+++ b/drivers/media/platform/coda.c
@@ -1347,6 +1347,7 @@ static int coda_stop_streaming(struct vb2_queue *q)
if (coda_command_sync(ctx, CODA_COMMAND_SEQ_END)) {
v4l2_err(&dev->v4l2_dev,
"CODA_COMMAND_SEQ_END failed\n");
+ mutex_unlock(&dev->coda_mutex);
return -ETIMEDOUT;
}
mutex_unlock(&dev->coda_mutex);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()
2013-06-18 5:00 [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming() Wei Yongjun
@ 2013-06-18 10:03 ` Philipp Zabel
2013-06-18 12:23 ` Wei Yongjun
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Zabel @ 2013-06-18 10:03 UTC (permalink / raw)
To: Wei Yongjun
Cc: mchehab, grant.likely, rob.herring, javier.martin, k.debski,
hans.verkuil, yongjun_wei, linux-media, devicetree-discuss
Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock before return from function coda_stop_streaming()
> in the error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/media/platform/coda.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
> index df4ada88..2c3cd17 100644
> --- a/drivers/media/platform/coda.c
> +++ b/drivers/media/platform/coda.c
> @@ -1347,6 +1347,7 @@ static int coda_stop_streaming(struct vb2_queue *q)
> if (coda_command_sync(ctx, CODA_COMMAND_SEQ_END)) {
> v4l2_err(&dev->v4l2_dev,
> "CODA_COMMAND_SEQ_END failed\n");
> + mutex_unlock(&dev->coda_mutex);
> return -ETIMEDOUT;
> }
> mutex_unlock(&dev->coda_mutex);
>
>
Thanks! If you don't mind, I'll integrate this change into the "[media]
coda: add CODA7541 decoding support" for v2.
regards
Philipp
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()
2013-06-18 10:03 ` Philipp Zabel
@ 2013-06-18 12:23 ` Wei Yongjun
0 siblings, 0 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-06-18 12:23 UTC (permalink / raw)
To: p.zabel
Cc: mchehab, grant.likely, rob.herring, javier.martin, k.debski,
hans.verkuil, yongjun_wei, linux-media, devicetree-discuss
On 06/18/2013 06:03 PM, Philipp Zabel wrote:
> Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Add the missing unlock before return from function coda_stop_streaming()
>> in the error handling case.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>> ---
>> drivers/media/platform/coda.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
>> index df4ada88..2c3cd17 100644
>> --- a/drivers/media/platform/coda.c
>> +++ b/drivers/media/platform/coda.c
>> @@ -1347,6 +1347,7 @@ static int coda_stop_streaming(struct vb2_queue *q)
>> if (coda_command_sync(ctx, CODA_COMMAND_SEQ_END)) {
>> v4l2_err(&dev->v4l2_dev,
>> "CODA_COMMAND_SEQ_END failed\n");
>> + mutex_unlock(&dev->coda_mutex);
>> return -ETIMEDOUT;
>> }
>> mutex_unlock(&dev->coda_mutex);
>>
>>
> Thanks! If you don't mind, I'll integrate this change into the "[media]
> coda: add CODA7541 decoding support" for v2.
No problem. Thanks.
Yongjun Wei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-18 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-18 5:00 [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming() Wei Yongjun
2013-06-18 10:03 ` Philipp Zabel
2013-06-18 12:23 ` Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).