devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: grant.likely@linaro.org, tony@atomide.com, balbi@ti.com,
	kishon@ti.com, arnd@arndb.de, swarren@nvidia.com,
	sylvester.nawrocki@gmail.com, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
	akpm@linux-foundation.org
Cc: rob.herring@calxeda.com, rob@landley.net, linux@arm.linux.org.uk,
	benoit.cousson@linaro.org, mchehab@redhat.com, cesarb@cesarb.net,
	davem@davemloft.net, rnayak@ti.com, shawn.guo@linaro.org,
	santosh.shilimkar@ti.com, devicetree-discuss@lists.ozlabs.org,
	linux-doc@vger.kernel.org, nsekhar@ti.com, balajitk@ti.com,
	george.cherian@ti.com
Subject: [PATCH v8 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2
Date: Tue, 25 Jun 2013 11:28:45 +0530	[thread overview]
Message-ID: <1372139926-3719-8-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1372139926-3719-1-git-send-email-kishon@ti.com>

Now that omap-usb2 is adapted to the new generic PHY framework,
*set_suspend* ops can be removed from omap-usb2 driver.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 drivers/usb/phy/phy-omap-usb2.c |   25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c
index ecdf1ac..7171426 100644
--- a/drivers/usb/phy/phy-omap-usb2.c
+++ b/drivers/usb/phy/phy-omap-usb2.c
@@ -97,29 +97,6 @@ static int omap_usb_set_peripheral(struct usb_otg *otg,
 	return 0;
 }
 
-static int omap_usb2_suspend(struct usb_phy *x, int suspend)
-{
-	u32 ret;
-	struct omap_usb *phy = phy_to_omapusb(x);
-
-	if (suspend && !phy->is_suspended) {
-		omap_control_usb_phy_power(phy->control_dev, 0);
-		pm_runtime_put_sync(phy->dev);
-		phy->is_suspended = 1;
-	} else if (!suspend && phy->is_suspended) {
-		ret = pm_runtime_get_sync(phy->dev);
-		if (ret < 0) {
-			dev_err(phy->dev, "get_sync failed with err %d\n",
-									ret);
-			return ret;
-		}
-		omap_control_usb_phy_power(phy->control_dev, 1);
-		phy->is_suspended = 0;
-	}
-
-	return 0;
-}
-
 static int omap_usb_power_off(struct phy *x)
 {
 	struct omap_usb *phy = dev_get_drvdata(&x->dev);
@@ -167,7 +144,6 @@ static int omap_usb2_probe(struct platform_device *pdev)
 
 	phy->phy.dev		= phy->dev;
 	phy->phy.label		= "omap-usb2";
-	phy->phy.set_suspend	= omap_usb2_suspend;
 	phy->phy.otg		= otg;
 	phy->phy.type		= USB_PHY_TYPE_USB2;
 
@@ -182,7 +158,6 @@ static int omap_usb2_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	phy->is_suspended	= 1;
 	omap_control_usb_phy_power(phy->control_dev, 0);
 
 	otg->set_host		= omap_usb_set_host;
-- 
1.7.10.4


  parent reply	other threads:[~2013-06-25  5:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25  5:58 [PATCH v8 0/8] Generic PHY Framework Kishon Vijay Abraham I
2013-06-25  5:58 ` [PATCH v8 2/8] usb: phy: omap-usb2: use the new generic PHY framework Kishon Vijay Abraham I
2013-06-25 15:18   ` Felipe Balbi
2013-06-25  5:58 ` [PATCH v8 3/8] usb: phy: twl4030: " Kishon Vijay Abraham I
2013-06-25 15:19   ` Felipe Balbi
2013-06-25  5:58 ` [PATCH v8 4/8] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-06-25 15:19   ` Felipe Balbi
2013-06-25  5:58 ` [PATCH v8 5/8] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-06-25 15:19   ` Felipe Balbi
     [not found] ` <1372139926-3719-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-25  5:58   ` [PATCH v8 1/8] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-06-25 15:17     ` Felipe Balbi
2013-06-25  5:58   ` [PATCH v8 6/8] usb: musb: omap2430: use the new " Kishon Vijay Abraham I
2013-06-25 15:20     ` Felipe Balbi
2013-06-25  5:58 ` Kishon Vijay Abraham I [this message]
2013-06-25 15:20   ` [PATCH v8 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Felipe Balbi
2013-06-25  5:58 ` [PATCH v8 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
2013-06-25 15:21   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372139926-3719-8-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=balajitk@ti.com \
    --cc=balbi@ti.com \
    --cc=benoit.cousson@linaro.org \
    --cc=cesarb@cesarb.net \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=george.cherian@ti.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mchehab@redhat.com \
    --cc=nsekhar@ti.com \
    --cc=rnayak@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=santosh.shilimkar@ti.com \
    --cc=shawn.guo@linaro.org \
    --cc=swarren@nvidia.com \
    --cc=sylvester.nawrocki@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).